URL:
<
http://savannah.nongnu.org/bugs/?27858>
Summary: PPP: missing call to netif_set_down()
Project: lwIP - A Lightweight TCP/IP stack
Submitted by: iordan_neshev
Submitted on: Fri 30 Oct 2009 11:48:39 AM GMT
Category: None
Severity: 3 - Normal
Item Group: Change Request
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release:
lwIP version: CVS Head
_______________________________________________________
Details:
This is moved here from patch #6965: PPP improvements.
ppp.c: int sifdown()
> *line 1388: add a function call
>
> pc->if_up = 0;
> netif_set_down(&pc->netif); // <-- this line is missing
> netif_remove(&pc->netif);
The missing function call clears the NETIF_FLAG_UP flag
and calls the status and link callbacks, which
should be present when either (or both)
LWIP_NETIF_STATUS_CALLBACK and/or LWIP_NETIF_LINK_CALLBACK
are defined.
This may be important for the users who use
status & link callbacks + PPP. For me it works,
though the callbacks are dummy.
Should be planned for lwip 1.4
_______________________________________________________
Reply to this item at:
<
http://savannah.nongnu.org/bugs/?27858>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/_______________________________________________
lwip-devel mailing list
lwip-devel@...
http://lists.nongnu.org/mailman/listinfo/lwip-devel
