[bug #36177] reserved identifier violation

[Jimmy Zelinskie]

URL:
  <http://savannah.gnu.org/bugs/?36177>

                 Summary: reserved identifier violation
                 Project: GNU FreeIPMI
            Submitted by: elfring
            Submitted on: Sa 14 Apr 2012 18:53:04 CEST
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Portability Issue
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None

    _______________________________________________________

Details:

I would like to point out that identifiers like "_IPMIDETECTD_H
<http://svn.savannah.gnu.org/viewvc/trunk/ipmidetectd/ipmidetectd.h?revision=8165&root=freeipmi&view=markup>"
and "_IPMI_SENSORS_H
<http://svn.savannah.gnu.org/viewvc/trunk/ipmi-sensors/ipmi-sensors.h?revision=8165&root=freeipmi&view=markup>"
do not fit
<https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29>
to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36177>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/


_______________________________________________
Freeipmi-devel mailing list
Freeipmi-devel@...
https://lists.gnu.org/mailman/listinfo/freeipmi-devel

[Jimmy Zelinskie]

Follow-up Comment #1, bug #36177 (project freeipmi):

Wasn't aware of this at all, I'll do an audit and try to fix up a number of
these.

Is this an issue for you in the stable branch?  Or would it be ok to leave in
the devel branch and release when the next major release comes out?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36177>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Freeipmi-devel mailing list
Freeipmi-devel@...
https://lists.gnu.org/mailman/listinfo/freeipmi-devel

[Jimmy Zelinskie]

Follow-up Comment #2, bug #36177 (project freeipmi):

A corresponding correction would be fine for me with the next possible
software release.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36177>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/


_______________________________________________
Freeipmi-devel mailing list
Freeipmi-devel@...
https://lists.gnu.org/mailman/listinfo/freeipmi-devel

[Jimmy Zelinskie]

Update of bug #36177 (project freeipmi):

             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #3:

While simple the changes were in a lot of places, so I'm not too comfortable
porting this back to the stable branch.  I'll make sure it's in the next major
release (major here meaning X.Y+1.Z).  Most likely to be released middle this
year.  Thanks for the report.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36177>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Freeipmi-devel mailing list
Freeipmi-devel@...
https://lists.gnu.org/mailman/listinfo/freeipmi-devel