[bug #36229] #define ⇒ enum?

View: New views
4 Messages — Rating Filter:   Alert me  

[bug #36229] #define ⇒ enum?

by Jimmy Zelinskie :: Rate this Message:

| View Threaded | Show Only this Message

URL:
  <http://savannah.gnu.org/bugs/?36229>

                 Summary: #define ⇒ enum?
                 Project: XBoard
            Submitted by: elfring
            Submitted on: Di 17 Apr 2012 20:58:29 CEST
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: None

    _______________________________________________________

Details:

Would you like to replace more defines for constant values by enumerations
<http://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages>
to stress their relationships?
* STATE_...
<http://git.savannah.gnu.org/cgit/xboard.git/tree/engineoutput.h?id=dcb381e902c84b25e2a7301c5ba1d9f437503b5b#n54>
* PEN_...
<http://git.savannah.gnu.org/cgit/xboard.git/tree/evalgraph.h?id=e70077aab0199817f37aef9ed0bdba1bbca93b45#n30>




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36229>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
https://lists.gnu.org/mailman/listinfo/bug-xboard

[bug #36229] #define ⇒ enum?

by Jimmy Zelinskie :: Rate this Message:

| View Threaded | Show Only this Message

Update of bug #36229 (project xboard):

                  Status:                    None => Ready For Test        

    _______________________________________________________

Follow-up Comment #1:

Thanks for the suggestions. Changed STATE and PEN variables to enums.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36229>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
https://lists.gnu.org/mailman/listinfo/bug-xboard

[bug #36229] #define ⇒ enum?

by Jimmy Zelinskie :: Rate this Message:

| View Threaded | Show Only this Message

Follow-up Comment #2, bug #36229 (project xboard):

Would a similar conversion be useful for identifiers like the following?
 * ICS_...
<http://git.savannah.gnu.org/cgit/xboard.git/tree/backend.h?id=003ab519c36430f6df51e0e6e2aa528476894161#n266>
 * ..._FONT
<http://git.savannah.gnu.org/cgit/xboard.git/tree/common.h?id=003ab519c36430f6df51e0e6e2aa528476894161#n179>,
BACK_TEXTURE_MODE_...
 * W_...
<http://git.savannah.gnu.org/cgit/xboard.git/tree/dialogs.h?id=003ab519c36430f6df51e0e6e2aa528476894161#n82>
 * EP_...
<http://git.savannah.gnu.org/cgit/xboard.git/tree/moves.h?id=003ab519c36430f6df51e0e6e2aa528476894161#n85>
 * CP...
<http://git.savannah.gnu.org/cgit/xboard.git/tree/usystem.h?id=003ab519c36430f6df51e0e6e2aa528476894161#n57>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36229>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
https://lists.gnu.org/mailman/listinfo/bug-xboard

[bug #36229] #define ⇒ enum?

by Jimmy Zelinskie :: Rate this Message:

| View Threaded | Show Only this Message

Update of bug #36229 (project xboard):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #3:

changed the ICS_ ones, the other ones are not as straight forward to change...
patches welcome though ;) For now I'll close this bug.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36229>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Bug-XBoard mailing list
Bug-XBoard@...
https://lists.gnu.org/mailman/listinfo/bug-xboard