[gant-scm] [10429] gant/trunk/src/main/groovy/org/codehaus/gant/GantMetaClass.java: Remove the commented out code as requested in the comment after a release.

[russel-9]

Some parts of this message have been removed. Learn more about Nabble's security policy.

Revision

10429

Author

russel

Date

2009-10-18 14:12:27 -0500 (Sun, 18 Oct 2009)

Log Message

Remove the commented out code as requested in the comment after a release.

Modified Paths

• gant/trunk/src/main/groovy/org/codehaus/gant/GantMetaClass.java

Diff

Modified: gant/trunk/src/main/groovy/org/codehaus/gant/GantMetaClass.java (10428 => 10429)

--- gant/trunk/src/main/groovy/org/codehaus/gant/GantMetaClass.java	2009-10-18 19:12:23 UTC (rev 10428)
+++ gant/trunk/src/main/groovy/org/codehaus/gant/GantMetaClass.java	2009-10-18 19:12:27 UTC (rev 10429)
@@ -132,21 +132,11 @@
         catch ( final MissingPropertyException mpe ) { /* Purposefully empty */ }
       }
       catch ( final MissingMethodException mme ) {
-        /*
-         *  This was originally part of Yoel Spotts proposal of the GANT-10 fix, but it seems superfluous.
-         *
-         *  TODO:  Remove this after the release.
-         *
-        if ( binding.getVariable ( methodName ) != null ) {
-          //  Let Script handle this if the name is in the binding.
-          throw mme ;
-        }
-        */
         try { returnObject = ( (GantBuilder) ( binding.getVariable ( "ant" ) ) ).invokeMethod ( methodName , arguments ) ; }
         catch ( final BuildException be ) {
           //  This BuildException could be a real exception due to a failed execution of a found Ant task
           //  (in which case it should be propagated), or it could be due to a failed name lookup (in which
-          //  case the MissingMethodException should be propogated).  The big problem is distinguishing the
+          //  case the MissingMethodException should be propagated).  The big problem is distinguishing the
           //  various uses of Build Exception here -- for now use string search of the exception message to
           //  distinguish the cases.  NB GANT-49 and GANT-68 are the main conflicting issues here :-(
           if ( be.getMessage ( ).startsWith ( "Problem: failed to create task or type" ) ) { throw mme ; }

---

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email