[gant-scm] [jira] Created: (GANT-111) Exceptions caught in gant are wrapped in an exception that is not a descendant of ant's BuildException

Exceptions caught in gant are wrapped in an exception that is not a descendant of ant's BuildException
------------------------------------------------------------------------------------------------------

                 Key: GANT-111
                 URL: http://jira.codehaus.org/browse/GANT-111
             Project: Gant
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.8.0
            Reporter: Eric Van Dewoestine
             Fix For: 1.9.0
         Attachments: gant_buildexception.diff

When an exception is raised and subsequently caught by gant, that exception is wrapped in a TargetExecutionException, which is not a descendant of ant's BuildException, and that exception is then thrown.  This can be problematic when gant is invoked from ant since ant handles BuildExceptions differently than all other exception types.

When ant catches a BuildException it will suppress the stack trace associated with that exception (unless you add the -debug flag) and simply print a normal ant failure message that ant users should be accustom to.  When ant catches the TargetExecutionException (or any non-BuildException descendant), it will print out its stack trace, which in turn will print the root exception stack trace leading to two very large stack traces dumped onto the screen.

A slightly worse case arises if the gant build file issues a call to ant.fail(message: "some message"), which will again result in the two very large stack traces printed, since the BuildException raised by the fail task is wrapped in a non-BuildException.  Since ant.fail can be commonly used to abort a build and report useful information to the user, having that information buried in stack traces can severely affect the usability of the build file.

Attached is a patch which alters GantException to now subclass BuildException and adds a test case where the fail task is invoked in gant from a parent ant script.


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
    <a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>

     [ http://jira.codehaus.org/browse/GANT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Russel Winder resolved GANT-111.
--------------------------------

    Resolution: Fixed

Test and patch applied.  All the Bazaar branches have been updated and the distributions and artefacts also.

> Exceptions caught in gant are wrapped in an exception that is not a descendant of ant's BuildException
> ------------------------------------------------------------------------------------------------------
>
>                 Key: GANT-111
>                 URL: http://jira.codehaus.org/browse/GANT-111
>             Project: Gant
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.8.0
>            Reporter: Eric Van Dewoestine
>             Fix For: 1.9.0
>
>         Attachments: gant_buildexception.diff
>
>
> When an exception is raised and subsequently caught by gant, that exception is wrapped in a TargetExecutionException, which is not a descendant of ant's BuildException, and that exception is then thrown.  This can be problematic when gant is invoked from ant since ant handles BuildExceptions differently than all other exception types.
> When ant catches a BuildException it will suppress the stack trace associated with that exception (unless you add the -debug flag) and simply print a normal ant failure message that ant users should be accustom to.  When ant catches the TargetExecutionException (or any non-BuildException descendant), it will print out its stack trace, which in turn will print the root exception stack trace leading to two very large stack traces dumped onto the screen.
> A slightly worse case arises if the gant build file issues a call to ant.fail(message: "some message"), which will again result in the two very large stack traces printed, since the BuildException raised by the fail task is wrapped in a non-BuildException.  Since ant.fail can be commonly used to abort a build and report useful information to the user, having that information buried in stack traces can severely affect the usability of the build file.
> Attached is a patch which alters GantException to now subclass BuildException and adds a test case where the fail task is invoked in gant from a parent ant script.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
    <a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>

     [ http://jira.codehaus.org/browse/GANT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Russel Winder reassigned GANT-111:
----------------------------------

    Assignee: Russel Winder

> Exceptions caught in gant are wrapped in an exception that is not a descendant of ant's BuildException
> ------------------------------------------------------------------------------------------------------
>
>                 Key: GANT-111
>                 URL: http://jira.codehaus.org/browse/GANT-111
>             Project: Gant
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.8.0
>            Reporter: Eric Van Dewoestine
>            Assignee: Russel Winder
>             Fix For: 1.9.0
>
>         Attachments: gant_buildexception.diff
>
>
> When an exception is raised and subsequently caught by gant, that exception is wrapped in a TargetExecutionException, which is not a descendant of ant's BuildException, and that exception is then thrown.  This can be problematic when gant is invoked from ant since ant handles BuildExceptions differently than all other exception types.
> When ant catches a BuildException it will suppress the stack trace associated with that exception (unless you add the -debug flag) and simply print a normal ant failure message that ant users should be accustom to.  When ant catches the TargetExecutionException (or any non-BuildException descendant), it will print out its stack trace, which in turn will print the root exception stack trace leading to two very large stack traces dumped onto the screen.
> A slightly worse case arises if the gant build file issues a call to ant.fail(message: "some message"), which will again result in the two very large stack traces printed, since the BuildException raised by the fail task is wrapped in a non-BuildException.  Since ant.fail can be commonly used to abort a build and report useful information to the user, having that information buried in stack traces can severely affect the usability of the build file.
> Attached is a patch which alters GantException to now subclass BuildException and adds a test case where the fail task is invoked in gant from a parent ant script.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
    <a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>

     [ http://jira.codehaus.org/browse/GANT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Russel Winder closed GANT-111.
------------------------------

> Exceptions caught in gant are wrapped in an exception that is not a descendant of ant's BuildException
> ------------------------------------------------------------------------------------------------------
>
>                 Key: GANT-111
>                 URL: http://jira.codehaus.org/browse/GANT-111
>             Project: Gant
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.8.0
>            Reporter: Eric Van Dewoestine
>            Assignee: Russel Winder
>             Fix For: 1.9.0
>
>         Attachments: gant_buildexception.diff
>
>
> When an exception is raised and subsequently caught by gant, that exception is wrapped in a TargetExecutionException, which is not a descendant of ant's BuildException, and that exception is then thrown.  This can be problematic when gant is invoked from ant since ant handles BuildExceptions differently than all other exception types.
> When ant catches a BuildException it will suppress the stack trace associated with that exception (unless you add the -debug flag) and simply print a normal ant failure message that ant users should be accustom to.  When ant catches the TargetExecutionException (or any non-BuildException descendant), it will print out its stack trace, which in turn will print the root exception stack trace leading to two very large stack traces dumped onto the screen.
> A slightly worse case arises if the gant build file issues a call to ant.fail(message: "some message"), which will again result in the two very large stack traces printed, since the BuildException raised by the fail task is wrapped in a non-BuildException.  Since ant.fail can be commonly used to abort a build and report useful information to the user, having that information buried in stack traces can severely affect the usability of the build file.
> Attached is a patch which alters GantException to now subclass BuildException and adds a test case where the fail task is invoked in gant from a parent ant script.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
    <a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>