[gatewiki-commits] SF.net SVN: gatewiki:[1766] trunk/cow

View: New views

1 Messages — Rating Filter: Alert me

[gatewiki-commits] SF.net SVN: gatewiki:[1766] trunk/cow

by hcunningham-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Revision: 1766
http://gatewiki.svn.sourceforge.net/gatewiki/?rev=1766&view=rev
Author: hcunningham
Date: 2009-10-27 21:44:07 +0000 (Tue, 27 Oct 2009)

Log Message:
-----------
report the full path when hitting a bad sandbox directory;
backlog the need to catch the exception on wiki creation and during bootstrap

Modified Paths:
--------------
trunk/cow/doc/cow-backlog.html
trunk/cow/doc/cow-backlog.yam
trunk/cow/src/java/gate/versioning/svnkit/SandboxManager.java

Modified: trunk/cow/doc/cow-backlog.html
===================================================================
--- trunk/cow/doc/cow-backlog.html 2009-10-27 20:41:20 UTC (rev 1765)
+++ trunk/cow/doc/cow-backlog.html 2009-10-27 21:44:07 UTC (rev 1766)
@@ -59,48 +59,48 @@
<a class="cow-section-anchor" name="section-1."/><h1 class="cow-heading">1. Roadmap (version 1.0)</h1>

<ul>
-<li>dependencies issue [AR]
+<li>dependencies issue [AR]</li>
<ul>
<li>the serialised dependencies files should include the run mode in the name
(dev, prod, test), or else they may be saved relative to one wiki in e.g.
dev mode then restored relative to another in production mode?</li>
- </ul></li>
-<li>layout [IR]
+ </ul>
+<li>layout [IR]</li>
<ul>
<li>directory-level actions, where to put the links, how to select?</li>
- </ul></li>
-<li>webflows [IR]
+ </ul>
+<li>webflows [IR]</li>
<ul>
<li>note: when a missing page is linked to and the page with the link then
edited with FckEdit, the ?m=1 parameter is duplicated</li>
<li>add copy and delete flows</li>
- <li>upload
+ <li>upload</li>
<ul>
<li>upload of .tgz fails without message</li>
<li>upload of .zip of a directory claims to work but creates a zero-length
file for directories</li>
<li>upload of an empty file fails without a message</li>
- </ul></li>
- </ul></li>
-<li>GAU
+ </ul>
+ </ul>
+<li>GAU</li>
<ul>
- <li>g8rs.net
+ <li>g8rs.net</li>
<ul>
<li>ge1/2 cross-snapshots (inc. /etc and /home) into /home/backup</li>
<li>stop running on 8080</li>
<li>get cron to publish security-related log reports somewhere (in the wiki
space?) [IR]</li>
- </ul></li>
+ </ul>
<li>turn of the DB realm log messages</li>
<li>externals in gau-main-tree for sale, gate etc.</li>
<li>migration: set up duplicate of existing apache server first then do janet
swap</li>
- </ul></li>
-<li>jape yamalyser [HC, NA]
+ </ul>
+<li>jape yamalyser [HC, NA]</li>
<ul>
<li>fix tests for YamPrettyTranslator</li>
<li>switch on the old yam-html-yam test again</li>
- </ul></li>
+ </ul>
<li>what happens to footnotes (or twitters) in included files? [HC]</li>
<li>go to 1.0 snapshots</li>
<li>user guide to logging in, editing etc., revise <a class="cow-url" href="gatewiki.html">gatewiki.html</a> [HC]</li>
@@ -108,27 +108,27 @@
</ul>

<ul>
-<li>misc bugs [all]
+<li>misc bugs [all]</li>
<ul>
<li>make a page containing a table with two rows, one of which is empty. Save
or preview results in the entire page content being dropped without
warning. (i.e. the error reporting seems broken; faults in table syntax
- generate yam errors; need to look into this)
+ generate yam errors; need to look into this)</li>
<ul>
<li>The underlying parser error for this has now been fixed but the
principle still stands that we should handle yam parsing errors more
cleanly. [IR]</li>
- </ul></li>
+ </ul>
<li>if the last thing in a table is a verbatim (%<...>%) item, that thing
will not be verbatimised [need to check if this is in the list of known
yam bugs below nad if not add it]</li>
- <li>security stuff [AR]
+ <li>security stuff [AR]</li>
<ul>
<li>the g:paginate call in jsecUserRoleMappings/listByRole.gsp needs an id
param adding ant -Dgate.cow.grails.command="install-plugin
/data/herd/gate-top/externals/gatewiki/site-plugins/grails-gate2-0.1.zip"
grails</li>
- </ul></li>
+ </ul>
<li>images in links don't work, e.g.: %(tmp/summer.html,
%image(tmp/Screenshot.png) ), and predicate arguments are also not parsed
[HC]</li>
@@ -140,7 +140,13 @@
<li>other bugs, see
<a class="cow-url" href="http://sourceforge.net/tracker2/?func=browse&group_id=208243&atid=1004913">http://sourceforge.net/tracker2/?func=browse&group_id=208243&atid=1004913</a>
(move to a jira?)</li>
- </ul></li>
+ <li>create a new wiki area with a non-existant directory as the target
+ sandbox; the exception that gets thrown by SandboxManager is reported
+ (though not nicely), but the wiki area still gets created. need to trap
+ the exception, report it (and log it) and then abort the area creation.
+ this probably also kills bootstrap when the SbManager call is being made
+ during startup</li>
+ </ul>
</ul>

<ul>
@@ -155,10 +161,10 @@

<ul>
<li>double-hyphen is not legal in an XML comment. If we want the xhtml generated
- from YAM to be well-formed we need to massage comment strings appropriately.
+ from YAM to be well-formed we need to massage comment strings appropriately.</li>
<ul>
<li>Noticed this when testing the JDOM HTML-to-yam code.</li>
- </ul></li>
+ </ul>
<li>add tooltips, e.g.:
<g:javascript>
new Tip(
@@ -172,31 +178,31 @@
<li>add exclusions for / and /help to HtmlTranslator so that links to these
areas are not considered to be missing pages [HC]</li>
<li>add %center(...) to YAM</li>
-<li>remaining layout issues: [HC]
+<li>remaining layout issues: [HC]</li>
<ul>
<li>give an id to tables so that we can easily control the default border
setting from the CSS, and verify that plugins / layouts can override the
default border created by yam2html</li>
- </ul></li>
+ </ul>
<li>team wiki ... [MG, HC]</li>
<li>move <tt>cowrc.groovy</tt> inside <tt>cowrc.d</tt>? One less thing to reconfigure when
you want to run more than one CoW on the same machine.</li>
-<li>fix conflict between Quartz versions [has been done during 1.1.1 upgrade?]
+<li>fix conflict between Quartz versions [has been done during 1.1.1 upgrade?]</li>
<ul>
<li>Grails provides Quartz 1.6.x</li>
<li>the Quartz plugin uses 1.5.2</li>
- <li>these are incompatiable
+ <li>these are incompatiable</li>
<ul>
<li>currently fixed by placing 1.6.1 in the quartz plugin directory</li>
<li>THIS IS A NASTY HACK!</li>
- </ul></li>
- </ul></li>
+ </ul>
+ </ul>
<li>Set the session timeout. See
<a class="cow-url" href="http://www.nabble.com/Jsecurity-setting-the-session-time-out-td20521251.html">http://www.nabble.com/Jsecurity-setting-the-session-time-out-td20521251.html</a>
and any changes to plugin since it was written</li>
<li>add ability to do syntax highlighting on code listings, with something like
%code(...) using <a class="cow-url" href="http://code.google.com/p/google-code-prettify/">http://code.google.com/p/google-code-prettify/</a></li>
-<li>regeneration
+<li>regeneration</li>
<ul>
<li>setContext on the YamFile</li>
<li>use the PageService edit-related methods for regeneration (have a fake
@@ -206,43 +212,43 @@
<li>change PS to delete dependent HTML files before doing update; this will
solve potential conflicts in HTML when YAM changes, for example</li>
<li>turn quartz job back on and check for conflicts problems</li>
- </ul></li>
+ </ul>
</ul>

<ul>
-<li>grails 1.2
+<li>grails 1.2</li>
<ul>
<li>figure out how to get e.g. the gau site plugin to reference plugin files
from the layout without the full path? (cf. the images links in cowguest)</li>
- </ul></li>
-<li>[CoW] dependencies
+ </ul>
+<li>[CoW] dependencies</li>
<ul>
<li>at the moment, dependencies regeneration runs in the foreground. But
should it be a background job? background would be good e.g. overnight,
but foreground might be better usually, as it is always run by an admin,
who perhaps wants to know when it goes wrong? think about it.</li>
- </ul></li>
-<li>[CoW] paths
+ </ul>
+<li>[CoW] paths</li>
<ul>
- <li>create a new install, login as admin:
+ <li>create a new install, login as admin:</li>
<ul>
<li>gives: "About to create a new page (or directory) named cow... ok?"</li>
<li>but going in via admin browse wikis works ok</li>
<li>or, it sometimes gives a directory listing instead of the existing
index.html</li>
- </ul></li>
- </ul></li>
-<li>[CoW] wiki functions
+ </ul>
+ </ul>
+<li>[CoW] wiki functions</li>
<ul>
- <li>PS refactoring, and gate.util.Yammer
+ <li>PS refactoring, and gate.util.Yammer</li>
<ul>
<li>PageService could be more concise and clearer if it had an object model
for the various types of page and the files on disk (gate.cow.Page,
YamPage/TxtPage/BareHtmlPage/Directory extends Page, with
overwrite/toStaging/fromStaging methods). PS.analyse would then put the
appropriate type into the page model</li>
- </ul></li>
- </ul></li>
+ </ul>
+ </ul>
</ul>

<ul>
@@ -251,7 +257,7 @@
just go on adding more and more plugins to do small jobs like this, or could
we allow CoW administrators to create snippets somewhere and then have a
general plugin (like the Grails blurb plugin)? disadvantage: ties YAM to
- CoW, which is not currently the case...
+ CoW, which is not currently the case...</li>
<ul>
<li><FORM method="GET" action="<a class="cow-url" href="http://sourceforge.net/search/">">http://sourceforge.net/search/"></a></li>
<li>Search <a href="mail/index.html">the mailing list</a>:</li>
@@ -261,11 +267,11 @@
<li><input type="text" cols="30" name="words"></li>
<li><input type="submit" name="Submit" value="Submit"></li>
<li></FORM></li>
- </ul></li>
+ </ul>
</ul>

<ul>
-<li>[CoW] misc
+<li>[CoW] misc</li>
<ul>
<li>autosuggest LinkedOpenData references during authoring?</li>
<li>using cow:pageLink etc.: <a class="cow-url" href="g-page-to-cow-page.patch">this patch</a> makes the
@@ -277,15 +283,15 @@
<a class="cow-url" href="http://www.spectrum.ieee.org/print/1699">http://www.spectrum.ieee.org/print/1699</a></li>
<li>RSS: try the feeds plugin</li>
<li>add latex import and support lyx</li>
- <li>exploit gant latex build for cow latex output
+ <li>exploit gant latex build for cow latex output</li>
<ul>
<li>includeTool << gate.tools.LaTeX</li>
- </ul></li>
- <li>look at S5 for slides output
+ </ul>
+ <li>look at S5 for slides output</li>
<ul>
<li><a class="cow-url" href="http://www.g2s5.com/presentation/s5express">http://www.g2s5.com/presentation/s5express</a>
<a class="cow-url" href="http://www.odelia-technologies.com/g2s5">http://www.odelia-technologies.com/g2s5</a></li>
- </ul></li>
+ </ul>
<li>try diff version of FCKEdit and try to get rid of
PageService.FckEscapesFix</li>
<li>bibtex support via <a class="cow-url" href="http://jabref.sourceforge.net/">http://jabref.sourceforge.net/</a> ?</li>
@@ -296,49 +302,49 @@
<li>round trip with freemind: <a class="cow-url" href="http://freemind.sourceforge.net/">http://freemind.sourceforge.net/</a></li>
<li>ability to link between areas, and link to help from
doc/main-index-template.yam, for example</li>
- </ul></li>
-<li>[CoW] semantics integration
+ </ul>
+<li>[CoW] semantics integration</li>
<ul>
- <li>clone/questio
+ <li>clone/questio</li>
<ul>
<li>start from olaf's grails-gate-plugin code</li>
<li>make questio a grails plugin</li>
<li>(maybe) allow yam language to pull in configured predicates</li>
<li>make url mappings accept plugin controllers</li>
- </ul></li>
+ </ul>
<li>%questio and %sparql (or %owl-nl and %owl-sparql?) in YAM; translation
puts AJAX code that pings OWLService <HC, AR></li>
- <li>JS code to embed in cow (gatewiki.sf.net) pages that
+ <li>JS code to embed in cow (gatewiki.sf.net) pages that</li>
<ul>
<li>contains a SERQL (or other) query</li>
<li>registers an on-load event</li>
<li>when the page is viewed in a browser, send the query to the Grails
service and renders the result (inserts it into the DOM)</li>
- </ul></li>
- </ul></li>
-<li>[CoW] PageController <HC>
+ </ul>
+ </ul>
+<li>[CoW] PageController <HC></li>
<ul>
- <li>possible optimisations of the PageService check-out-to-staging code:
+ <li>possible optimisations of the PageService check-out-to-staging code:</li>
<ul>
<li>use the SVNRep API, see:
<a class="cow-url" href="http://www.nabble.com/Re%3A-check-out-a-single-file--p15719277.html">http://www.nabble.com/Re%3A-check-out-a-single-file--p15719277.html</a></li>
- </ul></li>
- </ul></li>
-<li>[CoW] pre-publication area
+ </ul>
+ </ul>
+<li>[CoW] pre-publication area</li>
<ul>
- <li>/trunk/ and /branches/ and pre-publication edits and so on
+ <li>/trunk/ and /branches/ and pre-publication edits and so on</li>
<ul>
<li>create a single "editing" branch. or a new branch for every edit? every
user?</li>
<li>a new branch can just be a new Wiki</li>
<li>new roles: production-editor vs. branch-editor? (former can edit live
site)</li>
- </ul></li>
- </ul></li>
+ </ul>
+ </ul>
</ul>

<ul>
-<li>[CoW] security, authorisation and authentication
+<li>[CoW] security, authorisation and authentication</li>
<ul>
<li>should the user's edit profile form require a password entry?</li>
<li>when user details are edited via the edit profile form they do not change
@@ -368,8 +374,8 @@
directories). This could be changed to (a) allow a list of regular
expressions on each permission and (b) use the easier ant syntax, rather
than java regexp syntax.</li>
- </ul></li>
-<li>[GATE.ac.uk] "what we do page" <DD,VT> (or: MIMIR search):
+ </ul>
+<li>[GATE.ac.uk] "what we do page" <DD,VT> (or: MIMIR search):</li>
<ul>
<li>A JSP that displays Di/Wim's taxonomy and allows users to select one or
more concepts</li>
@@ -377,14 +383,14 @@
publications.dcs and the results are displayed (list of publications
relevant to the set of concepts)</li>
<li><a class="cow-url" href="http://www.google.com/coop/cse/overview">http://www.google.com/coop/cse/overview</a> for site search?</li>
- </ul></li>
+ </ul>
</ul>

<ul>
-<li>[YAM] Yammering <HC>
+<li>[YAM] Yammering <HC></li>
<ul>
<li>yam lists in table cells bug (or maybe just an irritant that needs
- documenting)
+ documenting)</li>
<ul>
<li>as for example in sam/doc/sheffield-visit-10-08/future.yam if the first
item in a table cell is a list, it has to be preceded by a linebreak,
@@ -394,31 +400,31 @@
to the list (though they go away if you fix the list)</li>
<li>it would seem possible to get pushBackListStart to put add a sep token
into the stream before the token being pushed back, or similar...?</li>
- </ul></li>
- <li>finish fixing latex generation
+ </ul>
+ <li>finish fixing latex generation</li>
<ul>
<li>uncomment tex extension in YamTranslatorTest.testHtmlToYamNoIncludes and
fix remaining errors</li>
- </ul></li>
+ </ul>
<li>%clone</li>
- <li>slidy (sale/talks/gslidy)
+ <li>slidy (sale/talks/gslidy)</li>
<ul>
<li>should be done like PDF and PDF dropped</li>
<li>yam layer</li>
<li>doc for team</li>
- </ul></li>
- <li>Version 5 bugs:
+ </ul>
+ <li>Version 5 bugs:</li>
<ul>
<li>the verbatim mode for HTML doesn't deal properly with angle brackets
(which need to be escaped). this is due to html <tt>pre</tt> not being like
latex <tt>verbatim</tt>. perhaps add another verbatim mode (%<< ?) or make
- chevrons TargetControls in the lexer?
+ chevrons TargetControls in the lexer?</li>
<ul>
<li>is this now fixed with the html escaping code?</li>
- </ul></li>
+ </ul>
<li>commas and citations within footnotes will prematurely end the footnote,
and any markup within footnotes will not be interpreted (see also next
- point), though \, is a valid workaround
+ point), though \, is a valid workaround</li>
<ul>
<li>one option is to have a member predParser and a JAVACODE production
that reads it in, counting brackets, then parses it and merges into
@@ -428,7 +434,7 @@
<li>also, converter xsl written on the assumption that there is no markup
in the footnote. may need to be rewritten if this changes (see
footnotes in html generation above)</li>
- </ul></li>
+ </ul>
<li>(related to previous) left round brackets in URLs cause truncation of
the url; we need to allow escaping or quoting (perhaps the same
mechanism for all predicates?)</li>
@@ -439,7 +445,7 @@
generated tag puts the attribute quotes in the wrong place</li>
<li>spaces at the end of table rows (after the final |) gets discarded</li>
<li>if %contents is used multiple times, only the last one works</li>
- <li>profiling: (yourkit profiler?)
+ <li>profiling: (yourkit profiler?)</li>
<ul>
<li>check if 1MB docs and above work (double yam-huge)</li>
<li>check if parse errors in documents above around 500k (e.g.
@@ -448,7 +454,7 @@
conversion of the site takes a few seconds. With context set, it takes
nearly 3 minutes. (not such a problem for conversion, but an issue
elsewhere?) </li>
- </ul></li>
+ </ul>
<li>because blockquotes (and things like bold, italic) are just treated as
words, they can cause overlap problems (see yam-wierd line 89 and after
for example); this would be hard to fix - the workaround is to e.g. make
@@ -464,15 +470,15 @@
title)</li>
<li>nested lists are incorrect XHTML (though they are acceptable to
browsers)</li>
- </ul></li>
- <li>Version 5 wishlist:
+ </ul>
+ <li>Version 5 wishlist:</li>
<ul>
<li>something like latex's ref command</li>
<li>definition lists</li>
<li>appendices</li>
<li>captions for figures and tables</li>
- </ul></li>
- </ul></li>
+ </ul>
+ </ul>
</ul>

<ul>
@@ -481,7 +487,7 @@
</ul>

<ul>
-<li>[CoW] security on searching
+<li>[CoW] security on searching</li>
<ul>
<li>At the moment, the search controller is a special case in the
SecurityFilters. If someone is trying to access it, then the
@@ -491,7 +497,7 @@
defined over sets of controllers, in the same way we do for actions:</li>
<li>CowPermission(Wiki 1, directory "", controller [page, search], actions
[Read])</li>
- </ul></li>
+ </ul>
</ul>

@@ -537,4 +543,4 @@
user and design documentation.


-</body></html>
+</body></html>
\ No newline at end of file

Modified: trunk/cow/doc/cow-backlog.yam
===================================================================
--- trunk/cow/doc/cow-backlog.yam 2009-10-27 20:41:20 UTC (rev 1765)
+++ trunk/cow/doc/cow-backlog.yam 2009-10-27 21:44:07 UTC (rev 1766)
@@ -67,6 +67,12 @@
- other bugs, see
http://sourceforge.net/tracker2/?func=browse&group_id=208243&atid=1004913
(move to a jira?)
+ - create a new wiki area with a non-existant directory as the target
+ sandbox; the exception that gets thrown by SandboxManager is reported
+ (though not nicely), but the wiki area still gets created. need to trap
+ the exception, report it (and log it) and then abort the area creation.
+ this probably also kills bootstrap when the SbManager call is being made
+ during startup

- search the code for TODOs
- browser compatibility testing [IR]

Modified: trunk/cow/src/java/gate/versioning/svnkit/SandboxManager.java
===================================================================
--- trunk/cow/src/java/gate/versioning/svnkit/SandboxManager.java 2009-10-27 20:41:20 UTC (rev 1765)
+++ trunk/cow/src/java/gate/versioning/svnkit/SandboxManager.java 2009-10-27 21:44:07 UTC (rev 1766)
@@ -82,7 +82,7 @@
throws GateException {
// is it valid?
if(!isSandboxDir(location))
- throw new GateException(location.getName()
+ throw new GateException(location.getPath()
+ " is not a valid SVN sandbox directory");
// do we know it already?
String id = getSandboxId(location);
@@ -112,8 +112,8 @@
throws GateException {
// is it valid?
if(!isSandboxDir(location))
- throw new GateException(location.getName()
- + " is not a valid SVN sandbox directory");
+ throw new GateException(location.getPath()
+ + " is not a valid SVN sandbox directory (2)");
// do we know it already?
String id = getSandboxId(location);
if(sandboxMap.get(id) != null) return false; // already managed

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
gatewiki-commits mailing list
gatewiki-commits@...
https://lists.sourceforge.net/lists/listinfo/gatewiki-commits