[gatewiki-commits] SF.net SVN: gatewiki:[1767] trunk

[ian_roberts]

Revision: 1767
          http://gatewiki.svn.sourceforge.net/gatewiki/?rev=1767&view=rev
Author:   ian_roberts
Date:     2009-10-28 13:54:55 +0000 (Wed, 28 Oct 2009)

Log Message:
-----------
Un-floated the main div (adding shims to prevent margins collapsing) and turned
the left bar into a float left rather than using absolute positioning.
Together these changes fix the problem with iframes not taking all the
available width and also push the footer bar to the bottom of the page when the
left menu is longer than the page content.

Modified Paths:
--------------
    trunk/cow/grails-app/views/layouts/cowpage.gsp
    trunk/cow/web-app/css/page.css
    trunk/site-plugins/annots/grails-app/views/layouts/cowguest.gsp
    trunk/site-plugins/gau/grails-app/views/layouts/cowguest.gsp

Modified: trunk/cow/grails-app/views/layouts/cowpage.gsp
===================================================================
--- trunk/cow/grails-app/views/layouts/cowpage.gsp 2009-10-27 21:44:07 UTC (rev 1766)
+++ trunk/cow/grails-app/views/layouts/cowpage.gsp 2009-10-28 13:54:55 UTC (rev 1767)
@@ -120,7 +120,9 @@
       <g:if test="${leftBar}"><div class="vertical menu">${leftBar}</div></g:if>
     </div>
     <div id="main" class="${ leftBar ? 'wideBorder' : 'noBorder' }">
+      <div class="cowSpacer"> </div>
       <g:layoutBody />
+      <div class="cowSpacer"> </div>
     </div>
     <div id="rightBar">${rightBar}</div>
     <div id="footer">${footer}</div>

Modified: trunk/cow/web-app/css/page.css
===================================================================
--- trunk/cow/web-app/css/page.css 2009-10-27 21:44:07 UTC (rev 1766)
+++ trunk/cow/web-app/css/page.css 2009-10-28 13:54:55 UTC (rev 1767)
@@ -56,7 +56,6 @@
   float: left;
 }
 #main {
-  float: left;
 }
 /* Trick to make the left menu background extend to the bottom of the page.
  * The width and colour of this border must match the width and
@@ -66,6 +65,12 @@
   border-left: 10em solid #578BB8;
   padding-left: 1em;
 }
+/* class for spacer divs at the top and bottom of #main to prevent collapsing
+ * margins.
+ */
+.cowSpacer {
+  font-size: 1px;
+}
 #rightBar {
   float: left;
 }
@@ -174,16 +179,14 @@
   background-color: #578BB8;
   margin: 0;
   padding: 0;
+  float: left;
 }
 
 .horizontal {
   width: 100%;
-  float: left;
 }
 
 .vertical ul {
-  /* Absolute positioning to overlay the border of the main div. */
-  position: absolute;
   width: 10em;
 }
 

Modified: trunk/site-plugins/annots/grails-app/views/layouts/cowguest.gsp
===================================================================
--- trunk/site-plugins/annots/grails-app/views/layouts/cowguest.gsp 2009-10-27 21:44:07 UTC (rev 1766)
+++ trunk/site-plugins/annots/grails-app/views/layouts/cowguest.gsp 2009-10-28 13:54:55 UTC (rev 1767)
@@ -221,7 +221,9 @@
  document.writeln(html);
 </script>
     <div id="main">
+      <div class="cowSpacer"> </div>
       <g:layoutBody />    
+      <div class="cowSpacer"> </div>
     </div>
 
 <script type="text/javascript">

Modified: trunk/site-plugins/gau/grails-app/views/layouts/cowguest.gsp
===================================================================
--- trunk/site-plugins/gau/grails-app/views/layouts/cowguest.gsp 2009-10-27 21:44:07 UTC (rev 1766)
+++ trunk/site-plugins/gau/grails-app/views/layouts/cowguest.gsp 2009-10-28 13:54:55 UTC (rev 1767)
@@ -145,7 +145,9 @@
       <g:if test="${leftBar}"><div class="vertical menu">${leftBar}</div></g:if>
     </div>
     <div id="main" class="${ leftBar ? 'wideBorder' : 'noBorder' }">
+      <div class="cowSpacer"> </div>
       <g:layoutBody />    
+      <div class="cowSpacer"> </div>
     </div>
     <div id="rightBar">${rightBar}</div>
     <div id="footer">


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
gatewiki-commits mailing list
gatewiki-commits@...
https://lists.sourceforge.net/lists/listinfo/gatewiki-commits