[issue89] easy_install silently drop symlinks when auto-extracting tarball source distributions

[Zooko O'Whielacronx-2]

New submission from Max Bowsher <maxb@...>:

Trying to determine why pytz installed by easy_install was broken, I located the
following problem:

When setuptools extracts a tarball source dist to install it, it silently drops
any tar members which are neither files or directories. The problem is in
archive_util.py which specifically tests "if member.isfile() or
member.isdir():". I am uncertain why it would try to do this, but it is fatally
incorrect to do so when the software being unpacked includes symlinks as a
functional part of its sourcecode, as pytz does.

----------
messages: 444
nosy: maxb
priority: bug
status: unread
title: easy_install silently drop symlinks when auto-extracting tarball source distributions

_______________________________________________
Setuptools tracker <setuptools@...>
<http://bugs.python.org/setuptools/issue89>
_______________________________________________
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Tarek Ziadé]

Hello Martin,

The Distutils-SIG mailing list is hosting several projects (4) which
all have their own trackers, and for some their own checking/bugs
mailing lists that receive these kind of automatic emails. This makes
it possible for the people that want to follow those warning e-mails
to register to those lists specifically. And for the others that are
registered here to get less emails.

Could you deactivate these automatic warning mails please?

Thanks

---------- Forwarded message ----------
From: Max Bowsher <setuptools@...>
Date: Sun, Nov 1, 2009 at 12:00 PM
Subject: [Distutils] [issue89] easy_install silently drop symlinks
when auto-extracting tarball source distributions
To: Distutils-SIG@...



New submission from Max Bowsher <maxb@...>:

Trying to determine why pytz installed by easy_install was broken, I located the
following problem:

When setuptools extracts a tarball source dist to install it, it silently drops
any tar members which are neither files or directories. The problem is in
archive_util.py which specifically tests "if member.isfile() or
member.isdir():". I am uncertain why it would try to do this, but it is fatally
incorrect to do so when the software being unpacked includes symlinks as a
functional part of its sourcecode, as pytz does.

----------
messages: 444
nosy: maxb
priority: bug
status: unread
title: easy_install silently drop symlinks when auto-extracting
tarball source distributions

_______________________________________________
Setuptools tracker <setuptools@...>
<http://bugs.python.org/setuptools/issue89>
_______________________________________________
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig



--
Tarek Ziadé | http://ziade.org | オープンソースはすごい! | 开源传万世，因有你参与
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

["Martin v. Löwis"]

> The Distutils-SIG mailing list is hosting several projects (4) which
> all have their own trackers, and for some their own checking/bugs
> mailing lists that receive these kind of automatic emails. This makes
> it possible for the people that want to follow those warning e-mails
> to register to those lists specifically. And for the others that are
> registered here to get less emails.
>
> Could you deactivate these automatic warning mails please?

Hi Tarek,

I have no real clue what you are talking about. The message you've
copied is a roundup message from the setuptools tracker, not a warning
message of some kind. What specific warning messages are you referring
to, who is sending them, and why do you think it is within my power
to make them stop?

Regards,
Martin
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Tarek Ziadé]

2009/11/1 "Martin v. Löwis" <martin@...>:

>> The Distutils-SIG mailing list is hosting several projects (4) which
>> all have their own trackers, and for some their own checking/bugs
>> mailing lists that receive these kind of automatic emails. This makes
>> it possible for the people that want to follow those warning e-mails
>> to register to those lists specifically. And for the others that are
>> registered here to get less emails.
>>
>> Could you deactivate these automatic warning mails please?
>
> Hi Tarek,
>
> I have no real clue what you are talking about. The message you've
> copied is a roundup message from the setuptools tracker, not a warning
> message of some kind.

Yes, that's a warning from the setuptools tracker. I call that a
"warning" because
it warns you that someone added an issue in the tracker.

> What specific warning messages are you referring
> to, who is sending them, and why do you think it is within my power
> to make them stop?

Because you are the one who set it up some time ago as far as this message says:

http://markmail.org/message/kk5jnugeqnr53iuy

Regards
Tarek
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

["Martin v. Löwis"]

>> I have no real clue what you are talking about. The message you've
>> copied is a roundup message from the setuptools tracker, not a warning
>> message of some kind.
>
> Yes, that's a warning from the setuptools tracker. I call that a
> "warning" because
> it warns you that someone added an issue in the tracker.

Ah, ok. That meaning of "warning" was unknown to me, sorry.

So you want the roundup tracker to send its notifications elsewhere.
Where exactly?

>> What specific warning messages are you referring
>> to, who is sending them, and why do you think it is within my power
>> to make them stop?
>
> Because you are the one who set it up some time ago as far as this message says:
>
> http://markmail.org/message/kk5jnugeqnr53iuy

It's actually Jeff Rush who is in charge of this tracker instance.
I can't change the setup without him agreeing.

So, Jeff, where else should the roundup instance for setuptools send
its notifications?

Regards,
Martin
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Tarek Ziadé]

2009/11/2 "Martin v. Löwis" <martin@...>:
[...]
>
> Ah, ok. That meaning of "warning" was unknown to me, sorry.

That's my translation, so it might be wrong :)

[..]
>
> It's actually Jeff Rush who is in charge of this tracker instance.
> I can't change the setup without him agreeing.
>
> So, Jeff, where else should the roundup instance for setuptools send
> its notifications?

I can create a dedicated google group if it can help, that's what we
did in another project.

Regards
Tarek
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[P.J. Eby]

At 12:01 AM 11/2/2009 +0100, Martin v. Löwis wrote:
>It's actually Jeff Rush who is in charge of this tracker instance.
>I can't change the setup without him agreeing.
>
>So, Jeff, where else should the roundup instance for setuptools send
>its notifications?

In over 1 year, there are now a grand total of 89 such messages (at
most) that have been sent to the list, vs. 5 messages just sent now
(6 when you count this one) discussing whether or not they should
continue to be sent here.

So far, there has also only been one complaint or request to change
this, as far as I'm aware.  (Personally, I like them just fine where
they are.  Among other things it makes it easy for someone to answer
the ticket via email, which is one of the reasons I asked for it to
be set up this way in the first place.)

_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Ben Finney-10]

Tarek Ziadé <ziade.tarek@...> writes:

> 2009/11/2 "Martin v. Löwis" <martin@...>:
> [...]
> >
> > Ah, ok. That meaning of "warning" was unknown to me, sorry.
>
> That's my translation, so it might be wrong :)

“Warning” implies the system is complaining something is wrong. The
arrival of a new issue in the tracker doesn't qualify, I think. Better
would be “notification”.

--
 \          “Generally speaking, the errors in religion are dangerous; |
  `\    those in philosophy only ridiculous.” —David Hume, _A Treatise |
_o__)                                           of Human Nature_, 1739 |
Ben Finney

_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Jeff Rush]

P.J. Eby wrote:

> At 12:01 AM 11/2/2009 +0100, Martin v. Löwis wrote:
>> It's actually Jeff Rush who is in charge of this tracker instance.
>> I can't change the setup without him agreeing.
>>
>> So, Jeff, where else should the roundup instance for setuptools send
>> its notifications?
>
> In over 1 year, there are now a grand total of 89 such messages (at
> most) that have been sent to the list, vs. 5 messages just sent now (6
> when you count this one) discussing whether or not they should continue
> to be sent here.
>
> So far, there has also only been one complaint or request to change
> this, as far as I'm aware.  (Personally, I like them just fine where
> they are.  Among other things it makes it easy for someone to answer the
> ticket via email, which is one of the reasons I asked for it to be set
> up this way in the first place.)

I'm happy with the existing arrangement - I think sending low-traffic
bug reports to a separate list is a bad idea because few folk will
actually see them.  If the traffic level increases, then we can consider
moving notifications to a separate list hosted at python.org.  With our
own listserver I see no reason to use Google Groups though as there are
people who refuse to get an account there.

-Jeff

_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Chris Withers]

Jeff Rush wrote:
> I'm happy with the existing arrangement - I think sending low-traffic
> bug reports to a separate list is a bad idea because few folk will
> actually see them.

Agreed.

Any chance the mail subject could be prefixed with [setuptools] to make
it clear which tracker it came from?

cheers,

Chris

--
Simplistix - Content Management, Batch Processing & Python Consulting
            - http://www.simplistix.co.uk
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

["Martin v. Löwis"]

> Any chance the mail subject could be prefixed with [setuptools] to make
> it clear which tracker it came from?

If you want to filter them out (or in a separate folder), I recommend to
set your filter for the X-Roundup-Name header.

Adding something to the subject is tricky, IIRC.

Regards,
Martin
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Tarek Ziadé]

>> In over 1 year, there are now a grand total of 89 such messages (at
>> most) that have been sent to the list, vs. 5 messages just sent now (6
>> when you count this one) discussing whether or not they should continue
>> to be sent here.

Yes, exactly. Because those are notifications, and have nothing to do on
a human mailing list.

[...]
>>
>> So far, there has also only been one complaint or request to change
>> this, as far as I'm aware.
> (Personally, I like them just fine where
>> they are.  Among other things it makes it easy for someone to answer the
>> ticket via email, which is one of the reasons I asked for it to be set
>> up this way in the first place.)

I don't remember you asking in Distutils-SIG to the people if they
were OK with that.

Anyways, that's not the way an issue tracker works. If you want to
answer to issues, you do it in the
tracker itself. That's what you have been doing most of the time IIRC.

You can't follow a discussion on an issue otherwise.

For example, in the Python issue tracker, there's a dedicated ist for
that , but it's just notifications,
and you answer afterwards in the tracker to keep track of it.

>
> I'm happy with the existing arrangement - I think sending low-traffic
> bug reports to a separate list is a bad idea because few folk will
> actually see them.  If the traffic level increases, then we can consider
> moving notifications to a separate list hosted at python.org.  With our
> own listserver I see no reason to use Google Groups though as there are
> people who refuse to get an account there.

Google group was just a suggestion, a python.org list is fine of course.

But I am wondering : who are those "folk" ? Receiving those
notifications is good when you are the *maintainer*
of the project. Setuptools has one maintainer (Philip), So why not sending these
notifications to his personal email ? I don't think there a lot of
folks that are interested in folllowing
those notifications in here in the first place. And other folks can
registered to this dedicated list.

I don't see any good reason why Setuptools would push notifications
like that in the Distutils-SIG.
(zc.buildout or Distribute don't do that) . Plus, with headers like
"[issue #123] bug"  it looks that this is the Distutils project (we
are on the *Distutils*-SIG).

If the subject can be changed with the word "setuptools" in it, I'll
accomodate with it.

Tarek
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

["Martin v. Löwis"]

> Anyways, that's not the way an issue tracker works. If you want to
> answer to issues, you do it in the
> tracker itself. That's what you have been doing most of the time IIRC.

You may be missing one of the primary strengths of roundup: the ability
to carry out bug discussions (nearly) entirely by email.

> You can't follow a discussion on an issue otherwise.

Sure you can. As soon as you respond by email, you get added to the
nosy list of the issue, which means you'll also get all follow-ups.

> For example, in the Python issue tracker, there's a dedicated ist for
> that , but it's just notifications,
> and you answer afterwards in the tracker to keep track of it.

No no no. Some people use the web interface, some use the email
interface. I'd have to perform exact counting to find out which
one is the majority, however, both are used significantly (my guess
is that committers prefer email; bug submitters use the web interface
because they don't expect email responses to work).

> If the subject can be changed with the word "setuptools" in it, I'll
> accomodate with it.

Did you ask for that specifically because I said it would be difficult
to provide?

Regards,
Martin
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Paul Moore-2]

Sorry, that was meant to go to the list, not as a personal comment to Tarek.

2009/11/2 Paul Moore <p.f.moore@...>:

> 2009/11/2 Tarek Ziadé <ziade.tarek@...>:
> (original quote here from PJE)
>>>> (Personally, I like them just fine where
>>>> they are.  Among other things it makes it easy for someone to answer the
>>>> ticket via email, which is one of the reasons I asked for it to be set
>>>> up this way in the first place.)
>>
>> I don't remember you asking in Distutils-SIG to the people if they
>> were OK with that.
>
> Can we please avoid this flaring up into another Tarek vs PJE fight?
>
> FWIW, I'm mildly annoyed by setuptools tracker emails appearing here,
> but I live with it. I suggest others do the same.
>
> Paul.
>

_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Tarek Ziadé]

2009/11/2 "Martin v. Löwis" <martin@...>:

>> Anyways, that's not the way an issue tracker works. If you want to
>> answer to issues, you do it in the
>> tracker itself. That's what you have been doing most of the time IIRC.
>
> You may be missing one of the primary strengths of roundup: the ability
> to carry out bug discussions (nearly) entirely by email.
>
>> You can't follow a discussion on an issue otherwise.
>
> Sure you can. As soon as you respond by email, you get added to the
> nosy list of the issue, which means you'll also get all follow-ups.
>
>> For example, in the Python issue tracker, there's a dedicated ist for
>> that , but it's just notifications,
>> and you answer afterwards in the tracker to keep track of it.
>
> No no no. Some people use the web interface, some use the email
> interface. I'd have to perform exact counting to find out which
> one is the majority, however, both are used significantly (my guess
> is that committers prefer email; bug submitters use the web interface
> because they don't expect email responses to work).
>

This feature is great, I didn't know about it, but you don't put these
emails in a -SIG list as
far as I know, do you ? You don't push email at python-dev either.

But what is the rationale to have a python.org hosted tracker with
emails sent in this list here ?

Does it means any third party project can get such a tracker at
Python.org and push its mails in a -SIG list ?


>> If the subject can be changed with the word "setuptools" in it, I'll
>> accomodate with it.
>
> Did you ask for that specifically because I said it would be difficult
> to provide?

Uh ? not at all.

Look in your emails, and look in the first private mail I have sent you
a few days ago, when the last issue came up (you didn't answer then).
I said in that mail that is was hard to follow and make a distinction
between the different projects because it only has a [distutils]
headers.

And I have I said it again here.
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Tarek Ziadé]

2009/11/2 Paul Moore <p.f.moore@...>:
> Sorry, that was meant to go to the list, not as a personal comment to Tarek.

No problem.

>> Can we please avoid this flaring up into another Tarek vs PJE fight?
>>
>> FWIW, I'm mildly annoyed by setuptools tracker emails appearing here,
>> but I live with it. I suggest others do the same.

I don't want to get into a fight (but I am getting used at receiving
personal attacks and try not flame things) ,
but these notifications, among other things, makes it unclear that the
Setuptools project is a distinct project from Distutils.

For example, I am sometimes receiving mails from people complaining
that easy_install doesn't work right
and that Distutils should be fixed.

It's great that Distutils-SIG host several projects, especially since
many people want to have a unified
project for the packaging topic.

But these notifications have to be straightened up, and I don't see
any rationale yet why they should stay in this list.

Tarek
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Floris Bruynooghe-2]

On Mon, Nov 02, 2009 at 10:50:55AM +0000, Paul Moore wrote:

> Sorry, that was meant to go to the list, not as a personal comment to Tarek.
>
> 2009/11/2 Paul Moore <p.f.moore@...>:
> > 2009/11/2 Tarek Ziadé <ziade.tarek@...>:
> > (original quote here from PJE)
> >>>> (Personally, I like them just fine where
> >>>> they are.  Among other things it makes it easy for someone to answer the
> >>>> ticket via email, which is one of the reasons I asked for it to be set
> >>>> up this way in the first place.)
> >>
> >> I don't remember you asking in Distutils-SIG to the people if they
> >> were OK with that.
> >
> > Can we please avoid this flaring up into another Tarek vs PJE fight?
> >
> > FWIW, I'm mildly annoyed by setuptools tracker emails appearing here,
> > but I live with it. I suggest others do the same.

FWIW I'd be +1 on moving the setuptool tracker emails elsewhere.  I
just always assumed there was some secret cabal agreement on them
being here, but apparently not.  ;-)

OTOH I'm pretty used to ignoring threads that don't interest me.  :-)


Regards
Floris
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[ssteiner]

On Nov 2, 2009, at 5:40 AM, Martin v. Löwis wrote:
>> If the subject can be changed with the word "setuptools" in it, I'll
>> accomodate with it.
>
> Did you ask for that specifically because I said it would be difficult
> to provide?

Uh, personal animosities aside, Tarek didn't ask for that, Chris did.

S

_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig

[Chris Withers]

Martin v. Löwis wrote:
>> Any chance the mail subject could be prefixed with [setuptools] to make
>> it clear which tracker it came from?
>
> If you want to filter them out (or in a separate folder), I recommend to
> set your filter for the X-Roundup-Name header.

I don't, I just want to know that a message is for setuptools rather
than distribute.

> Adding something to the subject is tricky, IIRC.

I find that hard to believe...

Chris

--
Simplistix - Content Management, Batch Processing & Python Consulting
            - http://www.simplistix.co.uk
_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@...
http://mail.python.org/mailman/listinfo/distutils-sig