[
http://jira.codehaus.org/browse/JANINO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_96320 ]
Arno Unkrig commented on JANINO-88:
-----------------------------------
I'm not happy with that change. The important lines of code are:
{code:title=JavaSourceClassLoader.java line 404}
/**
* Collection of parsed, but uncompiled compilation units.
*/
private final Set unitCompilers = new HashSet(); // UnitCompiler
{code}
If I apply your change, then JSCL will no longer keep parsed but uncompiled CUs. That's probably a HUGE performance hit!
Anyway, why do you consider the singleton JSICL a memory leak? It is only references by the JSCL, and hence freed if the JSCL is GCed.
> JavaSourceClassLoader has a memory leak for JavaSourceIClassLoader.
> -------------------------------------------------------------------
>
> Key: JANINO-88
> URL:
http://jira.codehaus.org/browse/JANINO-88> Project: Janino
> Issue Type: Bug
> Reporter: Adam Heath
> Assignee: Arno Unkrig
> Attachments: fix_JavaSourceClassLoader-memleak.patch
>
>
> JavaSourceClassLoader creates a singleton JavaSourceIClassLoader in it's constructor. This is actually a cause for a memory leak in long-running server processes. The simplest fix is to create a new JavaSourceIClassLoader each time in generateByteCodes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
