[
http://jira.codehaus.org/browse/JANINO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_99242 ]
Arno Unkrig commented on JANINO-93:
-----------------------------------
{quote}
I assume you mean patch, not list.
{quote}
Nope, I mean "intrusive list": A list that is implemented by adding a "nextToken" field to the element, instead of keep the references to the elements in element-external data structures, as java.util.List does.
{quote}
Why are intrusive patches not nice? If a particular feature requires lots of changes, and the changes themselves are only constrained with adding that feature, calling it intrusive just because of it's size is a poor evaluation. Instead, just comment on the issues you see with the implementation, and that problems that might occur.
{quote}
See above. I don't quite understand what an "intrusive patch" is supposed to be (isn't every path intrusive by definition?), but anyway.
{quote}
You missed a critical component of the patch; setSwallowIgnorable. Please see the following example code:
{quote}
I'm confused. The patch DOES NOT contain anything like "setSwallowableIgnorable()". Can you please explain?
CU
Arno
> Add Token.getNextToken for walking the parsed file
> --------------------------------------------------
>
> Key: JANINO-93
> URL:
http://jira.codehaus.org/browse/JANINO-93> Project: Janino
> Issue Type: New Feature
> Reporter: Adam Heath
> Assignee: Arno Unkrig
> Attachments: feature_add_nextToken_to_Token.patch
>
>
> Add a method to Token, getNextToken, that maintains the link of tokens that are parsed from a stream.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
