[janino-dev] [jira] Created: (JANINO-127) LocalVariableTable code attribute not created, giving debuggers problems with classfiles

LocalVariableTable code attribute not created, giving debuggers problems with classfiles
----------------------------------------------------------------------------------------

                 Key: JANINO-127
                 URL: http://jira.codehaus.org/browse/JANINO-127
             Project: Janino
          Issue Type: New Feature
            Reporter: Hayden Schultz
            Assignee: Arno Unkrig
            Priority: Critical
         Attachments: localvardiff.txt.gz

Since the LocalVariableTable attribute isn't written to class files, we've been having problems debugging code generated by Janino.

I've attached a diff for the code to write LocalVariableTable code attributes. The changes are fairly minor.

  Thanks,
     Hayden Schultz (I work at StreamBase, the same company as Matt Fowles)



--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145928#action_145928 ]

Arno Unkrig commented on JANINO-127:
------------------------------------

The implementataion is quite small... congrats. But probably not completely correct: The locvars should only appear in the debugger when the locvar is assigned a value! In other words: The local variable should not appear when it is _allocated_, but when when it is first assigned a _value_! That's why I once gave up on implementing the LocalVariableTable.

But if your implementation works, then why not take the easy way?

I will look into it. Stay tuned.

> LocalVariableTable code attribute not created, giving debuggers problems with classfiles
> ----------------------------------------------------------------------------------------
>
>                 Key: JANINO-127
>                 URL: http://jira.codehaus.org/browse/JANINO-127
>             Project: Janino
>          Issue Type: New Feature
>            Reporter: Hayden Schultz
>            Assignee: Arno Unkrig
>            Priority: Critical
>         Attachments: localvardiff.txt.gz
>
>
> Since the LocalVariableTable attribute isn't written to class files, we've been having problems debugging code generated by Janino.
> I've attached a diff for the code to write LocalVariableTable code attributes. The changes are fairly minor.
>   Thanks,
>      Hayden Schultz (I work at StreamBase, the same company as Matt Fowles)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150815#action_150815 ]

Matt Fowles commented on JANINO-127:
------------------------------------

Arno~

There is no harm in display the local variable slightly longer than it is assigned, as long as it still have a unique position in the local variable array.  Prior to initialization the variable will show up in debuggers as having a value of 0 (or false or 0.0 or null...).

If I could nudge you to commit this patch it would be appreciated.  We (StreamBase) prefer to not maintain local differences from Janino trunk and I can assure you that the patch passes our roughly 9000 nightly tests.

Matt

> LocalVariableTable code attribute not created, giving debuggers problems with classfiles
> ----------------------------------------------------------------------------------------
>
>                 Key: JANINO-127
>                 URL: http://jira.codehaus.org/browse/JANINO-127
>             Project: Janino
>          Issue Type: New Feature
>            Reporter: Hayden Schultz
>            Assignee: Arno Unkrig
>            Priority: Critical
>         Attachments: localvardiff.txt.gz
>
>
> Since the LocalVariableTable attribute isn't written to class files, we've been having problems debugging code generated by Janino.
> I've attached a diff for the code to write LocalVariableTable code attributes. The changes are fairly minor.
>   Thanks,
>      Hayden Schultz (I work at StreamBase, the same company as Matt Fowles)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179473#action_179473 ]

Matt Fowles commented on JANINO-127:
------------------------------------

You can find a fixed version of this at http://code.google.com/p/janino-streambase/

> LocalVariableTable code attribute not created, giving debuggers problems with classfiles
> ----------------------------------------------------------------------------------------
>
>                 Key: JANINO-127
>                 URL: http://jira.codehaus.org/browse/JANINO-127
>             Project: Janino
>          Issue Type: New Feature
>            Reporter: Hayden Schultz
>            Assignee: Arno Unkrig
>            Priority: Critical
>         Attachments: localvardiff.txt.gz
>
>
> Since the LocalVariableTable attribute isn't written to class files, we've been having problems debugging code generated by Janino.
> I've attached a diff for the code to write LocalVariableTable code attributes. The changes are fairly minor.
>   Thanks,
>      Hayden Schultz (I work at StreamBase, the same company as Matt Fowles)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email