[janino-dev] [jira] Created: (JANINO-129) incorrect max stack size

incorrect max stack size
------------------------

                 Key: JANINO-129
                 URL: http://jira.codehaus.org/browse/JANINO-129
             Project: Janino
          Issue Type: Bug
            Reporter: Matt Fowles
            Assignee: Arno Unkrig
         Attachments: max-stack.diff

The constant Byte.MAX_VALUE is incorrect for max stack size which is actually 255.  

This patch introduces a constant CodeContext.MAX_STACK_SIZE for this.  Do to an off by one somewhere (couldn't track it down), this constant could only be set to 254.  Sadly, the test was difficult to extract from our nightly infrastructure, so you will have to take my word that we test it (heavily) here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/JANINO-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179474#action_179474 ]

Matt Fowles commented on JANINO-129:
------------------------------------

You can find a fixed version of this at http://code.google.com/p/janino-streambase/

> incorrect max stack size
> ------------------------
>
>                 Key: JANINO-129
>                 URL: http://jira.codehaus.org/browse/JANINO-129
>             Project: Janino
>          Issue Type: Bug
>            Reporter: Matt Fowles
>            Assignee: Arno Unkrig
>         Attachments: max-stack.diff
>
>
> The constant Byte.MAX_VALUE is incorrect for max stack size which is actually 255.  
> This patch introduces a constant CodeContext.MAX_STACK_SIZE for this.  Do to an off by one somewhere (couldn't track it down), this constant could only be set to 254.  Sadly, the test was difficult to extract from our nightly infrastructure, so you will have to take my word that we test it (heavily) here.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email