« Return to Thread: [jira] [Created] (MYFACES-3549) Alternative solution to bugs MYFACES-3262 and MYFACES-3510

[jira] [Commented] (MYFACES-3549) Alternative solution to bugs MYFACES-3262 and MYFACES-3510

by My Faces - Dev mailing list :: Rate this Message:

| View in Thread


    [ https://issues.apache.org/jira/browse/MYFACES-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281025#comment-13281025 ]

Jesús Pérez Alcaide (ISBAN) commented on MYFACES-3549:
------------------------------------------------------

Thank you Leonardo for your valuable comments.

I spent the whole morning looking for information about the final and volatile keywords. I think making _readMethodRef volatile could reduce the number of calls to _descriptor.getReadMethod() when the soft reference is cleared, but this only occurred when the server is about to run out of memory.

In this scenario it is uncertain whether the server is able to recover enough memory to continue execution, so I don't know whether it is worthwhile to optimize the code for that delicate situation. I think it is reasonable to optimize the typical case, and that's what I intend with my proposal.

               

> Alternative solution to bugs MYFACES-3262 and MYFACES-3510
> ----------------------------------------------------------
>
>                 Key: MYFACES-3549
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3549
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.7
>            Reporter: Jesús Pérez Alcaide (ISBAN)
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.14, 2.1.8
>
>         Attachments: AAA_patch_PropertyDescriptor_MyFaces217.jar, MYFACES-3549-fix-hard-reference-map.patch, MyFaces3262_PropertyDescriptorHolder.patch, MyFaces3510_AbstractFacesInitializer.patch, MyFaces3510_ComponentAttributesMap.patch
>
>
> I would like to propose an alternative solution to bugs MYFACES-3262 and MYFACES-3510, which consists in rollback the changes made in MYFACES-3510 and modify the solution given in MYFACES-3262 by adding a soft reference to the methods held in the class _PropertyDescriptorHolder.
> This alternative solution fixes MYFACES-3262 and avoids the performance loss caused by MYFACES-3510.
> More information in this email:
> http://markmail.org/message/xh66wlte6luqn63d

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


 « Return to Thread: [jira] [Created] (MYFACES-3549) Alternative solution to bugs MYFACES-3262 and MYFACES-3510