« Return to Thread: [jira] [Created] (HTTPCORE-298) SSLIOSession state can get out of sync with underlying IOSession state

[jira] [Created] (HTTPCORE-298) SSLIOSession state can get out of sync with underlying IOSession state

by JIRA jira@apache.org :: Rate this Message:

| View in Thread

Sandeep Tamhankar created HTTPCORE-298:
------------------------------------------

             Summary: SSLIOSession state can get out of sync with underlying IOSession state
                 Key: HTTPCORE-298
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-298
             Project: HttpComponents HttpCore
          Issue Type: Bug
          Components: HttpCore NIO
    Affects Versions: 4.1.4
         Environment: observed on Ubuntu 10.0.4, but I think it could happen anywhere
            Reporter: Sandeep Tamhankar


Under heavy load, I've observed my application call SSLIOSession.isClosed() to decide if the connection can be reused for a pending outbound request. It returns false. However, the underlying IOSessionImpl is actually closed. I believe that AbstractIOReactor also holds a reference to that underlying IOSession and it can be independently closed from that end.

My proposed fix is simple (and very non-invasive, but possibly not correct in that I don't have the SSLIOSession update its state upon discovering that the underlying IOSession is closed): update SSLIOSession.isClosed as followed:
    public boolean isClosed() {
        return this.status >= CLOSING || this.session.isClosed();
    }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

 « Return to Thread: [jira] [Created] (HTTPCORE-298) SSLIOSession state can get out of sync with underlying IOSession state