« Return to Thread: [jira] Created: (HADOOP-2284) BasicTypeSorterBase.compare calls progress on each compare

[jira] Commented: (HADOOP-2284) BasicTypeSorterBase.compare calls progress on each compare

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/HADOOP-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554528 ]

Owen O'Malley commented on HADOOP-2284:
---------------------------------------

I agree with Devaraj. The cost of gettimeofday is huge when put into the inner loop like that. I think we'll be fine with every 10,000th compare calling progress. To timeout we'd need to do less than 20 compares/second...

> BasicTypeSorterBase.compare calls progress on each compare
> ----------------------------------------------------------
>
>                 Key: HADOOP-2284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2284
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Owen O'Malley
>            Assignee: Devaraj Das
>             Fix For: 0.16.0
>
>
> The inner loop of the sort is calling progress on each compare. I think it would make more sense to call progress in the sort rather than the compare or at most every 10000 compares. In the performance numbers, the call to progress as part of the sort are consuming 12% of the total cpu time when running word count under the local runner.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (HADOOP-2284) BasicTypeSorterBase.compare calls progress on each compare