« Return to Thread: [jira] Created: (HADOOP-938) too many SequenceFile.createWriter() methods

[jira] Commented: (HADOOP-938) too many SequenceFile.createWriter() methods

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/HADOOP-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467748 ]

Andrzej Bialecki  commented on HADOOP-938:
------------------------------------------

IMHO it's better to use a specialized parameter class instead of opaque Configuration - it's much more light weight, and we can make it type-safe.

> too many SequenceFile.createWriter() methods
> --------------------------------------------
>
>                 Key: HADOOP-938
>                 URL: https://issues.apache.org/jira/browse/HADOOP-938
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>
> There are too many SequenceFile.createWriter() method signatures.  This method has two required paramters: a Configuration and a Path.  It has one obsolete parameter: a FileSystem.  And it has five optional parameters: CompressionType, CompressionCodec, Progress, replication, and metadata.
> We should remove the obsolete parameter and make all optional parameters into setters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

 « Return to Thread: [jira] Created: (HADOOP-938) too many SequenceFile.createWriter() methods