[
http://jira.codehaus.org/browse/JMOCK-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171138#action_171138 ]
Nat Pryce commented on JMOCK-201:
---------------------------------
That patch just makes all members protected. Making a class extensible needs a bit more design than that if it is going to be easy to maintain in the long run and ensure backward compatibility as we maintain it.
What exactly do you need to change in the ClassImposteriser? Can that be done by passing policies to the ClassImposteriser instead of by inheritance?
> Allow ClassImposteriser to be extended
> --------------------------------------
>
> Key: JMOCK-201
> URL:
http://jira.codehaus.org/browse/JMOCK-201> Project: jMock
> Issue Type: Improvement
> Components: Library
> Affects Versions: 2.5.1
> Reporter: Corporate Gadfly
> Attachments: JMOCK-201.patch
>
>
> I had a need to imposterise concrete classes (from 3rd-party jars) with final toString() method.
> For background, please see discussion at:
>
http://www.nabble.com/Re%3A-mocking-concrete-classes-with-final-toString-method-p18509146.html> In that thread, Nat had advised one of the options as being "write your own Imposteriser".
> So, for my needs I ended up writing ClassImposteriserAllowingFinalToString. It would be great if ClassImposteriser could be made easier to extend. As it is, it has a lot of private methods and properties and I pretty much had to rewrite my own imposteriser from scratch (essentially duplicating the private pieces of ClassImposteriser). If ClassImposteriser was extension friendly, I would probably need to do minimal work by writing my own imposterise() and canImposterise() methods. This way I would also be safeguarded against future bug-fixes that may happen in ClassImposteriser.
> Cheers and thanks in advance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
