[jira] Commented: (JMOCK-201) Allow ClassImposteriser to be extended

    [ http://jira.codehaus.org/browse/JMOCK-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=171198#action_171198 ]

Corporate Gadfly commented on JMOCK-201:
----------------------------------------

Hi Nat,

I needed to override the methods canImposterise() and imposterise().

Here is my canImposterise() method:
{code:title=Mine}
public boolean canImposterise(Class<?> type) {
    return !type.isPrimitive() &&
           !Modifier.isFinal(type.getModifiers()) &&
           type.isInterface();
}
{code}
as compared to the original:
{code:title=Original}
public boolean canImposterise(Class<?> type) {
    return !type.isPrimitive() &&
           !Modifier.isFinal(type.getModifiers()) &&
           (type.isInterface() || !toStringMethodIsFinal(type));
}
{code}
Notice the extra call to toStringMethodIsFinal. So overriding this one is easy.

When I tried to override the imposterise() method, it had calls to private methods. Here's mine:
{code:title=Mine}
public <T> T imposterise(final Invokable mockObject, Class<T> mockedType, Class<?>... ancilliaryTypes) {
    try {
        setConstructorsAccessible(mockedType, true);
        Class<?> proxyClass = createProxyClass(mockedType, ancilliaryTypes);
        return mockedType.cast(createProxy(proxyClass, mockObject));
    }
    finally {
        setConstructorsAccessible(mockedType, false);
    }
}
{code}
compared to original:
{code:title=Original}
public <T> T imposterise(final Invokable mockObject, Class<T> mockedType, Class<?>... ancilliaryTypes) {
    if (!mockedType.isInterface() && toStringMethodIsFinal(mockedType)) {
        throw new IllegalArgumentException(mockedType.getName() + " has a final toString method");
    }

    try {
        setConstructorsAccessible(mockedType, true);
        Class<?> proxyClass = createProxyClass(mockedType, ancilliaryTypes);
        return mockedType.cast(createProxy(proxyClass, mockObject));
    }
        finally {
                setConstructorsAccessible(mockedType, false);
        }
}
{code}
Overriding this one was a little bit more difficult as it has calls to 3 private methods (createProxyClass, createProxy, setConstructorsAccessible).

Hope the situation is a little bit clearer.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email