[
https://issues.apache.org/jira/browse/LANG-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632950#action_12632950 ]
Sebb commented on LANG-458:
---------------------------
All the methods currently throw Exceptions. I think it would be very confusing for some methods to return boolean instead.
I agree with Stephen that it is out of scope for the Validate class.
As mentioned earlier, LANG already has boolean validation checks in StringUtils, and Commons Collections has CollectionUtils which together offer even more methods.
The proposed method hasNullElement() would be a useful addition to LANG ArrayUtils (which Validate could then use as it is in the same jar) and to Commons Collections CollectionUtils. Best to raise separate JIRAs for those.
> Add methods to return boolean from Validate.java instead of throwing IllegalArgumentException
> ---------------------------------------------------------------------------------------------
>
> Key: LANG-458
> URL:
https://issues.apache.org/jira/browse/LANG-458> Project: Commons Lang
> Issue Type: Improvement
> Environment: software
> Reporter: Viraj Turakhia
> Priority: Minor
> Attachments: code_diff.txt, test_diff.txt
>
>
> I am using Validate.java since long and find it difficult to use when I just want to validate collections or string.
> With current interface, I go like this:
> while(cnt < list.size()) {
> List list1 = list.get(cnt);
> try {
> Validate.notEmpty(list1);
> } catch(IllegalArgumentException e) {
> continue;
> }
> }
> much better approach is:
> while(cnt < list.size()) {
> List list1 = list.get(cnt);
> try {
> if(! Validate.notEmpty(list1)) {
> continue;
> }
> }
> If you all agree with this change, I am willing to submit a patch for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
