« Return to Thread: [jira] Created: (VELTOOLS-115) Improve exception and HTTP error management

[jira] Commented: (VELTOOLS-115) Improve exception and HTTP error management

by Velocity - Dev mailing list-2 :: Rate this Message:

Reply to Author | View in Thread


    [ https://issues.apache.org/jira/browse/VELTOOLS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677908#action_12677908 ]

Byron Foster commented on VELTOOLS-115:
---------------------------------------

Looking at this some more.  I don't like what I originally said about buffering.  The response buffer size can be set manually to control how much data is written before the servlet container commits.  The point being is why perform any local buffering at all? Is the VelocityWriter even necessary in a servlet container?  A servlet container like Tomcat should provide any buffer functionality necessary, and probably does it better (memory management, etc...), sorry this is a little off topic, but related :)

> Improve exception and HTTP error management
> -------------------------------------------
>
>                 Key: VELTOOLS-115
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-115
>             Project: Velocity Tools
>          Issue Type: Improvement
>          Components: VelocityView
>    Affects Versions: 2.0
>         Environment: Servlet container
>            Reporter: Antonio Petrelli
>
> Currently the exception management and missing resources are not satisfactory.
> In particular:
> 1. if an exception happen during rendering a template, an exception stack trace is put inside the result, with an HTTP 200 code;
> 2. if a resource is missing, but it is intercepted by the VelocityViewServlet, it renders with a page with HTTP 200.
> It should be:
> 1. HTTP 500 with error page. If it is not possible (if the response is committed), the error page should be included.
> 2. HTTP 404 with error page.
> In both cases the configuration of the webapp should be considered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

 « Return to Thread: [jira] Created: (VELTOOLS-115) Improve exception and HTTP error management