[jira] Created: (AMQ-2343) Decouple sendFailIfNoSpace from producer flow control

Decouple sendFailIfNoSpace from producer flow control
-----------------------------------------------------

                 Key: AMQ-2343
                 URL: https://issues.apache.org/activemq/browse/AMQ-2343
             Project: ActiveMQ
          Issue Type: Improvement
          Components: Broker
    Affects Versions: 5.2.0
            Reporter: Dejan Bosanac
            Assignee: Dejan Bosanac
             Fix For: 5.3.0


We have to notify the producer when broker run into disk storage limit even when the producer flow control is turned off.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/AMQ-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dejan Bosanac resolved AMQ-2343.
--------------------------------

    Resolution: Fixed

Fixed in svn revision 800738

> Decouple sendFailIfNoSpace from producer flow control
> -----------------------------------------------------
>
>                 Key: AMQ-2343
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2343
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.2.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.3.0
>
>
> We have to notify the producer when broker run into disk storage limit even when the producer flow control is turned off.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/AMQ-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55076#action_55076 ]

Gary Tully edited comment on AMQ-2343 at 10/29/09 8:44 AM:
-----------------------------------------------------------

dejan, was there any reason this was *not* completed for non persistent messages? Think the decoupling should be across the board.
see: http://www.nabble.com/Re%3A-sendFailIfNoSpace%3Dtrue%2C-no-JMSException-for-Producer-p26114622.html

so for np messages and a memory limit, sendFailIfNoSpace should work without producer flow control. thoughts or objections?

      was (Author: gtully):
    dejan, was there any reason this was completed for non persistent messages? Think the decoupling should be across the board.
see: http://www.nabble.com/Re%3A-sendFailIfNoSpace%3Dtrue%2C-no-JMSException-for-Producer-p26114622.html

so for np messages and a memory limit, sendFailIfNoSpace should work without producer flow control. thoughts or objections?
 

> Decouple sendFailIfNoSpace from producer flow control
> -----------------------------------------------------
>
>                 Key: AMQ-2343
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2343
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.2.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.3.0
>
>
> We have to notify the producer when broker run into disk storage limit even when the producer flow control is turned off.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/AMQ-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully reopened AMQ-2343:
-----------------------------


dejan, was there any reason this was completed for non persistent messages? Think the decoupling should be across the board.
see: http://www.nabble.com/Re%3A-sendFailIfNoSpace%3Dtrue%2C-no-JMSException-for-Producer-p26114622.html

so for np messages and a memory limit, sendFailIfNoSpace should work without producer flow control. thoughts or objections?

> Decouple sendFailIfNoSpace from producer flow control
> -----------------------------------------------------
>
>                 Key: AMQ-2343
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2343
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.2.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.3.0
>
>
> We have to notify the producer when broker run into disk storage limit even when the producer flow control is turned off.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/AMQ-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55081#action_55081 ]

Dejan Bosanac commented on AMQ-2343:
------------------------------------

Hi Garry, I can't think of any good reason why it is not done (and why we should not do it). I'll take a look at it

> Decouple sendFailIfNoSpace from producer flow control
> -----------------------------------------------------
>
>                 Key: AMQ-2343
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2343
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.2.0
>            Reporter: Dejan Bosanac
>            Assignee: Dejan Bosanac
>             Fix For: 5.3.0
>
>
> We have to notify the producer when broker run into disk storage limit even when the producer flow control is turned off.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.