[jira] Created: (ARCHETYPE-200) Should ask input for requiredProperty with defaultValue

Should ask input for requiredProperty with defaultValue
-------------------------------------------------------

                 Key: ARCHETYPE-200
                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
             Project: Maven Archetype
          Issue Type: Bug
          Components: Generator, Plugin
            Reporter: Grégory Joseph
         Attachments: ARCHETYPE-200.patch

It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.

DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/ARCHETYPE-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grégory Joseph updated ARCHETYPE-200:
-------------------------------------

    Attachment: ARCHETYPE-200.patch

> Should ask input for requiredProperty with defaultValue
> -------------------------------------------------------
>
>                 Key: ARCHETYPE-200
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator, Plugin
>            Reporter: Grégory Joseph
>         Attachments: ARCHETYPE-200.patch
>
>
> It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.
> DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

     [ http://jira.codehaus.org/browse/ARCHETYPE-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated ARCHETYPE-200:
---------------------------------

    Patch Submitted: [Yes]

> Should ask input for requiredProperty with defaultValue
> -------------------------------------------------------
>
>                 Key: ARCHETYPE-200
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator, Plugin
>            Reporter: Grégory Joseph
>         Attachments: ARCHETYPE-200.patch
>
>
> It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.
> DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/ARCHETYPE-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147169#action_147169 ]

Raphaël Piéroni commented on ARCHETYPE-200:
-------------------------------------------

Grégory,

with generate goal, the first time, no default value is asked for.
when you answer N to confirmation, then then any property is asked for, proposing a default value.

If you are really interrested in this feature, please know that some people expressed their desire in the properties being defaulted without any question.
So if you really want, it, please consider asking for a poll on that subject on user (cross posting to dev)

Thanks,

Raphaël

> Should ask input for requiredProperty with defaultValue
> -------------------------------------------------------
>
>                 Key: ARCHETYPE-200
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator, Plugin
>            Reporter: Grégory Joseph
>         Attachments: ARCHETYPE-200.patch
>
>
> It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.
> DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/ARCHETYPE-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147171#action_147171 ]

Grégory Joseph commented on ARCHETYPE-200:
------------------------------------------

I actually see value for all 3 cases ("fixed value" (ie the current "default"), "input with default" and "input"), while I find the idea of having to first fill in values, and then *not* confirm it to be able to change the defaults counter-intuitive.

Cheers,

-greg

> Should ask input for requiredProperty with defaultValue
> -------------------------------------------------------
>
>                 Key: ARCHETYPE-200
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator, Plugin
>            Reporter: Grégory Joseph
>         Attachments: ARCHETYPE-200.patch
>
>
> It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.
> DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/ARCHETYPE-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182613#action_182613 ]

ant elder commented on ARCHETYPE-200:
-------------------------------------

I also agree its counter intuitive like this, and having it prompt for the first time surely must be what most users would want and expect. I'd hunted and debugged this for hours before finding this jira and finding that it is possible to change the default value by answering N to the final confirmation prompt, that seems _really_ obscure. If it really is wanted by some wouldn't it be better to have a separate option to disable the initial prompting?

> Should ask input for requiredProperty with defaultValue
> -------------------------------------------------------
>
>                 Key: ARCHETYPE-200
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator, Plugin
>            Reporter: Grégory Joseph
>         Attachments: ARCHETYPE-200.patch
>
>
> It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.
> DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

    [ http://jira.codehaus.org/browse/ARCHETYPE-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182616#action_182616 ]

ant elder commented on ARCHETYPE-200:
-------------------------------------

See also http://jira.codehaus.org/browse/ARCHETYPE-200

> Should ask input for requiredProperty with defaultValue
> -------------------------------------------------------
>
>                 Key: ARCHETYPE-200
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-200
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator, Plugin
>            Reporter: Grégory Joseph
>         Attachments: ARCHETYPE-200.patch
>
>
> It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.
> DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira