[jira] Created: (CAMEL-1078) Do not copy Exchanges at each step to improve performance

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Hadrian Zbarcea edited comment on CAMEL-1078 at 6/23/09 2:01 PM:
-----------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
XmppExchange



      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
SpringIntegrationExchange
TraceEventExchange
XmppExchange


 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.1.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Claus Ibsen edited comment on CAMEL-1078 at 6/24/09 12:10 AM:
--------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
XmppExchange

And some hard ones:
GenericFileExchange
JmsExchange

      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
XmppExchange


 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.1.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Hadrian Zbarcea edited comment on CAMEL-1078 at 6/24/09 9:24 PM:
-----------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
XmppExchange

And some hard ones:
GenericFileExchange
JmsExchange

      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
XmppExchange

And some hard ones:
GenericFileExchange
JmsExchange
 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.1.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Hadrian Zbarcea edited comment on CAMEL-1078 at 6/24/09 9:45 PM:
-----------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
GenericFileExchange
JmsExchange

      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
XmppExchange

And some hard ones:
GenericFileExchange
JmsExchange
 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.1.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-1078:
-------------------------------

    Fix Version/s:     (was: 2.1.0)
                   2.0.0

Hadrian there are only 2-3 left so lets get them done before 2.0 is final.

That would be great as then there are no API changes needed for the performance improvements we can do under the covers.

We could even consider making DefaultExchange *final* so people wont create their own classes. Then the copy can be avoided.

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Hadrian Zbarcea edited comment on CAMEL-1078 at 6/27/09 6:52 AM:
-----------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
GenericFileExchange
[DONE] - RemoteFileExchange


      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
GenericFileExchange
JmsExchange
 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52656#action_52656 ]

Claus Ibsen commented on CAMEL-1078:
------------------------------------

Hadrian only 1 left. Do you work on it or should I give a stab? Would be great to have it done by start of next week so we can get started on a RC build of Camel 2.0.

This is really the last API changes we must get done before a 2.0 can be cut.

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Claus Ibsen edited comment on CAMEL-1078 at 7/2/09 10:50 PM:
-------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange


      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
GenericFileExchange
[DONE] - RemoteFileExchange

 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52689#action_52689 ]

Claus Ibsen commented on CAMEL-1078:
------------------------------------

Last one done, so we now only have the DefaultExchange.

Should it be final?

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Claus Ibsen edited comment on CAMEL-1078 at 7/4/09 12:52 AM:
-------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
[DONE] - TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange


      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange

 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Claus Ibsen edited comment on CAMEL-1078 at 7/4/09 12:58 AM:
-------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
[DONE] - TraceEventExchange
[DONE] - XmppExchange
- GroupedExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange


      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
[DONE] - TraceEventExchange
[DONE] - XmppExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange

 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52690#action_52690 ]

Claus Ibsen commented on CAMEL-1078:
------------------------------------

I have created a wiki page for design ideas of optimizations for Camel 2.x.

Please continue the discussion at this page.

http://cwiki.apache.org/confluence/display/CAMEL/Camel+2.x+Speed+optimizations

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47273#action_47273 ]

Claus Ibsen edited comment on CAMEL-1078 at 7/4/09 2:35 AM:
------------------------------------------------------------

Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
[DONE] - TraceEventExchange
[DONE] - XmppExchange
[DONE]- GroupedExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange


      was (Author: hadrian):
    Exchange specialized classes to be removed:
[DONE] - BeanExchange
[DONE] - CxfExchange
[DONE] - DummyExchange
[DONE] - FileExchange
[DONE] - HttpExchange
[DONE] - IrcExchange
[DONE] - JhcExchange
[DONE] - JmsExchange
[DONE] - JMXExchange
[DONE] - MailExchange
[DONE] - MinaExchange
[DONE] - MyExchange
[DONE] - QuartzExchange
[DONE] - RemoteFileExchange
[DONE] - SpringIntegrationExchange
[DONE] - TraceEventExchange
[DONE] - XmppExchange
- GroupedExchange

And some hard ones:
[DONE] - GenericFileExchange
[DONE] - RemoteFileExchange

 

> Do not copy Exchanges at each step to improve performance
> ---------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-1078:
-------------------------------

    Summary: Remove specialized Exchange and make DefaultExchange final to pave the road for optimization by reducing exchange copies  (was: Do not copy Exchanges at each step to improve performance)

> Remove specialized Exchange and make DefaultExchange final to pave the road for optimization by reducing exchange copies
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-1078.
--------------------------------

    Resolution: Fixed

Made DefaultExchange final.

Changed ticket subject.

Lets discuss at the design page and then create tickets after Camel 2.0 release and when got the time to do some optimizations.

> Remove specialized Exchange and make DefaultExchange final to pave the road for optimization by reducing exchange copies
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1078
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1078
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The code in DefaultEndpoint.createExchange(Exchange exchange), calls on getExchangeType() to figure out if a new copy of Exchange needs be created.  The code relies though on the generic argument of the Endpoint type to figure out the actual Exchange type.  With the generics removed part of CAMEL-872, getExchangeType() always returns null, forcing a copy every time.
> There is no real need to extend Exchange, so the proposal for this to make the Exchange final and move the component specific bits, if any,  in the Message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.