|
View:
New views
20 Messages
—
Rating Filter:
Alert me
|
| < Prev | 1 - 2 - 3 - 4 - 5 - 6 | Next > |
|
|
[jira] Created: (CAMEL-1392) groovy renderergroovy renderer
--------------- Key: CAMEL-1392 URL: https://issues.apache.org/activemq/browse/CAMEL-1392 Project: Apache Camel Issue Type: Sub-task Reporter: James Strachan -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Assigned: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Anstey reassigned CAMEL-1392: -------------------------------------- Assignee: Xueqiang Mi Xueqiang is looking into this as part of the groovy web console addition. > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererNow groovy renderer has been implemented, but only tested by using some rotue with basic processorDefinitions now.
For test all the processorDefinitions, I wonder where can I get some complex route definition test cases? Thanks
|
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererOn Fri, Jun 26, 2009 at 6:22 PM, alloyer<alloyer@...> wrote:
> > Now groovy renderer has been implemented, but only tested by using some rotue > with basic processorDefinitions now. > For test all the processorDefinitions, I wonder where can I get some complex > route definition test cases? We got complex unit tests in camel-core. So you can look in camel-core/src/test/java Usually they are in the processor package. You can try the RoutePerformanceTest to see how goes Or the ChoiceTest to see how it renders this. > > Thanks > > > JIRA jira@... wrote: >> >> >> [ >> https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Jonathan Anstey reassigned CAMEL-1392: >> -------------------------------------- >> >> Assignee: Xueqiang Mi >> >> Xueqiang is looking into this as part of the groovy web console addition. >> >>> groovy renderer >>> --------------- >>> >>> Key: CAMEL-1392 >>> URL: https://issues.apache.org/activemq/browse/CAMEL-1392 >>> Project: Apache Camel >>> Issue Type: Sub-task >>> Reporter: James Strachan >>> Assignee: Xueqiang Mi >>> >> >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> >> > > -- > View this message in context: http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24223272.html > Sent from the Camel Development mailing list archive at Nabble.com. > > -- Claus Ibsen Apache Camel Committer Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus |
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererThanks, I found lots of test cases there.
When I construct the groovy route definition from a RouteDefinition object, I have to process the processor definitions and its sub-classes? Most of them, like SendDefinition, OutputDefinition and ChoiceDefinition are easy to handle, but the ExpressionNode brought some problems. like the simplest one: DelayDefinition, when I want to generate the sentence "delay(xxxx)", I don't know where to get the xxxx delayTime. I have tried several ways: exp.getExpression() exp.getExpression().getExpression() exp.getExpression().getExpressionValue() but it always return a null value. Can you give me some suggestions? That's much better if you can tell a overview of the expression node structure because the bundle of concepts: Expression, Predicate, ExpressionDefinition..., let me a little confusing.
|
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererOh...I got the delay time now from "exp.getExpression().getExpressionValue()" now.
Previous faults may be caused by not compiling the source after editing.
|
|
|
[jira] Work started: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on CAMEL-1392 started by Xueqiang Mi. > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererHi
Could you create a JIRA ticket about the ExpressionDefinition problem we have? On Sun, Jun 28, 2009 at 6:49 AM, alloyer<alloyer@...> wrote: > > Now I got it now through "expressionNode.getExpression().toString()", which > return a string "{delayTime}". Then I can get the subString in it. Are there > some better methods? > > > alloyer wrote: >> >> Thanks, I found lots of test cases there. >> When I construct the groovy route definition from a RouteDefinition >> object, I have to process the processor definitions and its sub-classes? >> Most of them, like SendDefinition, OutputDefinition and ChoiceDefinition >> are easy to handle, but the ExpressionNode brought some problems. >> >> like the simplest one: DelayDefinition, when I want to generate the >> sentence "delay(xxxx)", I don't know where to get the xxxx delayTime. I >> have tried several ways: >> exp.getExpression() >> exp.getExpression().getExpression() >> exp.getExpression().getExpressionValue() >> but it always return a null value. >> Can you give me some suggestions? That's much better if you can tell a >> overview of the expression node structure because the bundle of concepts: >> Expression, Predicate, ExpressionDefinition..., let me a little confusing. >> >> >> Claus Ibsen-2 wrote: >>> >>> On Fri, Jun 26, 2009 at 6:22 PM, alloyer<alloyer@...> wrote: >>>> >>>> Now groovy renderer has been implemented, but only tested by using some >>>> rotue >>>> with basic processorDefinitions now. >>>> For test all the processorDefinitions, I wonder where can I get some >>>> complex >>>> route definition test cases? >>> >>> We got complex unit tests in camel-core. So you can look in >>> camel-core/src/test/java >>> Usually they are in the processor package. >>> >>> You can try the RoutePerformanceTest to see how goes >>> >>> Or the ChoiceTest to see how it renders this. >>> >>> >>> >>> >>>> >>>> Thanks >>>> >>>> >>>> JIRA jira@... wrote: >>>>> >>>>> >>>>> [ >>>>> https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>>>> ] >>>>> >>>>> Jonathan Anstey reassigned CAMEL-1392: >>>>> -------------------------------------- >>>>> >>>>> Assignee: Xueqiang Mi >>>>> >>>>> Xueqiang is looking into this as part of the groovy web console >>>>> addition. >>>>> >>>>>> groovy renderer >>>>>> --------------- >>>>>> >>>>>> Key: CAMEL-1392 >>>>>> URL: >>>>>> https://issues.apache.org/activemq/browse/CAMEL-1392 >>>>>> Project: Apache Camel >>>>>> Issue Type: Sub-task >>>>>> Reporter: James Strachan >>>>>> Assignee: Xueqiang Mi >>>>>> >>>>> >>>>> >>>>> -- >>>>> This message is automatically generated by JIRA. >>>>> - >>>>> You can reply to this email to add a comment to the issue online. >>>>> >>>>> >>>>> >>>> >>>> -- >>>> View this message in context: >>>> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24223272.html >>>> Sent from the Camel Development mailing list archive at Nabble.com. >>>> >>>> >>> >>> >>> >>> -- >>> Claus Ibsen >>> Apache Camel Committer >>> >>> Open Source Integration: http://fusesource.com >>> Blog: http://davsclaus.blogspot.com/ >>> Twitter: http://twitter.com/davsclaus >>> >>> >> >> > > -- > View this message in context: http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24238426.html > Sent from the Camel Development mailing list archive at Nabble.com. > > -- Claus Ibsen Apache Camel Committer Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus |
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererI do not have much knowledge of using JIRA, do you mean I create a sub-task to assign the ExpressionDefinition problem or a page to describe it?
|
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererOn Mon, Jun 29, 2009 at 7:59 AM, alloyer<alloyer@...> wrote:
> > I do not have much knowledge of using JIRA, do you mean I create a sub-task > to assign the ExpressionDefinition problem or a page to describe it? There is a button on JIRA - "Create new issue" This can be used to create a new issue where you can set it as a Apache Camel project, and as a bug. And then give it a summary about ExpressionDefinition not being able to render correctly in web console. Then we will not forget about it and can look into it in the near future. > > > Claus Ibsen-2 wrote: >> >> Hi >> >> Could you create a JIRA ticket about the ExpressionDefinition problem we >> have? >> >> >> On Sun, Jun 28, 2009 at 6:49 AM, alloyer<alloyer@...> wrote: >>> >>> Now I got it now through "expressionNode.getExpression().toString()", >>> which >>> return a string "{delayTime}". Then I can get the subString in it. Are >>> there >>> some better methods? >>> >>> >>> alloyer wrote: >>>> >>>> Thanks, I found lots of test cases there. >>>> When I construct the groovy route definition from a RouteDefinition >>>> object, I have to process the processor definitions and its sub-classes? >>>> Most of them, like SendDefinition, OutputDefinition and ChoiceDefinition >>>> are easy to handle, but the ExpressionNode brought some problems. >>>> >>>> like the simplest one: DelayDefinition, when I want to generate the >>>> sentence "delay(xxxx)", I don't know where to get the xxxx delayTime. I >>>> have tried several ways: >>>> exp.getExpression() >>>> exp.getExpression().getExpression() >>>> exp.getExpression().getExpressionValue() >>>> but it always return a null value. >>>> Can you give me some suggestions? That's much better if you can tell a >>>> overview of the expression node structure because the bundle of >>>> concepts: >>>> Expression, Predicate, ExpressionDefinition..., let me a little >>>> confusing. >>>> >>>> >>>> Claus Ibsen-2 wrote: >>>>> >>>>> On Fri, Jun 26, 2009 at 6:22 PM, alloyer<alloyer@...> wrote: >>>>>> >>>>>> Now groovy renderer has been implemented, but only tested by using >>>>>> some >>>>>> rotue >>>>>> with basic processorDefinitions now. >>>>>> For test all the processorDefinitions, I wonder where can I get some >>>>>> complex >>>>>> route definition test cases? >>>>> >>>>> We got complex unit tests in camel-core. So you can look in >>>>> camel-core/src/test/java >>>>> Usually they are in the processor package. >>>>> >>>>> You can try the RoutePerformanceTest to see how goes >>>>> >>>>> Or the ChoiceTest to see how it renders this. >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> Thanks >>>>>> >>>>>> >>>>>> JIRA jira@... wrote: >>>>>>> >>>>>>> >>>>>>> [ >>>>>>> https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>>>>>> ] >>>>>>> >>>>>>> Jonathan Anstey reassigned CAMEL-1392: >>>>>>> -------------------------------------- >>>>>>> >>>>>>> Assignee: Xueqiang Mi >>>>>>> >>>>>>> Xueqiang is looking into this as part of the groovy web console >>>>>>> addition. >>>>>>> >>>>>>>> groovy renderer >>>>>>>> --------------- >>>>>>>> >>>>>>>> Key: CAMEL-1392 >>>>>>>> URL: >>>>>>>> https://issues.apache.org/activemq/browse/CAMEL-1392 >>>>>>>> Project: Apache Camel >>>>>>>> Issue Type: Sub-task >>>>>>>> Reporter: James Strachan >>>>>>>> Assignee: Xueqiang Mi >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> This message is automatically generated by JIRA. >>>>>>> - >>>>>>> You can reply to this email to add a comment to the issue online. >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> View this message in context: >>>>>> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24223272.html >>>>>> Sent from the Camel Development mailing list archive at Nabble.com. >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Claus Ibsen >>>>> Apache Camel Committer >>>>> >>>>> Open Source Integration: http://fusesource.com >>>>> Blog: http://davsclaus.blogspot.com/ >>>>> Twitter: http://twitter.com/davsclaus >>>>> >>>>> >>>> >>>> >>> >>> -- >>> View this message in context: >>> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24238426.html >>> Sent from the Camel Development mailing list archive at Nabble.com. >>> >>> >> >> >> >> -- >> Claus Ibsen >> Apache Camel Committer >> >> Open Source Integration: http://fusesource.com >> Blog: http://davsclaus.blogspot.com/ >> Twitter: http://twitter.com/davsclaus >> >> > > -- > View this message in context: http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24248732.html > Sent from the Camel Development mailing list archive at Nabble.com. > > -- Claus Ibsen Apache Camel Committer Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus |
|
|
Re: [jira] Assigned: (CAMEL-1392) groovy rendererhttps://issues.apache.org/activemq/browse/CAMEL-1769 is created now.
|
|
|
[jira] Updated: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xueqiang Mi updated CAMEL-1392: ------------------------------- Attachment: camel-web-20090629.patch Now the GroovyRenderer can support most of the route definition on page: http://camel.apache.org/enterprise-integration-patterns.html ,expected the ExpressionDefinition process. https://issues.apache.org/activemq/browse/CAMEL-1769 is created to report the bug on ExpressionDefinition render. > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > Attachments: camel-web-20090629.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Issue Comment Edited: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52530#action_52530 ] Xueqiang Mi edited comment on CAMEL-1392 at 6/29/09 6:30 AM: ------------------------------------------------------------- Now the GroovyRenderer can support most of the route definition on page: http://camel.apache.org/enterprise-integration-patterns.html. But there are some bug for the ExpressionDefinition process. https://issues.apache.org/activemq/browse/CAMEL-1769 is created to report the bug on ExpressionDefinition render. was (Author: xueqiang.mi): Now the GroovyRenderer can support most of the route definition on page: http://camel.apache.org/enterprise-integration-patterns.html ,expected the ExpressionDefinition process. https://issues.apache.org/activemq/browse/CAMEL-1769 is created to report the bug on ExpressionDefinition render. > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > Attachments: camel-web-20090629.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Commented: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52559#action_52559 ] Jonathan Anstey commented on CAMEL-1392: ---------------------------------------- Nice work Xueqiang. A few comments before I will commit this to trunk: - Each time the route is edited, we get a new route id (route1, route2, route3, etc...). The original route id should be preserved. - We probably won't be able to support rendering closure expressions nicely unfortunately... a closure could be arbitrary Groovy code, which makes things very difficult. You may want to move on with the project and keep CAMEL-1769 as a known bug for now. Of course, you are MORE than welcome to give it a bit more thought/come up with a solution :) - Just as an FYI we'll eventually want to move the text renderer API to camel-core and the Groovy renderer to camel-groovy - its fine for now since this is still experimental. Maybe when the project is closer to completion later this summer you can do this work. - You should start adding in some unit tests for the renderer so we can keep track of what we know is rendering correctly. > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > Attachments: camel-web-20090629.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
Re: [jira] Created: (CAMEL-1392) groovy rendererWhen rendering some expressions, like the MethodCallExpression of ExpressionClause in web console, I have to use the expressionType property of ExpressionClause, so a getExpressionType() method is required.
Can I fix this bug or create a bug issue?
|
|
|
Re: [jira] Created: (CAMEL-1392) groovy rendererOn Thu, Jul 2, 2009 at 6:36 AM, alloyer<alloyer@...> wrote:
> > When rendering the some expression, like the MethodCallExpression of > ExpressionClause in web console, I have to use the expressionType property > of ExpressionClause, so a getExpressionType() method is required. > Can I fix this bug or create a bug issue? Yeah let me add the method to ExpressionDefinition. Just commited it, so if you do a svn up you should get it. > > > JIRA jira@... wrote: >> >> groovy renderer >> --------------- >> >> Key: CAMEL-1392 >> URL: https://issues.apache.org/activemq/browse/CAMEL-1392 >> Project: Apache Camel >> Issue Type: Sub-task >> Reporter: James Strachan >> >> >> >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> >> > > -- > View this message in context: http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24301005.html > Sent from the Camel Development mailing list archive at Nabble.com. > > -- Claus Ibsen Apache Camel Committer Open Source Integration: http://fusesource.com Blog: http://davsclaus.blogspot.com/ Twitter: http://twitter.com/davsclaus |
|
|
[jira] Updated: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xueqiang Mi updated CAMEL-1392: ------------------------------- Attachment: camel-web-20090703.patch > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > Attachments: camel-web-20090629.patch, camel-web-20090703.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Commented: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52686#action_52686 ] Jonathan Anstey commented on CAMEL-1392: ---------------------------------------- Quickly trying this new code drop out before leaving for the day :) In the GroovyRendererTest I noticed pretty much all routes defined in the supported list get rendered like "from("direct:start",).to("mock:result")". Example output: {code} dsl: from("direct:start").unmarshal().serialization().to("mock:result") after rendered: import org.apache.camel.language.groovy.GroovyRouteBuilder; class GroovyRoute extends GroovyRouteBuilder { void configure() { from("direct:start",).to("mock:result") } } {code} Not sure if this is a bug in the renderer or the test case. Care to fix that up? Also unit tests typically contain assertions on the output of a piece of code to make sure its operating correctly. In your case the test should be asserting that the output of the renderer is correct. Currently we have to verify this by looking at the output. > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > Attachments: camel-web-20090629.patch, camel-web-20090703.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
[jira] Commented: (CAMEL-1392) groovy renderer[ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52687#action_52687 ] Jonathan Anstey commented on CAMEL-1392: ---------------------------------------- Also, instead of duplicating the dataformat types (and loadbalancer types too), you should be able to grab the short names through the JAXB metadata. Like so {code} dataFormat.getClass().getAnnotation(XmlRootElement.class).name() {code} > groovy renderer > --------------- > > Key: CAMEL-1392 > URL: https://issues.apache.org/activemq/browse/CAMEL-1392 > Project: Apache Camel > Issue Type: Sub-task > Reporter: James Strachan > Assignee: Xueqiang Mi > Attachments: camel-web-20090629.patch, camel-web-20090703.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
|
|
Re: [jira] Commented: (CAMEL-1392) groovy rendereroho, I didn't find such a bug unexpectedly. It is caused I uses the same camel context for every test, and just get the first route definition every time without clean up the previous route definitions. As a result, we always get the route for the first test case.
|
| < Prev | 1 - 2 - 3 - 4 - 5 - 6 | Next > |
| Free embeddable forum powered by Nabble | Forum Help |