[jira] Created: (CAMEL-1392) groovy renderer

[Claus Ibsen-2]

On Thu, Aug 13, 2009 at 3:10 PM, Jon Anstey<janstey@...> wrote:
> I don't think you should be taking route definitions from one camel context
> and loading them into another... I'm surprised this actually works! Also,
> I'm not really following why you need a 2nd context to set the id... did you
> try just using one?
>

The "hidden" and advanced stuff such as interceptors / on exception
and the likes is not easy to distill back as there is special code in
Camel to take core of the routes is assembled correctly according to
how big impacts such cross cutting features impose.

So I do think the dynamic editor at present time should *not* have
such features to express. If we can do it for regular routes with then
we got far.
In the future we can have a better model that caters for tooling for
cross cutting functions such as interceptors.

> On Thu, Aug 13, 2009 at 10:19 AM, xueqiang.mi <alloyer@...> wrote:
>
>>
>> I found that the addRouteDefinitions method of camel context caused this
>> problem. It seems that this method transform the interceptDefinition into a
>> interceptStrategy.
>> Before updating a route, I use a temporary camel context to generate the
>> route definition from a route builder, so I can obtain the route definition
>> and reserve its id. Code is as follows:
>> {code}
>>       // add the route builder into a temporary camel context
>>        CamelContext tempContext = new DefaultCamelContext();
>>        tempContext.addRoutes(builder);
>>        // get all the added routes and add them into current context
>>        List<RouteDefinition> routeDefinitions =
>> tempContext.getRouteDefinitions();
>>        for (int i = 0; i < routeDefinitions.size(); i++) {
>>            RouteDefinition routeDefinition = routeDefinitions.get(i);
>>            // set id only for the first route
>>            if (i == 0)
>>                routeDefinition.setId(id);
>>
>>            // add or update the route
>>
>>
>> getCamelContext().addRouteDefinitions(Collections.singletonList(routeDefinition));
>>        }
>> {code}
>>
>> Then the addRouteDefinitions method is used to add the route definition to
>> current camel context and it causes that problem: transforming the
>> interceptDefinition into a interceptStrategy. Through test, this operation
>> has brought some other similar problems for other DSLs.
>>
>> Are there any suggestions to solve it?
>>
>> xueqiang.mi wrote:
>> >
>> > Hi,
>> > When I tested the intercept DSL, I encountered a problem.
>> > I found sometimes the route maintains the intercept definition as a
>> output
>> > processor in outputs list, but sometimes, it hold the intercept
>> > configuration in its interceptStrategies list. I don't what causes the
>> > difference and how to differentiate them.
>> >
>> >
>> > JIRA jira@... wrote:
>> >>
>> >> groovy renderer
>> >> ---------------
>> >>
>> >>                  Key: CAMEL-1392
>> >>                  URL:
>> >> https://issues.apache.org/activemq/browse/CAMEL-1392
>> >>              Project: Apache Camel
>> >>           Issue Type: Sub-task
>> >>             Reporter: James Strachan
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> This message is automatically generated by JIRA.
>> >> -
>> >> You can reply to this email to add a comment to the issue online.
>> >>
>> >>
>> >>
>> >
>> >
>>
>> --
>> View this message in context:
>> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24954096.html
>> Sent from the Camel Development mailing list archive at Nabble.com.
>>
>>
>
>
> --
> Cheers,
> Jon
>
> http://janstey.blogspot.com/
>

--
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

[janstey]

After trying to grok the intercept code a bit, I'm gonna +1 Claus'
suggestion :)

As a side note for any Camel users listening in, the intercept stuff in 2.0
is *much* easier to use than 1.x from a users standpoint - its just complex
under the hood.

On Thu, Aug 13, 2009 at 10:50 AM, Claus Ibsen <claus.ibsen@...> wrote:

> On Thu, Aug 13, 2009 at 3:10 PM, Jon Anstey<janstey@...> wrote:
> > I don't think you should be taking route definitions from one camel
> context
> > and loading them into another... I'm surprised this actually works! Also,
> > I'm not really following why you need a 2nd context to set the id... did
> you
> > try just using one?
> >
>
> The "hidden" and advanced stuff such as interceptors / on exception
> and the likes is not easy to distill back as there is special code in
> Camel to take core of the routes is assembled correctly according to
> how big impacts such cross cutting features impose.
>
> So I do think the dynamic editor at present time should *not* have
> such features to express. If we can do it for regular routes with then
> we got far.
> In the future we can have a better model that caters for tooling for
> cross cutting functions such as interceptors.
>
>
>
> > On Thu, Aug 13, 2009 at 10:19 AM, xueqiang.mi <alloyer@...> wrote:
> >
> >>
> >> I found that the addRouteDefinitions method of camel context caused this
> >> problem. It seems that this method transform the interceptDefinition
> into a
> >> interceptStrategy.
> >> Before updating a route, I use a temporary camel context to generate the
> >> route definition from a route builder, so I can obtain the route
> definition
> >> and reserve its id. Code is as follows:
> >> {code}
> >>       // add the route builder into a temporary camel context
> >>        CamelContext tempContext = new DefaultCamelContext();
> >>        tempContext.addRoutes(builder);
> >>        // get all the added routes and add them into current context
> >>        List<RouteDefinition> routeDefinitions =
> >> tempContext.getRouteDefinitions();
> >>        for (int i = 0; i < routeDefinitions.size(); i++) {
> >>            RouteDefinition routeDefinition = routeDefinitions.get(i);
> >>            // set id only for the first route
> >>            if (i == 0)
> >>                routeDefinition.setId(id);
> >>
> >>            // add or update the route
> >>
> >>
> >>
> getCamelContext().addRouteDefinitions(Collections.singletonList(routeDefinition));
> >>        }
> >> {code}
> >>
> >> Then the addRouteDefinitions method is used to add the route definition
> to
> >> current camel context and it causes that problem: transforming the
> >> interceptDefinition into a interceptStrategy. Through test, this
> operation
> >> has brought some other similar problems for other DSLs.
> >>
> >> Are there any suggestions to solve it?
> >>
> >> xueqiang.mi wrote:
> >> >
> >> > Hi,
> >> > When I tested the intercept DSL, I encountered a problem.
> >> > I found sometimes the route maintains the intercept definition as a
> >> output
> >> > processor in outputs list, but sometimes, it hold the intercept
> >> > configuration in its interceptStrategies list. I don't what causes the
> >> > difference and how to differentiate them.
> >> >
> >> >
> >> > JIRA jira@... wrote:
> >> >>
> >> >> groovy renderer
> >> >> ---------------
> >> >>
> >> >>                  Key: CAMEL-1392
> >> >>                  URL:
> >> >> https://issues.apache.org/activemq/browse/CAMEL-1392
> >> >>              Project: Apache Camel
> >> >>           Issue Type: Sub-task
> >> >>             Reporter: James Strachan
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> This message is automatically generated by JIRA.
> >> >> -
> >> >> You can reply to this email to add a comment to the issue online.
> >> >>
> >> >>
> >> >>
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >>
> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24954096.html
> >> Sent from the Camel Development mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> > --
> > Cheers,
> > Jon
> >
> > http://janstey.blogspot.com/
> >
>
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>

--
Cheers,
Jon

http://janstey.blogspot.com/

[xueqiang.mi]

From the groovyRouteBuilder, we can only get a routeBuild, which may have several routes in it and doesn't support to setId.

janstey wrote:

I don't think you should be taking route definitions from one camel context
and loading them into another... I'm surprised this actually works! Also,
I'm not really following why you need a 2nd context to set the id... did you
try just using one?

On Thu, Aug 13, 2009 at 10:19 AM, xueqiang.mi <[e-mail]> wrote:

>
> I found that the addRouteDefinitions method of camel context caused this
> problem. It seems that this method transform the interceptDefinition into a
> interceptStrategy.
> Before updating a route, I use a temporary camel context to generate the
> route definition from a route builder, so I can obtain the route definition
> and reserve its id. Code is as follows:
> {code}
>       // add the route builder into a temporary camel context
>        CamelContext tempContext = new DefaultCamelContext();
>        tempContext.addRoutes(builder);
>        // get all the added routes and add them into current context
>        List<RouteDefinition> routeDefinitions =
> tempContext.getRouteDefinitions();
>        for (int i = 0; i < routeDefinitions.size(); i++) {
>            RouteDefinition routeDefinition = routeDefinitions.get(i);
>            // set id only for the first route
>            if (i == 0)
>                routeDefinition.setId(id);
>
>            // add or update the route
>
>
> getCamelContext().addRouteDefinitions(Collections.singletonList(routeDefinition));
>        }
> {code}
>
> Then the addRouteDefinitions method is used to add the route definition to
> current camel context and it causes that problem: transforming the
> interceptDefinition into a interceptStrategy. Through test, this operation
> has brought some other similar problems for other DSLs.
>
> Are there any suggestions to solve it?
>
> xueqiang.mi wrote:
> >
> > Hi,
> > When I tested the intercept DSL, I encountered a problem.
> > I found sometimes the route maintains the intercept definition as a
> output
> > processor in outputs list, but sometimes, it hold the intercept
> > configuration in its interceptStrategies list. I don't what causes the
> > difference and how to differentiate them.
> >
> >
> > JIRA [e-mail] wrote:
> >>
> >> groovy renderer
> >> ---------------
> >>
> >>                  Key: CAMEL-1392
> >>                  URL:
> >> https://issues.apache.org/activemq/browse/CAMEL-1392
> >>              Project: Apache Camel
> >>           Issue Type: Sub-task
> >>             Reporter: James Strachan
> >>
> >>
> >>
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >>
> >>
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24954096.html
> Sent from the Camel Development mailing list archive at Nabble.com.
>
>


--
Cheers,
Jon

http://janstey.blogspot.com/

[xueqiang.mi]

okay, I am now reviewing the test case. A document, presenting which DSLs are supported and which are not, will be commited tomorrow or the day after tomorrow.
cheers

janstey wrote:

After trying to grok the intercept code a bit, I'm gonna +1 Claus'
suggestion :)

As a side note for any Camel users listening in, the intercept stuff in 2.0
is *much* easier to use than 1.x from a users standpoint - its just complex
under the hood.

On Thu, Aug 13, 2009 at 10:50 AM, Claus Ibsen <[e-mail]> wrote:

> On Thu, Aug 13, 2009 at 3:10 PM, Jon Anstey<[e-mail]> wrote:
> > I don't think you should be taking route definitions from one camel
> context
> > and loading them into another... I'm surprised this actually works! Also,
> > I'm not really following why you need a 2nd context to set the id... did
> you
> > try just using one?
> >
>
> The "hidden" and advanced stuff such as interceptors / on exception
> and the likes is not easy to distill back as there is special code in
> Camel to take core of the routes is assembled correctly according to
> how big impacts such cross cutting features impose.
>
> So I do think the dynamic editor at present time should *not* have
> such features to express. If we can do it for regular routes with then
> we got far.
> In the future we can have a better model that caters for tooling for
> cross cutting functions such as interceptors.
>
>
>
> > On Thu, Aug 13, 2009 at 10:19 AM, xueqiang.mi <[e-mail]> wrote:
> >
> >>
> >> I found that the addRouteDefinitions method of camel context caused this
> >> problem. It seems that this method transform the interceptDefinition
> into a
> >> interceptStrategy.
> >> Before updating a route, I use a temporary camel context to generate the
> >> route definition from a route builder, so I can obtain the route
> definition
> >> and reserve its id. Code is as follows:
> >> {code}
> >>       // add the route builder into a temporary camel context
> >>        CamelContext tempContext = new DefaultCamelContext();
> >>        tempContext.addRoutes(builder);
> >>        // get all the added routes and add them into current context
> >>        List<RouteDefinition> routeDefinitions =
> >> tempContext.getRouteDefinitions();
> >>        for (int i = 0; i < routeDefinitions.size(); i++) {
> >>            RouteDefinition routeDefinition = routeDefinitions.get(i);
> >>            // set id only for the first route
> >>            if (i == 0)
> >>                routeDefinition.setId(id);
> >>
> >>            // add or update the route
> >>
> >>
> >>
> getCamelContext().addRouteDefinitions(Collections.singletonList(routeDefinition));
> >>        }
> >> {code}
> >>
> >> Then the addRouteDefinitions method is used to add the route definition
> to
> >> current camel context and it causes that problem: transforming the
> >> interceptDefinition into a interceptStrategy. Through test, this
> operation
> >> has brought some other similar problems for other DSLs.
> >>
> >> Are there any suggestions to solve it?
> >>
> >> xueqiang.mi wrote:
> >> >
> >> > Hi,
> >> > When I tested the intercept DSL, I encountered a problem.
> >> > I found sometimes the route maintains the intercept definition as a
> >> output
> >> > processor in outputs list, but sometimes, it hold the intercept
> >> > configuration in its interceptStrategies list. I don't what causes the
> >> > difference and how to differentiate them.
> >> >
> >> >
> >> > JIRA [e-mail] wrote:
> >> >>
> >> >> groovy renderer
> >> >> ---------------
> >> >>
> >> >>                  Key: CAMEL-1392
> >> >>                  URL:
> >> >> https://issues.apache.org/activemq/browse/CAMEL-1392
> >> >>              Project: Apache Camel
> >> >>           Issue Type: Sub-task
> >> >>             Reporter: James Strachan
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> This message is automatically generated by JIRA.
> >> >> -
> >> >> You can reply to this email to add a comment to the issue online.
> >> >>
> >> >>
> >> >>
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >>
> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p24954096.html
> >> Sent from the Camel Development mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> > --
> > Cheers,
> > Jon
> >
> > http://janstey.blogspot.com/
> >
>
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>



--
Cheers,
Jon

http://janstey.blogspot.com/

     [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xueqiang Mi updated CAMEL-1392:
-------------------------------

    Attachment: camel-20090816.patch

add some test cases and DSL support

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53633#action_53633 ]

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

Hi Xueqiang,

I just tried to apply camel-20090816.patch against the latest trunk and it failed. I noticed a couple of errors like duplicated diffs, etc in the patch file. How did you generate it?

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53634#action_53634 ]

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

Ah, I see there was some checkstyle fixes made today to camel-web. Xueqiang, could you update to the latest trunk and re-submit your patch?

Cheers,
Jon

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53635#action_53635 ]

Xueqiang Mi commented on CAMEL-1392:
------------------------------------

Oh, I will check it again and re-submit it some later.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53640#action_53640 ]

Claus Ibsen commented on CAMEL-1392:
------------------------------------

Xuegiang

Could you build with checkstyle and make sure the patches are compliant with checkstyle. See more here to run it:
http://camel.apache.org/building.html

As it causes us to have to manually fix it later. And this weekend Hadrian had to use quite some time on this that causes further delay on a 2.0 release.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xueqiang Mi updated CAMEL-1392:
-------------------------------

    Attachment: camel-20090817.patch

There is a code style error I can't fix. I don't know why it occurs though I modify that line of code.
[INFO] Velocity successfully started.
[INFO] [checkstyle:checkstyle {execution: validate}]
[INFO] Starting audit...
F:\camel\trunk\components\camel-web\src\main\java\org\apache\camel\web\util\OutputDefinitionRenderer.java:60:5: Executable statement co
unt is 89 (max allowed is 75).
Audit done.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53646#action_53646 ]

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

I think the method is just too long. Factor it out into several smaller methods to see if that helps. I did a quick test where I basically commented out half of the method and it passed.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xueqiang Mi updated CAMEL-1392:
-------------------------------

    Attachment: camel-20090818.patch

yep, I thought you meant to refact the mothod name rather the method body.
Now when shortening the method, the error really goes away.
Thanks.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53663#action_53663 ]

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

Committed camel-20090818.patch in rev http://svn.apache.org/viewvc?rev=805381&view=rev

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[xueqiang.mi]

I got a jersey problem:
To change the status of a route on the following page by send:
http://localhost:9998/routes/route1/status
ss.jpg
It is expected to be delivered into the following method of RouteResource
{code}
    @Path("status")
    public RouteStatusResource getRouteStatus() {
        return new RouteStatusResource(this);
    }
{code}
but now it goes into the postRouteForm method and throws exception,
{code}
    @POST
    @Consumes("application/x-www-form-urlencoded")
    public Response postRouteForm(@Context UriInfo uriInfo, Form formData) throws URISyntaxException {
    // omission
    }
{code}
I don't know why it is sent there? Hope someone can give some explanation. thanks.

JIRA [e-mail] wrote:

groovy renderer
---------------

                 Key: CAMEL-1392
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
             Project: Apache Camel
          Issue Type: Sub-task
            Reporter: James Strachan




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[janstey]

I can't shed any light into why this stopped working... but I did put in a
fix (or workaround?) in revision 805780.

On Wed, Aug 19, 2009 at 5:13 AM, xueqiang.mi <alloyer@...> wrote:

>
> I got a jersey problem:
> To change the status of a route on the following page by send:
> http://localhost:9998/routes/route1/status
> http://www.nabble.com/file/p25039325/ss.jpg ss.jpg
> It is expected to be delivered into the following method of RouteResource
> {code}
>    @Path("status")
>    public RouteStatusResource getRouteStatus() {
>        return new RouteStatusResource(this);
>    }
> {code}
> but now it goes into the postRouteForm method and throws exception,
> {code}
>    @POST
>    @Consumes("application/x-www-form-urlencoded")
>    public Response postRouteForm(@Context UriInfo uriInfo, Form formData)
> throws URISyntaxException {
>    // omission
>    }
> {code}
> I don't know why it is sent there? Hope someone can give some explanation.
> thanks.
>
>
> JIRA jira@... wrote:
> >
> > groovy renderer
> > ---------------
> >
> >                  Key: CAMEL-1392
> >                  URL:
> https://issues.apache.org/activemq/browse/CAMEL-1392
> >              Project: Apache Camel
> >           Issue Type: Sub-task
> >             Reporter: James Strachan
> >
> >
> >
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
> >
>
> --
> View this message in context:
> http://www.nabble.com/-jira--Created%3A-%28CAMEL-1392%29-groovy-renderer-tp22220288p25039325.html
> Sent from the Camel Development mailing list archive at Nabble.com.
>
>

--
Cheers,
Jon

http://janstey.blogspot.com/

     [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xueqiang Mi updated CAMEL-1392:
-------------------------------

    Attachment: camel-20090821.patch

Add filter().xpath() support;
Let  camel reserve the original id on the newest route after editing

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-20090821.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xueqiang Mi updated CAMEL-1392:
-------------------------------

    Attachment: camel-2009082101.patch

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-20090821.patch, camel-2009082101.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53698#action_53698 ]

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

Committed your latest patch in http://svn.apache.org/viewvc?rev=806533&view=rev

Glad to see you got rid of that temp context! :)

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-20090821.patch, camel-2009082101.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xueqiang Mi updated CAMEL-1392:
-------------------------------

    Attachment: camel-web-20090902.patch

Add create new route and view all routes link on routes page;
Let route editor return into sitemesh decorator

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-20090821.patch, camel-2009082101.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch, camel-web-20090902.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53964#action_53964 ]

Willem Jiang commented on CAMEL-1392:
-------------------------------------

@ Xueqiang

Can you take a look the unit tests in the org.apache.camel.web.groovy which are commented out ?
There are about 10 tests which do work now.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-20090806.patch, camel-20090807.patch, camel-20090808.patch, camel-20090810.patch, camel-20090816.patch, camel-20090817.patch, camel-20090818.patch, camel-20090821.patch, camel-2009082101.patch, camel-web-20090629.patch, camel-web-20090703.patch, camel-web-20090705.patch, camel-web-20090708.patch, camel-web-20090716.patch, camel-web-20090717.patch, camel-web-20090718.patch, camel-web-20090722.patch, camel-web-20090902.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.