[jira] Created: (CAMEL-1787) Add SSL support to camel-irc

Add SSL support to camel-irc
----------------------------

                 Key: CAMEL-1787
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
             Project: Apache Camel
          Issue Type: New Feature
            Reporter: Stan Lewis
         Attachments: patch.txt

Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:

ircs://<username>:server:6667/#channel

By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stan Lewis updated CAMEL-1787:
------------------------------

    Attachment: patch.txt

Here's the patch!

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52680#action_52680 ]

Jonathan Anstey commented on CAMEL-1787:
----------------------------------------

Just tested and committed your addition Stan. Thanks!

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey resolved CAMEL-1787.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
         Assignee: Jonathan Anstey

http://svn.apache.org/viewvc?rev=790952&view=rev & http://svn.apache.org/viewvc?rev=790956&view=rev

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52682#action_52682 ]

Claus Ibsen commented on CAMEL-1787:
------------------------------------

Janstey be careful the loading of custom SSLTrustManager is flawed.

It should not use a string to load a class name using Class.forName etc.
What you should do instead is having a SSLTrustManager setter/getter on the endpoint.

And then use Spring IoC or the likes to setup the implementation.

So I would like this patch to be fixed by
{code}
ircEndpoint

  private SSLTrustManager sslTrustManager = new DefaultSSLTrustManager();

  // add getter/setter to it
{code}

And remove the trustManagerClass option as its not needed.

Then you can use a custom manager like this
{code}
ircs://<username>:server:6667/#channel?sslTruastManager=#myCustomManager
{code}

And Camel will lookup in the registry for the custom manager by this given id.

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reopened CAMEL-1787:
--------------------------------

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52684#action_52684 ]

Jonathan Anstey commented on CAMEL-1787:
----------------------------------------

Good point Claus. I'll fix this up.

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52683#action_52683 ]

Claus Ibsen commented on CAMEL-1787:
------------------------------------

And Class.forName does not work well in OSGi platforms and whatnot.

If you really need to load a class you should use CamelContext.getClassResolver and use it to load a class as it can handle OSGi vs non OSGi platforms.

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey resolved CAMEL-1787.
------------------------------------

    Resolution: Fixed

Fixes have been committed to trunk.

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/activemq/browse/CAMEL-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52695#action_52695 ]

Stan Lewis commented on CAMEL-1787:
-----------------------------------

Awesome, thanks guys!  Good to know about the class loading, I didn't want to leave that hard coded, thanks Claus.

> Add SSL support to camel-irc
> ----------------------------
>
>                 Key: CAMEL-1787
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1787
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Stan Lewis
>            Assignee: Jonathan Anstey
>             Fix For: 2.0.0
>
>         Attachments: patch.txt
>
>
> Am attaching a patch that adds SSL support to camel-irc for connecting to SSL-enabled IRC servers.  Unfortunately I haven't tracked down a public IRC server that's SSL enabled to add a test for this but have tested here a bunch against a private IRC server.  The URI format is like:
> ircs://<username>:server:6667/#channel
> By default the component will use [SSLDefaultTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLDefaultTrustManager.html] but I've added in another parameter so you can pass ?trustManagerClass and specify a class that implements [SSLTrustManager|http://moepii.sourceforge.net/irclib/javadoc/org/schwering/irc/lib/ssl/SSLTrustManager.html]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.