[jira] Created: (CARGO-710) The maven cargo plugin requires that the file extension matches the project type

The maven cargo plugin requires that the file extension matches the project type
--------------------------------------------------------------------------------

                 Key: CARGO-710
                 URL: http://jira.codehaus.org/browse/CARGO-710
             Project: Cargo
          Issue Type: Bug
          Components: Maven2
            Reporter: Paul Gier
         Attachments: basic-sar.zip

Currently the cargo plugin requires that the file extension of the deployable file matches the dependency type.  However, this is not always the case.  For example, the jboss packaging maven plugin defines a project type called jboss-sar and sets the file extension to ".sar".  When trying to deploy this artifact from the project where it is defined, I get the following error:

{quote}
[WARNING] The defined deployable has the same groupId and artifactId as your project's main artifact but the type is different. You've defined a [sar] type whereas the project's packaging is [jboss-sar]. This is possibly an error and as a consequence the plugin will try to find this deployable in the project's dependencies.
{quote}

The cargo plugin should be able to handle this difference.

I attached a basic project that reproduces the issue.  Just run "mvn cargo:deploy" to see the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/CARGO-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180185#action_180185 ]

Matt Wringe commented on CARGO-710:
-----------------------------------

the issue is that when deploying an artifact it looks at the type to define the type of artifact to find (in this case 'jboss-sar' and not 'sar'), but the deployer also uses this value to determine if the deployable can be deployed on the server (in this case 'sar' is acceptable since the server can accept sar files, but 'jboss-sar' is unknown).

The fix is fairly simple, as all we need to do is alias the jboss-sar type in the deployer to accept jboss-sar as a sar file.

/me has never understood why cargo requires that a deployable type is known to work with a server before deploying to it. It should at the most throw a warning (and should probably just trust the user knows what they are doing).

> The maven cargo plugin requires that the file extension matches the project type
> --------------------------------------------------------------------------------
>
>                 Key: CARGO-710
>                 URL: http://jira.codehaus.org/browse/CARGO-710
>             Project: Cargo
>          Issue Type: Bug
>          Components: Maven2
>            Reporter: Paul Gier
>         Attachments: basic-sar.zip
>
>
> Currently the cargo plugin requires that the file extension of the deployable file matches the dependency type.  However, this is not always the case.  For example, the jboss packaging maven plugin defines a project type called jboss-sar and sets the file extension to ".sar".  When trying to deploy this artifact from the project where it is defined, I get the following error:
> {quote}
> [WARNING] The defined deployable has the same groupId and artifactId as your project's main artifact but the type is different. You've defined a [sar] type whereas the project's packaging is [jboss-sar]. This is possibly an error and as a consequence the plugin will try to find this deployable in the project's dependencies.
> {quote}
> The cargo plugin should be able to handle this difference.
> I attached a basic project that reproduces the issue.  Just run "mvn cargo:deploy" to see the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

    [ http://jira.codehaus.org/browse/CARGO-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=180191#action_180191 ]

Paul Gier commented on CARGO-710:
---------------------------------

I agree if cargo can't resolve the type it should just throw a warning.  There are currently four types defined in the jboss packaging plugin:
jboss-sar - .sar
jboss-har - .har
jboss-spring - .spring
jboss-esb - .esb

I'm not sure why these types were named this way when the plugin was first created, but we're kind of stuck with them for a while.

> The maven cargo plugin requires that the file extension matches the project type
> --------------------------------------------------------------------------------
>
>                 Key: CARGO-710
>                 URL: http://jira.codehaus.org/browse/CARGO-710
>             Project: Cargo
>          Issue Type: Bug
>          Components: Maven2
>            Reporter: Paul Gier
>         Attachments: basic-sar.zip
>
>
> Currently the cargo plugin requires that the file extension of the deployable file matches the dependency type.  However, this is not always the case.  For example, the jboss packaging maven plugin defines a project type called jboss-sar and sets the file extension to ".sar".  When trying to deploy this artifact from the project where it is defined, I get the following error:
> {quote}
> [WARNING] The defined deployable has the same groupId and artifactId as your project's main artifact but the type is different. You've defined a [sar] type whereas the project's packaging is [jboss-sar]. This is possibly an error and as a consequence the plugin will try to find this deployable in the project's dependencies.
> {quote}
> The cargo plugin should be able to handle this difference.
> I attached a basic project that reproduces the issue.  Just run "mvn cargo:deploy" to see the problem.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email