[jira] Created: (CARGO-727) WAR created by "uberwar" does not contain manifest

View: New views
1 Messages — Rating Filter:   Alert me  

[jira] Created: (CARGO-727) WAR created by "uberwar" does not contain manifest

by JIRA jira@codehaus.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

WAR created by "uberwar" does not contain manifest
--------------------------------------------------

                 Key: CARGO-727
                 URL: http://jira.codehaus.org/browse/CARGO-727
             Project: Cargo
          Issue Type: Improvement
          Components: Maven2
    Affects Versions: 1.0
            Reporter: Anton Khitrenovich


Obviously, it is impossible to "merge" manifests from source WARs.
However, there is no possibility to specify own, even minimal, manifest for merged WAR file.

I suggest to add this option to plugin configuration.
For example,
        <plugin>
                <groupId>org.codehaus.cargo</groupId>
                <artifactId>cargo-maven2-plugin</artifactId>
                <extensions>true</extensions>
                <configuration>
                        <descriptor>src/assemble/merge.xml</descriptor>
                        <manifestEntries>
                                <Implementation-Version>${majorVersion}</Implementation-Version>
                                <Implementation-Vendor>MyCompany</Implementation-Vendor>
                        </manifestEntries>
                </configuration>
        </plugin>

From the code point of view:
1) JarUtils.createJarFromDirectory():
        * use Manifest as additional parameter, map two-argument call to new function
        * when not null, pass Manifest as second argument to the constructor of JarOutputStream
2) UberWarMojo/WarArchiveMerger/MergedWarArchive trio:
        * use configuration values to create correct Manifest object
        * send Manifest to JarUtil in MergedWarArchive.store()


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email