[jira] Created: (COCOON-2268) To extend the image reader we need to change the visibility to the parameter of the ImageReader

To extend the image reader we need to change the visibility to the parameter of the ImageReader
-----------------------------------------------------------------------------------------------

                 Key: COCOON-2268
                 URL: https://issues.apache.org/jira/browse/COCOON-2268
             Project: Cocoon
          Issue Type: Improvement
          Components: * Cocoon Core
    Affects Versions: 2.1.12-dev (Current SVN)
            Reporter: Gaurav
             Fix For: 2.1.12-dev (Current SVN)
         Attachments: patch.cocoon.imagereader.txt

I am planing to submit a patch to support almost all  image formats with a new  ImageReader based on ImageMagick and I am planning to extend ImageReader. To efficiently do that i need that some methods will change visibility since i am only going to implement the method:

protected void processStream(InputStream inputStream)

I can not see anything against the changes in the patch but if i missed something please tell me so.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gaurav updated COCOON-2268:
---------------------------

    Attachment: patch.cocoon.imagereader.txt

Patch for ImageReader.

> To extend the image reader we need to change the visibility to the parameter of the ImageReader
> -----------------------------------------------------------------------------------------------
>
>                 Key: COCOON-2268
>                 URL: https://issues.apache.org/jira/browse/COCOON-2268
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Gaurav
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: patch.cocoon.imagereader.txt
>
>
> I am planing to submit a patch to support almost all  image formats with a new  ImageReader based on ImageMagick and I am planning to extend ImageReader. To efficiently do that i need that some methods will change visibility since i am only going to implement the method:
> protected void processStream(InputStream inputStream)
> I can not see anything against the changes in the patch but if i missed something please tell me so.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Thorsten Scherler-3]

On Tue, 2009-09-22 at 08:38 -0700, Gaurav (JIRA) wrote:

> To extend the image reader we need to change the visibility to the parameter of the ImageReader
> -----------------------------------------------------------------------------------------------
>
>                  Key: COCOON-2268
>                  URL: https://issues.apache.org/jira/browse/COCOON-2268
>              Project: Cocoon
>           Issue Type: Improvement
>           Components: * Cocoon Core
>     Affects Versions: 2.1.12-dev (Current SVN)
>             Reporter: Gaurav
>              Fix For: 2.1.12-dev (Current SVN)
>          Attachments: patch.cocoon.imagereader.txt
>
> I am planing to submit a patch to support almost all  image formats with a new  ImageReader based on ImageMagick and I am planning to extend ImageReader. To efficiently do that i need that some methods will change visibility since i am only going to implement the method:
>
> protected void processStream(InputStream inputStream)
>
> I can not see anything against the changes in the patch but if i missed something please tell me so.

I reviewed the patch and I do not see any problem with it.

If nobody objects withing 48 hours I will apply the patch.

salu2
--
Thorsten Scherler <thorsten.at.apache.org>
Open Source Java <consulting, training and solutions>

Sociedad Andaluza para el Desarrollo de la Sociedad
de la Información, S.A.U. (SADESI)