[jira] Created: (COCOON3-38) Cocoon-monitoring base information about Servlet-Services

Cocoon-monitoring base information about Servlet-Services
---------------------------------------------------------

                 Key: COCOON3-38
                 URL: https://issues.apache.org/jira/browse/COCOON3-38
             Project: Cocoon 3
          Issue Type: New Feature
          Components: cocoon-optional
    Affects Versions: 3.0.0-alpha-2
            Reporter: Dariusz Łuksza
            Assignee: Cocoon Developers Team
            Priority: Minor


Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dariusz Łuksza updated COCOON3-38:
----------------------------------

    Attachment: cocoon-servlet-srvices-impl-connections.patch

Patch for implementation Cocoon Servlet-Service that adds possibility of getting connections for Service-Servlet.

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>         Attachments: cocoon-servlet-srvices-impl-connections.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dariusz Łuksza updated COCOON3-38:
----------------------------------

    Attachment: servlet-services-monitor.patch
                servlet-services-doc.patch

Patches for cocoon-monitoring and cocoon-doc projects that adds described new features.

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-monitor.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dariusz Łuksza updated COCOON3-38:
----------------------------------

    Attachment: servlet-services-monitor1.patch

Implemented new features mentioned by Reinhard in [mail|http://mail-archives.apache.org/mod_mbox/cocoon-dev/200906.mbox/%3c4A36B428.6060301@...%3e]

{quote}
1) I would prefer having all servlet services as nodes in the tree of mbeans (similar to what Jetty does with servlets) and

2) also expose the servlet parameters.

3) show the short name of a connection additionally to the fully qualified bean name
{quote}

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722440#action_12722440 ]

Dariusz Łuksza edited comment on COCOON3-38 at 6/21/09 4:34 PM:
----------------------------------------------------------------

Implemented new features mentioned by Reinhard in mail (http://mail-archives.apache.org/mod_mbox/cocoon-dev/200906.mbox/%3c4A36B428.6060301@...%3e)

1) I would prefer having all servlet services as nodes in the tree of mbeans (similar to what Jetty does with servlets) and
2) also expose the servlet parameters.
3) show the short name of a connection additionally to the fully qualified bean name

      was (Author: dluksza):
    Implemented new features mentioned by Reinhard in [mail|http://mail-archives.apache.org/mod_mbox/cocoon-dev/200906.mbox/%3c4A36B428.6060301@...%3e]

{quote}
1) I would prefer having all servlet services as nodes in the tree of mbeans (similar to what Jetty does with servlets) and

2) also expose the servlet parameters.

3) show the short name of a connection additionally to the fully qualified bean name
{quote}
 

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz updated COCOON3-38:
----------------------------------

    Fix Version/s: 3.0.0-alpha-2

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dariusz Łuksza updated COCOON3-38:
----------------------------------

    Attachment: servlet-services-doc1.patch

Patch for cocoon-docs adds description of cocoon-monitoring Servlet-Service.

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz reassigned COCOON3-38:
-------------------------------------

    Assignee: Reinhard Poetz  (was: Cocoon Developers Team)

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731178#action_12731178 ]

Reinhard Poetz commented on COCOON3-38:
---------------------------------------

I applied  servlet-services-monitor1.patch with some minor modifactions: I use a private accessor to get all the connections and their names because otherwise we would need to introduce an dependency on cocoon-servlet-service-impl-1.3.0-SNAPSHOT. As soon as 1.2.1 is released this can be changed (see ServletServiceMonitor).
Apart from that I added the mount path to the bean name.

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dariusz Łuksza updated COCOON3-38:
----------------------------------

    Attachment: servlet-services-monitor2.patch

This patch replace all "service-servlet" typos into "servlet-service".

Additionally I've changed "brake" statements in class ServletServiceMonitorInitializer into log statement and "continue", IMHO that solution fits best, because we initialize monitoring service for all servlets that we can do not only for that, that are before first one that we can't initialize.

BTW. Maybe now we can change bean naming strategy from "<full servlet name> [<mount patch>]" into "<mount patch> [<full servlet name>]" ? IMHO it would be more readable for users.

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch, servlet-services-monitor2.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731693#action_12731693 ]

Reinhard Poetz commented on COCOON3-38:
---------------------------------------

The use of "break" was of course incorrect. I will also change the bean naming strategy as suggested by you.

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-optional
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch, servlet-services-monitor2.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz updated COCOON3-38:
----------------------------------

    Component/s:     (was: cocoon-optional)
                 cocoon-monitoring

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-monitoring
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch, servlet-services-monitor2.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/COCOON3-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reinhard Poetz closed COCOON3-38.
---------------------------------

    Resolution: Fixed

> Cocoon-monitoring base information about Servlet-Services
> ---------------------------------------------------------
>
>                 Key: COCOON3-38
>                 URL: https://issues.apache.org/jira/browse/COCOON3-38
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-monitoring
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Dariusz Łuksza
>            Assignee: Reinhard Poetz
>            Priority: Minor
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: cocoon-servlet-srvices-impl-connections.patch, servlet-services-doc.patch, servlet-services-doc1.patch, servlet-services-monitor.patch, servlet-services-monitor1.patch, servlet-services-monitor2.patch
>
>
> Add ability of sharing base information about Servlet-Services like points of mount or connections.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.