[jira] Created: (DERBY-4187) Convert altertable.sql to JUnit

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709737#action_12709737 ]

Eranda Sooriyabandara commented on DERBY-4187:
----------------------------------------------

Hi Bryan,
Wow it passes,Thanks. Can we move on to break test_altertable() in to
several methods or
are there something else remains to do with it?
Thanks,
Eranda

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709831#action_12709831 ]

Bryan Pendleton commented on DERBY-4187:
----------------------------------------

Yes, I agree: a good next step is to divide the single large test method into several smaller, more-focused
test methods, and group the tests into the test methods accordingly.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4187:
-----------------------------------------

    Attachment: AlterTableTest.diff

Hi Bryan,
I make some changes to the code in methods testWithSchema() and
testDropColumn()
It removes all the Failures in the code and there are 6 errors still there.
Here I attach the AlterTableTest.diff with this.
Thanks

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-4187:
-----------------------------------

    Attachment: AlterTableTest.java

Hi Eranda, I have attached a revised copy of AlterTableTest.java.

It contains a workaround for DERBY-4244, as well as several other
adjustments and tweaks to the tests. I think the test should be
passing now; can you confirm this in your environment?

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712448#action_12712448 ]

Eranda Sooriyabandara commented on DERBY-4187:
----------------------------------------------

Hi Bryan,
Thanks for your fixing. The test is also pass in my environment.
It's really great to see a bug free test.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4187:
-----------------------------------------

    Attachment: AlterTableTest.diff

Hi Bryan,
Here I attach the complete patch for your concern.
Thanks

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714773#action_12714773 ]

Bryan Pendleton commented on DERBY-4187:
----------------------------------------

Thanks Eranda! I will have a look at the patch as soon as possible.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-4187:
-----------------------------------

    Attachment: reformatPatch.diff

Hi Eranda,

I reformatted the patch somewhat to fix whitespace problems and
line length problems, and to make the patch easier to read.

Can you have a look at the latest patch ("reformatPatch.diff") and
let me know if you see any additional whitespace or formatting
problems that we need to clean up?

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton updated DERBY-4187:
-----------------------------------

    Attachment: svn_stat.txt
                removeFromOldSuite.diff

Attached patch 'removeFromOldSuite.diff' contains several additional
changes, to remove references to the old lang/altertable.sql from
README.htm, from suites/derbylang.runall, and to remove altertable.out.

My derbyall and junitreport runs were otherwise clean.

I'll make one more pass over the new test to proof read it and look
for additional whitespace and formatting cleanup prior to commit.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4187:
-----------------------------------------

    Attachment: AlterTableTest.diff

Hi Bryan,
I complete the comparing altertable.out and AlterTableTest and I found
some places where they do not match(asserting) but I think most of
them are doesn't wanted to test for alter table
functionalities.Except,

1)
in line 1378 and 1390 in testAlterColumn()
the underlying test was not there. I think they must be there to
confirm that column was renamed and constraint was there after the
renaming.
ij> describe renc_2;
COLUMN_NAME         |TYPE_NAME|DEC&|NUM&|COLUM&|COLUMN_DEF|CHAR_OCTE&|IS_NULL&
------------------------------------------------------------------------------
C2                  |INTEGER  |0   |10  |10    |NULL      |NULL      |NO
ij> show indexes from renc_2;
TABLE_NAME          |COLUMN_NAME         |NON_U&|TYPE|ASC&|CARDINA&|PAGES
----------------------------------------------------------------------------
RENC_2              |C2                  |false |3   |A   |NULL    |NULL

If you agree with me I can add the asserting test to the test or we
can leave it as it is now.
----------------------------------------------------------------------------------

2)
in line 2019 in testDropColumn() it says that

ij> -- Verify that a GRANTED privilege fails a drop column in RESTRICT mode,
-- and verify that the privilege is dropped in CASCADE mode:

but according to the test I found that

st.executeUpdate("alter table atdc_10 drop column b restrict");

So I change the comment to
        // Verify that a GRANTED privilege fails a drop column in
        // CASCADE mode, and verify that the privilege is dropped
        // in RESTRICT mode:
But here drop column in cascade mode is not tested. Please make a
comment that I am correct or not.
-------------------------------------------------------------------------------------

3)
At line 2461 and 2465 in testJira3355()

st.executeUpdate("create table d3355 ( c1 varchar(10), \"c2\" "
+"varchar(10), c3 varchar(10))");

According to the create table statement there is no column named "C3"
in the table d3355 but it passes as follows
st.executeUpdate("alter table d3355 alter column \"C3\" not null");

st.executeUpdate(" create table \"d3355_a\" ( c1 varchar(10), \"c2\" "
+"varchar(10), c3 varchar(10))");

According to the create table statement there is no column named "C3"
in the table "d3355_a" but it passes as follows
st.executeUpdate("alter table \"d3355_a\" alter column \"C3\" not null");

This is a contradictory behavior as I think.
-----------------------------------------------------------------------------------

Also I add some comment according to the altertable.out as I think its
appropriate.
I have gone through the full code and I didn't see any other mistakes
on the test.
And here I attach the patch file that I updated.

Thanks
Eranda

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723414#action_12723414 ]

Bryan Pendleton commented on DERBY-4187:
----------------------------------------

Hi Eranda, thanks for all the hard work on this test. I think it's starting to look really good.

Regarding the points you raised above, here's my opinion:
1) I think it would be a good idea to improve the verification of the contents of
the system catalogs for the column and the constraint, as you suggest. You
could have a look at the DatabaseMetadata API; I think it should have most of
what you need:
http://java.sun.com/j2se/1.4.2/docs/api/java/sql/DatabaseMetaData.html

2) The comment is incorrect here. ALTER TABLE DROP COLUMN does not
care whether or not there are granted privileges on the column, and the presence
of RESTRICT or CASCADE does not matter in this case. The Derby development
team discussed this back in 2006 and when I did the DERBY-1909 work, I should
have put a better comment in the test. Here's a pointer to the 2006 discussion:
https://issues.apache.org/jira/browse/DERBY-1489?focusedCommentId=12421187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12421187

So I think you should change the comment in the test program to something like:

  // ALTER TABLE DROP COLUMN automatically drops any granted privilege,
  // regardless of whether RESTRICT or CASCADE was specified. Verify that
  // the privileges are dropped correctly and that the bitmap is updated:

3) I think the test is fine here. I think the confusing part is that this part of the
test is verifying behavior of both lower-case and upper-case column names. If
a column or table name is not enclosed in quotation marks, then it is
automatically converted to upper case, so in fact the column C3 *does* exist,
even though the CREATE TABLE statement specified the column name c3
in lower case; it was automatically converted to upper case, and so this part
of the test appears to be working correctly to me.

I think that once we clean up these last few issues, we should be ready to
perform a final review and commit of this patch. Thanks again for all the hard work!

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4187:
-----------------------------------------

    Attachment: AlterTableTest.diff

Hi Bryan,
Here I am attaching the patch.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4187:
---------------------------------

    Issue Type: Improvement  (was: Test)

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4187:
-----------------------------------------

    Attachment: AlterTableTest.diff

Hi Bryan,
Here I attach the final patch.
Thanks
Eranda

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726077#action_12726077 ]

Bryan Pendleton commented on DERBY-4187:
----------------------------------------

Hi Eranda, thanks for the updated patch. I will have a look this weekend.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton resolved DERBY-4187.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 10.5.1.2)
                   10.6.0.0

The new test looks ready to me. My regression runs were clean. The new test is now run
as part of the lang._Suite in JUnit, and the old test is removed from derbylang. Everything
seems complete to me, so I've committed this patch to the trunk as revision 791027.

Eranda, thanks for all the hard work on this conversion. This was a large and complex
test, and was a tough one to start with; this is very good work. I'm looking forward to
some more test conversions this summer!

Please verify that the updated code in the trunk looks correct in your sandbox after
an 'svn update', and verify that you can build and run the new test from the trunk in
your environment, and then please mark this issue closed.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727152#action_12727152 ]

Eranda Sooriyabandara commented on DERBY-4187:
----------------------------------------------

Hi Bryan,All are perfectly ran on my environment.
Thanks Bryan, thanks for everything.
I am closing this issue.

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara closed DERBY-4187.
----------------------------------------

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.diff, AlterTableTest.java, AlterTableTest.java, AlterTableTest.java, reformatPatch.diff, removeFromOldSuite.diff, svn_stat.txt
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.