[jira] Created: (DERBY-4245) Sorting a table containing a CLOB fails after upgrade to 10.5

Sorting a table containing a CLOB fails after upgrade to 10.5
-------------------------------------------------------------

                 Key: DERBY-4245
                 URL: https://issues.apache.org/jira/browse/DERBY-4245
             Project: Derby
          Issue Type: Bug
          Components: Store
    Affects Versions: 10.5.1.1
            Reporter: Knut Anders Hatlen


When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.

Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-4245:
--------------------------------------

    Attachment: MixedVersionClob.java

To reproduce:

1) Run the attached class with Derby 10.4.2.0 to create the database

2) Open the database in ij with Derby 10.5.1.1 and issue a select with an ORDER BY:

ij version 10.5
ij> connect 'jdbc:derby:db';
ij> select c from t order by length(c);
ERROR XJ001: Java exception: ': java.lang.NullPointerException'.
ij>

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>         Attachments: MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan reassigned DERBY-4245:
--------------------------------------

    Assignee: Kristian Waagan

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>         Attachments: MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Attachment: derby-4245-0a-preview.diff

Patch 0a is a preview patch.
I found two problems when investigating the bug;
 - SQLClob incorrectly assumes that the instance variable SQLChar.stream always reference the passed in stream to readExternal.
    This is just wrong, and is what causes the NPE.
 - LimitInputStream does not support mark/reset.

In the case of LimitInputStream, the underlying BufferedInputStream supports mark/reset. In this cause we read 5 bytes, resets and skips two bytes. This causes the limit stream to believe it can only deliver 59998 bytes, whereas the correct number is 60003 (full length minus header length). The five bytes involved in the mark/reset are "lost".

I'm not yet sure how to handle mark/reset with the limit reader.
I plan to address the problems in SQLClob under this issue, and create a sub-issue for the limit stream.

The repro passes with the preview patch, and because mark/reset isn't used much it may also pass the regression tests (the fix for LimitInputStream is broken).
I'm starting the regression tests now, will report back with the results.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>         Attachments: derby-4245-0a-preview.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713297#action_12713297 ]

Kristian Waagan commented on DERBY-4245:
----------------------------------------

The regression tests passed, but that does *not* mean the patch is ready for commit :)

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>         Attachments: derby-4245-0a-preview.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714806#action_12714806 ]

Knut Anders Hatlen commented on DERBY-4245:
-------------------------------------------

It doesn't look like the upgrade step is necessary in order to reproduce this issue. I also see the NPE when I create the database with trunk. The preview patch appears to fix it.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>         Attachments: derby-4245-0a-preview.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Fix Version/s: 10.5.1.2

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2
>
>         Attachments: derby-4245-0a-preview.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Attachment: derby-4245-1a-test.diff

Patch 1a contains a test for this issue.
The test has not been enabled. On my system it takes around 130 seconds, where around half of the time is spent inserting test data. I'll see if I can reduce the number of rows inserted further.

Patch ready for review.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Derby Info: [Patch Available, Regression]  (was: [Regression])

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718103#action_12718103 ]

Knut Anders Hatlen commented on DERBY-4245:
-------------------------------------------

Would it make sense to include the seed in the test name by overriding getName() and make it return super.getName() + SEED? Then we don't need to intercept all exceptions manually in order to report the seed.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Attachment: derby-4245-2a-sqlclob_fix.diff
                derby-4245-1b-test.diff

It makes sense, as it makes the code cleaner. Is patch 1b along the lines you were thinking of?

I also attached patch 2a, which fixes the problems in SQLClob. When applying it, the bug should no longer reproduce with a clean database. The bug will still occur with upgraded databases.
Patch 2a passes the regression tests.

Patches ready for review.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-2a-sqlclob_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718415#action_12718415 ]

Knut Anders Hatlen commented on DERBY-4245:
-------------------------------------------

Thanks. 1b looks good and I've verified that it fails without the 2a patch and passes with it. You may also want to change the calls to fail() in fetchIterateGetLengthBlob/fetchIterateGetLengthBlob to assertEquals() now that the seed is part of the name.

The changes in 2a also look fine to me. +1 to commit.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-2a-sqlclob_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

       Derby Info: [Regression]  (was: [Regression, Patch Available])
    Fix Version/s: 10.6.0.0

Committed patch 2a to trunk with revision 784701.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-2a-sqlclob_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Attachment: derby-4245-3a-unread_bytes_fix.diff

Patch 3a is the first revision of a fix for the issue seen for upgraded databases.
The regression tests passed.

Before I commit this I need to see if I understand exactly why the failure occurred. Specifically, I have to verify my own claim about the BufferedInputStream. It may be that there shouldn't be a buffered stream here. This won't affect the problem with LimitInputStream and mark/reset, but it may be an issue worth fixing anyway. I don't think there is a reason to buffer streams serving bytes from the pages in the page cache.

Patch ready for initial review.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Attachment: derby-4245-1c-test.diff

Thank you for the feedback, Knut Anders.

Attached and committed patch 1c to trunk with revision 785104. The test is not yet enabled.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-1c-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Derby Info: [Patch Available, Regression]  (was: [Regression])

Fixed two spelling errors in the test with revision 785105.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-1c-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720087#action_12720087 ]

Kristian Waagan commented on DERBY-4245:
----------------------------------------

Code inspection shows that getting a BufferedInputStream in this case is correct. It comes from StreamFileContainer.open, and the source is a file. The merge sort (MergeSort.openSortScan) uses stream containers.
The default buffer size is 16 KB (RawStoreFactory.STREAM_FILE_BUFFER_SIZE_DEFAULT).

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-1c-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721147#action_12721147 ]

Knut Anders Hatlen commented on DERBY-4245:
-------------------------------------------

> On my system it takes around 130 seconds, where around half of the time is spent inserting test data. I'll see if I can reduce the number of rows inserted further.

I think if you lower derby.storage.sortBufferMax, you'll see the bug with less rows in the table.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-1c-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4245:
-----------------------------------

    Attachment: derby-4245-4a-adjust_sort_buffer_test.diff

Thanks for the tip, Knut.

Patch 4a lowers the sort buffer. Although the lowered sort buffer size makes it possible to run with even fewer rows, I chose to keep it as high as it is (100 rows) due to the randomness in the test and because lowering it further didn't make the test runs that much faster.

Committed patch 4a to trunk with revision 790162.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-1c-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, derby-4245-4a-adjust_sort_buffer_test.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-4245:
---------------------------------

    Issue & fix info: [Patch Available, Repro attached]  (was: [Patch Available])
             Urgency: Urgent

Triaged for 10.5.2, "repro attached" and setting "urgent" urgency.

> Sorting a table containing a CLOB fails after upgrade to 10.5
> -------------------------------------------------------------
>
>                 Key: DERBY-4245
>                 URL: https://issues.apache.org/jira/browse/DERBY-4245
>             Project: Derby
>          Issue Type: Bug
>          Components: Store
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>             Fix For: 10.5.1.2, 10.6.0.0
>
>         Attachments: derby-4245-0a-preview.diff, derby-4245-1a-test.diff, derby-4245-1b-test.diff, derby-4245-1c-test.diff, derby-4245-2a-sqlclob_fix.diff, derby-4245-3a-unread_bytes_fix.diff, derby-4245-4a-adjust_sort_buffer_test.diff, MixedVersionClob.java
>
>
> When sorting a table containing a CLOB column in a database that has been soft-upgraded from 10.4.2.0 to 10.5.1.1, the query fails with a NullPointerException.
> Reported on derby-user: http://mail-archives.apache.org/mod_mbox/db-derby-user/200905.mbox/%3ckk5ivy.tcwvy@...%3e

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.