[jira] Created: (DERBY-4423) Convert dropTable.sql into JUnit

Convert dropTable.sql into JUnit
--------------------------------

                 Key: DERBY-4423
                 URL: https://issues.apache.org/jira/browse/DERBY-4423
             Project: Derby
          Issue Type: Improvement
            Reporter: Eranda Sooriyabandara
            Assignee: Eranda Sooriyabandara
            Priority: Minor
             Fix For: 10.6.0.0


Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4423:
-----------------------------------------

    Attachment: DropTableTest.diff

Hi,
Here I am attaching the patch(not the final patch) of debugged version of
the DropTableTest test.
I am hoping to break the test into several methods.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769828#action_12769828 ]

Bryan Pendleton commented on DERBY-4423:
----------------------------------------

Hi Eranda, It's nice to see you back working with Derby!

It looks like you are making great progress. I agree that the test would benefit
from being subdivided into smaller methods.

Also, don't forget to add the test to _Suite.java so that it will be run as
part of the overall derbylang JUnit suite.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773478#action_12773478 ]

Eranda Sooriyabandara commented on DERBY-4423:
----------------------------------------------

Hi Bryan,
Thanks for looking at the test and make me correct.

In this patch I break the test into several methods,
testWithConstraints()
testWithTriggers()
testWithPreparedStatement()
testWithView()
testDropView()
testIndexesDropped()

Also I compared it with the DropTable.out file for any missing tests. I
found that there are some repeated tests and I removed them. I think now the
test can be committed as a patch. Please let me know your view about this.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773496#action_12773496 ]

Bryan Pendleton commented on DERBY-4423:
----------------------------------------

Hi Eranda, thanks for working on this test.

I don't see the latest attachment, only the 24-Oct attachment.

Can you check and re-attach your latest patch?

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara updated DERBY-4423:
-----------------------------------------

    Attachment: DropTableTest.diff

Hi Bryan,
Here is the final patch.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff, DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773556#action_12773556 ]

Bryan Pendleton commented on DERBY-4423:
----------------------------------------

Thanks Eranda, this looks great! I'll look into committing this soon.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff, DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton resolved DERBY-4423.
------------------------------------

    Resolution: Fixed

The new test runs successfully for me, so I committed it to the subversion
trunk as revision 833055.

Thanks for contributing the test, Eranda; it is clear and easy to read.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff, DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773967#action_12773967 ]

Eranda Sooriyabandara commented on DERBY-4423:
----------------------------------------------

Hi Bryan,
Thanks for committing the test.
I am closing this issue.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff, DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eranda Sooriyabandara closed DERBY-4423.
----------------------------------------

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff, DropTableTest.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-4423:
--------------------------------------

    Attachment: helpers.diff

I took the liberty of simplifying the new test slightly (see attached
patch helpers.diff):

  - use more helper methods from BaseJDBCTestCase

  - changed instance variables into local variables to allow garbage
    collection to reclaim space when the test has completed

Committed revision 835114.

> Convert dropTable.sql into JUnit
> --------------------------------
>
>                 Key: DERBY-4423
>                 URL: https://issues.apache.org/jira/browse/DERBY-4423
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: DropTableTest.diff, DropTableTest.diff, helpers.diff
>
>
> Conversion of the dropTable test into JUnit

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.