[jira] Created: (DERBY-4436) Refactor existing in-memory back end tests and add new tests for dropping database

Refactor existing in-memory back end tests and add new tests for dropping database
----------------------------------------------------------------------------------

                 Key: DERBY-4436
                 URL: https://issues.apache.org/jira/browse/DERBY-4436
             Project: Derby
          Issue Type: Sub-task
          Components: Test
    Affects Versions: 10.6.0.0
            Reporter: Kristian Waagan
            Assignee: Kristian Waagan


To make it easier to write new in-memory back end tests, a class with a few convenience methods would be helpful.
I will add such a class, rewrite existing tests to use it (where appropriate) and finally add some new tests for dropping in-memory databases.

The tests will be disabled until the drop mechanism is implemented.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4436:
-----------------------------------

    Issue & fix info: [Patch Available]

> Refactor existing in-memory back end tests and add new tests for dropping database
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-4436
>                 URL: https://issues.apache.org/jira/browse/DERBY-4436
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>         Attachments: derby-4436-1a-inmem_test_changes.diff, derby-4436-1a-inmem_test_changes.stat
>
>
> To make it easier to write new in-memory back end tests, a class with a few convenience methods would be helpful.
> I will add such a class, rewrite existing tests to use it (where appropriate) and finally add some new tests for dropping in-memory databases.
> The tests will be disabled until the drop mechanism is implemented.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4436:
-----------------------------------

    Attachment: derby-4436-1a-inmem_test_changes.stat
                derby-4436-1a-inmem_test_changes.diff

Attaching version 1a of the patch.

Patch description:
* Added MemoryDbManager
  Contains convenience methods for working with in-memory databases. Reimplements some of the same functionality provided by BaseJDBCTestCase / TestConfiguration.
  Note that the deleteDatabase method has been short-circuited for the time being, until the drop mechanism has been implemented.
 
* Changed BasicInMemoryDbTest
  Adjusted the class to use the new MemorDbManager.
  Added a few more tests, some of which have been disabled for now (awaiting drop).

* Changed MogTest
  Adjusted the class to use the new MemorDbManager.

* Added DropWhileConnectingTest
  New multi threaded test for testing what happens when a lot of connections are connecting or  executing against a database being dropped.
  Must await the drop functionality before it can be used, and I don't know if this should be part of the regression test suite or not.
  Can be tweaked with derby.tests.[[noWait=true|false][threadCount=thread#]]
  Using this test I have been able to verify that a access block feature I have prototyped has value (see post on derby-dev regarding this feature).


Patch ready for review.

> Refactor existing in-memory back end tests and add new tests for dropping database
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-4436
>                 URL: https://issues.apache.org/jira/browse/DERBY-4436
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>         Attachments: derby-4436-1a-inmem_test_changes.diff, derby-4436-1a-inmem_test_changes.stat
>
>
> To make it easier to write new in-memory back end tests, a class with a few convenience methods would be helpful.
> I will add such a class, rewrite existing tests to use it (where appropriate) and finally add some new tests for dropping in-memory databases.
> The tests will be disabled until the drop mechanism is implemented.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4436:
-----------------------------------

    Attachment: derby-4436-1b-inmem_test_changes.diff

Attached patch 1b, and committed it to trunk with revision 835334.

I expect that most of the work for this issue has been done with patch 1b, but some adjustments must be made when the drop database functionality has been added.
To ensure things get done:
 - remove short-circuiting from MemoryDbManager.dropDatabase.
 - enable tests in BasicInMemoryDbTest
 - remove disabled method call in MogTest
 - potentially add DropWhileConnectingTest to the suite

I'll keep this issue open until the above items have been taken care of.

> Refactor existing in-memory back end tests and add new tests for dropping database
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-4436
>                 URL: https://issues.apache.org/jira/browse/DERBY-4436
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.6.0.0
>
>         Attachments: derby-4436-1a-inmem_test_changes.diff, derby-4436-1a-inmem_test_changes.stat, derby-4436-1b-inmem_test_changes.diff
>
>
> To make it easier to write new in-memory back end tests, a class with a few convenience methods would be helpful.
> I will add such a class, rewrite existing tests to use it (where appropriate) and finally add some new tests for dropping in-memory databases.
> The tests will be disabled until the drop mechanism is implemented.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DERBY-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4436:
-----------------------------------

    Issue & fix info:   (was: [Patch Available])
       Fix Version/s: 10.6.0.0

> Refactor existing in-memory back end tests and add new tests for dropping database
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-4436
>                 URL: https://issues.apache.org/jira/browse/DERBY-4436
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.6.0.0
>
>         Attachments: derby-4436-1a-inmem_test_changes.diff, derby-4436-1a-inmem_test_changes.stat, derby-4436-1b-inmem_test_changes.diff
>
>
> To make it easier to write new in-memory back end tests, a class with a few convenience methods would be helpful.
> I will add such a class, rewrite existing tests to use it (where appropriate) and finally add some new tests for dropping in-memory databases.
> The tests will be disabled until the drop mechanism is implemented.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DERBY-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782882#action_12782882 ]

Kristian Waagan commented on DERBY-4436:
----------------------------------------

The items above got addressed by patch 2b under DERBY-4428.

I'm not sure if DropWhileConnectingTest should be wired in to the suite yet, although it would be good to run the test on a variety of machines / platforms. I'll reconsider test more and reconsider when the access block mechanism is in place.

> Refactor existing in-memory back end tests and add new tests for dropping database
> ----------------------------------------------------------------------------------
>
>                 Key: DERBY-4436
>                 URL: https://issues.apache.org/jira/browse/DERBY-4436
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.6.0.0
>
>         Attachments: derby-4436-1a-inmem_test_changes.diff, derby-4436-1a-inmem_test_changes.stat, derby-4436-1b-inmem_test_changes.diff
>
>
> To make it easier to write new in-memory back end tests, a class with a few convenience methods would be helpful.
> I will add such a class, rewrite existing tests to use it (where appropriate) and finally add some new tests for dropping in-memory databases.
> The tests will be disabled until the drop mechanism is implemented.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.