[jira] Created: (DIRSERVER-1262) Add a Jetty container

Add a Jetty container
---------------------

                 Key: DIRSERVER-1262
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
             Project: Directory ApacheDS
          Issue Type: New Feature
    Affects Versions: 1.5.4
            Reporter: Emmanuel Lecharny
             Fix For: 1.5.5


Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641782#action_12641782 ]

Felix Knecht commented on DIRSERVER-1262:
-----------------------------------------

Would this be someting quite similar to the embedded ApacheDS as Web Application [1] recently updated by Stefan?

[1] http://cwiki.apache.org/confluence/display/DIRxSRVx11/Embedding+ApacheDS+as+a+Web+Application

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641881#action_12641881 ]

Emmanuel Lecharny commented on DIRSERVER-1262:
----------------------------------------------

No, it's about adding Jetty into ADS to accept Http request without having to depend on another web server. This is quite interesting if you want to expose some administrative information using some kind of webb app, or even better, implement a DSML gateway inside the server.

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari updated DIRSERVER-1262:
--------------------------------------

    Attachment: jetty-embedded.patch

Here is a patch which has the required modifications to embed jetty. Please run the patch from inside the 'apacheds' module. Edit the configuration file server.xml before starting the server. If this looks good will commit the code.

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>         Attachments: jetty-embedded.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari updated DIRSERVER-1262:
--------------------------------------

    Attachment: http-integration.patch

Here is the patch(file name http-integration.patch) for proposed jetty http server integration with ADS.
The approach taken for integration is as follows

   1. A new module http-integration was created with a class HttpServer to start and stop jetty server
   2. Updated xbean-spring module and added new <httpServer> bean(disabled in the default conf) to server.xml

 However I have a question.

 IMO a default jetty configuration should be present with a pre-created webapps folder in which a user can deploy
 the wars. this makes things slightly complex (e.x how do we decide where to keep the webapps folder and how do
 we find this location on restart etc..)

 is this a right thing to do? or is it better to let the user configure by providing the jetty conf File (which can be set
 through 'confFile' attribute of httpServer)

 Note: Apply this patch from <ads-trunk-with-deps>/apacheds folder

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>         Attachments: http-integration.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari updated DIRSERVER-1262:
--------------------------------------

    Attachment:     (was: jetty-embedded.patch)

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>         Attachments: http-integration.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari updated DIRSERVER-1262:
--------------------------------------

    Attachment: http-integration-updated.patch

Updated the patch with sources missed in the previous patch. This can be applied directly from the trunk source folder <ads-trunk-with-deps> directly.

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch, http-integration.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari updated DIRSERVER-1262:
--------------------------------------

    Attachment:     (was: http-integration.patch)

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725155#action_12725155 ]

Jeff MAURY commented on DIRSERVER-1262:
---------------------------------------

My feeling is that the HttpServer should have two properties: one for the location of the Jetty configuration file, and one for the location of the webapps folder (this may be a collection btw). If no location is provided for the Jetty configuration file, the default one provided by Jetty should be used. The idea is that is will be clearer if the webapps are injected through server.xml rather that jetty.conf.

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari reassigned DIRSERVER-1262:
-----------------------------------------

    Assignee: Kiran Ayyagari

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Assignee: Kiran Ayyagari
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738110#action_12738110 ]

Kiran Ayyagari commented on DIRSERVER-1262:
-------------------------------------------

Committed the code ( http://svn.apache.org/viewvc?rev=800123&view=rev ). Now this integrated server can take either a full fledged jetty configuration file OR a set of web apps can be configured in the server.xml.

Note that if conf file is provided webapps configured in the server.xml will be ignored.
If neither conf file nor web apps are configured then the server won't be started.

There is a port option too, but will only be taken into account if web apps are configured in the server.xml

Jeff, can you give it a try :)

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Assignee: Kiran Ayyagari
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari closed DIRSERVER-1262.
-------------------------------------

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Assignee: Kiran Ayyagari
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSERVER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Ayyagari resolved DIRSERVER-1262.
---------------------------------------

    Resolution: Fixed

Jetty has been integrated with the server and should be available from version 1.5.5

> Add a Jetty container
> ---------------------
>
>                 Key: DIRSERVER-1262
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1262
>             Project: Directory ApacheDS
>          Issue Type: New Feature
>    Affects Versions: 1.5.4
>            Reporter: Emmanuel Lecharny
>            Assignee: Kiran Ayyagari
>             Fix For: 1.5.5
>
>         Attachments: http-integration-updated.patch
>
>
> Add a jetty container into ADS

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.