[jira] Created: (DIRSTUDIO-574) Abort of copy/paste not possile

Abort of copy/paste not possile
-------------------------------

                 Key: DIRSTUDIO-574
                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
             Project: Directory Studio
          Issue Type: Bug
          Components: studio-ldapbrowser
         Environment: All
            Reporter: Felix Knecht


It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.

Reproduce:
- Open the LDAP Browser view
- Select an entry (Copy Entry / DN)
- Try to paste it to the parent of the selected entry

You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated DIRSTUDIO-574:
-----------------------------------

    Summary: Abort of copy/paste not possible  (was: Abort of copy/paste not possile)

> Abort of copy/paste not possible
> --------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Bug
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769283#action_12769283 ]

Stefan Seelmann commented on DIRSTUDIO-574:
-------------------------------------------

The first option "Stop copy process" does what you want. But I must admit that isn't very intuitive. At least when closing the box "stop" should be the default behaviour and no error should occur.

> Abort of copy/paste not possible
> --------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Bug
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated DIRSTUDIO-574:
-----------------------------------

      Priority: Minor  (was: Major)
    Issue Type: Improvement  (was: Bug)
       Summary: Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)  (was: Abort of copy/paste not possible)

Thanks Stefan for explanation.

It's indeed not that intuitive, at least it wasn't for me ;-)
Therefore changing the issue to type "Improvement"

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Priority: Minor
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769387#action_12769387 ]

Felix Knecht commented on DIRSTUDIO-574:
----------------------------------------

But even using "Stop copy process" I get following Modification Logs:

#!RESULT ERROR
#!CONNECTION ldap://ldap.felixknecht.ch:389
#!DATE 2009-10-23T21:49:39.683
#!ERROR [LDAP: error code 68 - Entry Already Exists]
dn: cn=foo.bar,ou=Hosts,dc=foo,dc=ch
changetype: add
ipHostNumber: 192.168.xxx.xxx
objectClass: ipHost
objectClass: top
objectClass: device
cn: foo.bar

and I see splashing the error box, but disappearing immediately again ...

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Priority: Minor
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769408#action_12769408 ]

Felix Knecht commented on DIRSTUDIO-574:
----------------------------------------

Patch to add Cancel button and fix closing window. This doesn't fix the problem of getting an error as log entry.

I don't commit the patch because releasing studio 1.5 is in progress.

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Priority: Minor
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated DIRSTUDIO-574:
-----------------------------------

    Attachment: patch_cancel_close.txt

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Priority: Minor
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht closed DIRSTUDIO-574.
----------------------------------

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht resolved DIRSTUDIO-574.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0
         Assignee: Felix Knecht

Patch applied

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seelmann reopened DIRSTUDIO-574:
---------------------------------------


Now EntryExistsCopyStrategy.BREAK is also used when selecting another strategy and pressing the OK button, because the close() method is called whenever the dialogs is closed.

I'd suggest to remove the close() method and set EntryExistsCopyStrategy.BREAK as default in the constructor. In that case the cancelPressed() method is also not necessary.

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770012#action_12770012 ]

Felix Knecht commented on DIRSTUDIO-574:
----------------------------------------

Autsch, I didn't tested enough :-(, thanks for pointing.

I hope it's working now like expected.

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seelmann resolved DIRSTUDIO-574.
---------------------------------------

    Resolution: Fixed

Just perfect :-)

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/DIRSTUDIO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre-Arnaud Marcelot closed DIRSTUDIO-574.
--------------------------------------------


Apache Directory Studio version 1.5.0 has been released.

> Add 'Cancel' button to "Select copy strategy"  (was Abort of copy/paste not possible)
> -------------------------------------------------------------------------------------
>
>                 Key: DIRSTUDIO-574
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-574
>             Project: Directory Studio
>          Issue Type: Improvement
>          Components: studio-ldapbrowser
>         Environment: All
>            Reporter: Felix Knecht
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: patch_cancel_close.txt
>
>
> It's not possible to cancel to process once you selected once you selected 'Paste Entry'. It produces an error.
> Reproduce:
> - Open the LDAP Browser view
> - Select an entry (Copy Entry / DN)
> - Try to paste it to the parent of the selected entry
> You get the "Select copy strategy" box, which contains only an "OK" button. Even when I try to close the box I get an error box, saying that the entry already exists (LDAP: error code 68)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.