[jira] Created: (FELIX-1848) Include instance name in the JMX ObjectName for AdminService and FeaturesService MBeans

Include instance name in the JMX ObjectName for AdminService and FeaturesService MBeans
---------------------------------------------------------------------------------------

                 Key: FELIX-1848
                 URL: https://issues.apache.org/jira/browse/FELIX-1848
             Project: Felix
          Issue Type: Task
          Components: Karaf
    Affects Versions: karaf-1.0.2
            Reporter: Eoghan Glynn
             Fix For: karaf-1.2.0


Currently its awkward to map from the ObjectName of the AdminService & FeaturesService MBeans to the hosting instance name.

This information should be embedded in the ObjectNames, so for example "org.apache.felix.karaf:service=admin" should be replaced by "org.apache.felix.karaf:type=admin,name=<instance>" where <instance> is the current instance name (or "root" for a non-child instance).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/FELIX-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eoghan Glynn updated FELIX-1848:
--------------------------------

    Attachment: felix_1848.patch

Can some committer review the attached patch and apply if kosher?

BTW the reason I didn't take the obvious approach and use the PropertyPlaceholderConfigurer instead of manually sub'ing the system property into the JMX ObjectName, was to avoid pulling spring into the boot features.

> Include instance name in the JMX ObjectName for AdminService and FeaturesService MBeans
> ---------------------------------------------------------------------------------------
>
>                 Key: FELIX-1848
>                 URL: https://issues.apache.org/jira/browse/FELIX-1848
>             Project: Felix
>          Issue Type: Task
>          Components: Karaf
>    Affects Versions: karaf-1.0.2
>            Reporter: Eoghan Glynn
>             Fix For: karaf-1.2.0
>
>         Attachments: felix_1848.patch
>
>
> Currently its awkward to map from the ObjectName of the AdminService & FeaturesService MBeans to the hosting instance name.
> This information should be embedded in the ObjectNames, so for example "org.apache.felix.karaf:service=admin" should be replaced by "org.apache.felix.karaf:type=admin,name=<instance>" where <instance> is the current instance name (or "root" for a non-child instance).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/FELIX-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine reassigned FELIX-1848:
------------------------------------

    Assignee: Chris Custine

> Include instance name in the JMX ObjectName for AdminService and FeaturesService MBeans
> ---------------------------------------------------------------------------------------
>
>                 Key: FELIX-1848
>                 URL: https://issues.apache.org/jira/browse/FELIX-1848
>             Project: Felix
>          Issue Type: Task
>          Components: Karaf
>    Affects Versions: karaf-1.0.2
>            Reporter: Eoghan Glynn
>            Assignee: Chris Custine
>             Fix For: karaf-1.2.0
>
>         Attachments: felix_1848.patch
>
>
> Currently its awkward to map from the ObjectName of the AdminService & FeaturesService MBeans to the hosting instance name.
> This information should be embedded in the ObjectNames, so for example "org.apache.felix.karaf:service=admin" should be replaced by "org.apache.felix.karaf:type=admin,name=<instance>" where <instance> is the current instance name (or "root" for a non-child instance).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/FELIX-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Custine resolved FELIX-1848.
----------------------------------

    Resolution: Fixed

> Include instance name in the JMX ObjectName for AdminService and FeaturesService MBeans
> ---------------------------------------------------------------------------------------
>
>                 Key: FELIX-1848
>                 URL: https://issues.apache.org/jira/browse/FELIX-1848
>             Project: Felix
>          Issue Type: Task
>          Components: Karaf
>    Affects Versions: karaf-1.0.2
>            Reporter: Eoghan Glynn
>            Assignee: Chris Custine
>             Fix For: karaf-1.2.0
>
>         Attachments: felix_1848.patch
>
>
> Currently its awkward to map from the ObjectName of the AdminService & FeaturesService MBeans to the hosting instance name.
> This information should be embedded in the ObjectNames, so for example "org.apache.felix.karaf:service=admin" should be replaced by "org.apache.felix.karaf:type=admin,name=<instance>" where <instance> is the current instance name (or "root" for a non-child instance).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/FELIX-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776071#action_12776071 ]

Chris Custine commented on FELIX-1848:
--------------------------------------

Patch applied, thanks to Eoghan Glynn.

> Include instance name in the JMX ObjectName for AdminService and FeaturesService MBeans
> ---------------------------------------------------------------------------------------
>
>                 Key: FELIX-1848
>                 URL: https://issues.apache.org/jira/browse/FELIX-1848
>             Project: Felix
>          Issue Type: Task
>          Components: Karaf
>    Affects Versions: karaf-1.0.2
>            Reporter: Eoghan Glynn
>            Assignee: Chris Custine
>             Fix For: karaf-1.2.0
>
>         Attachments: felix_1848.patch
>
>
> Currently its awkward to map from the ObjectName of the AdminService & FeaturesService MBeans to the hosting instance name.
> This information should be embedded in the ObjectNames, so for example "org.apache.felix.karaf:service=admin" should be replaced by "org.apache.felix.karaf:type=admin,name=<instance>" where <instance> is the current instance name (or "root" for a non-child instance).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.