[jira] Created: (GERONIMO-4532) Port the GERONIMO-4484 patch for V2.1

    [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711013#action_12711013 ]

Kan Ogawa commented on GERONIMO-4532:
-------------------------------------

Hi,

All needed patches have been posted. Please help to review and commit them.

(!) NOTE
Chinese resource bundles (_zh.properties) are *NOT* contained in my posted patches.
Would you write Chinese translations for them?

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Ogawa updated GERONIMO-4532:
--------------------------------

    Attachment:     (was: plugin-portlets.patch)

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Ogawa updated GERONIMO-4532:
--------------------------------

    Attachment:     (was: console-portal-driver.patch)

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Ogawa updated GERONIMO-4532:
--------------------------------

    Attachment:     (was: sysdb-portlets.patch)

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Ogawa updated GERONIMO-4532:
--------------------------------

    Attachment: sysdb-portlets.patch
                plugin-portlets.patch
                console-portal-driver.patch

Thanks Higuchi-san for your review!

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715371#action_12715371 ]

Kan Ogawa commented on GERONIMO-4532:
-------------------------------------

Hi committers,

I will create an issue, which is Japanese initial translations of admin console, as new feature before long.
When would you commit the posted patches to branches/2.1?

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods reassigned GERONIMO-4532:
--------------------------------------

    Assignee: Donald Woods  (was: Kan Ogawa)

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Donald Woods
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715586#action_12715586 ]

Donald Woods commented on GERONIMO-4532:
----------------------------------------

Committed as Rev781081.
Also updated the following testsuite files due to message text changes:
testsuite/console-testsuite/advanced/src/test/java/org/apache/geronimo/testsuite/console/DBManagerTest.java
testsuite/console-testsuite/advanced/src/test/java/org/apache/geronimo/testsuite/console/DeploymentTest.java
testsuite/console-testsuite/advanced/src/test/java/org/apache/geronimo/testsuite/console/DatabasePoolTest.java

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Donald Woods
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods reassigned GERONIMO-4532:
--------------------------------------

    Assignee: Kan Ogawa  (was: Donald Woods)

Please review the commit and close if everything looks okay.

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Ogawa updated GERONIMO-4532:
--------------------------------

    Attachment: mconsole-war_2nd.patch

Donald,

A mistake was found in the monitoring porlet, which is that it cannot successfully enable the registed server.
I submit the 2nd patch to fix this, so please review and commit it.

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, mconsole-war_2nd.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728818#action_12728818 ]

Jarek Gawor commented on GERONIMO-4532:
---------------------------------------

I committed the "mconsole-war_2nd.patch" patch to branches/2.1 (revision 792240). Thanks!

Is there anything else that needs to be done for this bug or can it be closed?

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, mconsole-war_2nd.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Ogawa closed GERONIMO-4532.
-------------------------------

    Resolution: Fixed

Thanks a lot, Jarek!

The regression bug that I found is a monitoring console mistake only.

Closing this issue once.
Unless new mistake is found, please don't reopen it.

> Port the GERONIMO-4484 patch for V2.1
> -------------------------------------
>
>                 Key: GERONIMO-4532
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4532
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4
>            Reporter: Kan Ogawa
>            Assignee: Kan Ogawa
>            Priority: Minor
>             Fix For: 2.1.5
>
>         Attachments: activemq-portlets.patch, console-base-portlets.patch, console-core.patch, console-portal-driver.patch, debugviews-portlets.patch, mconsole-war.patch, mconsole-war_2nd.patch, plancreator-portlets.patch, plugin-portlets.patch, sysdb-portlets.patch
>
>
> I think that this issue is very important.
> After the GERONIMO-4485 patches are committed, I will try to port GERONIMO-4484 patches for 2.1 version.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.