|

»

»

Apache Geronimo - Dev

[jira] Created: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error

View: New views

6 Messages — Rating Filter: Alert me

	[jira] Created: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message Default "headerBufferSizeBytes" 8192 is causing connector creating error ------------------------------------------------------------------------ Key: GERONIMO-4720 URL: https://issues.apache.org/jira/browse/GERONIMO-4720 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: Jetty Affects Versions: 2.2 Environment: latest Jetty 7 trunk build +sun jdk 6 Reporter: Shawn Jiang Assignee: Shawn Jiang Currently, the Default "headerBufferSizeBytes" size is 8192. In org.apache.geronimo.jetty7.connector.JettyConnector {code} public void setHeaderBufferSizeBytes(int size) { //TODO see https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843 if (size == listener.getRequestBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the request buffer size: " + listener.getRequestBufferSize()); if (size == listener.getResponseBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the response buffer size: " + listener.getResponseBufferSize()); listener.setRequestHeaderSize(size); listener.setResponseHeaderSize(size); } {code} So that size == listener.getRequestBufferSize() will always be true. Which will cause IllegalArgumentException when creating Jetty connectors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Updated: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/GERONIMO-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Jiang updated GERONIMO-4720: ---------------------------------- Attachment: G4720.patch The patch to change the default "headerBufferSizeBytes" from 8192 to 8193 > Default "headerBufferSizeBytes" 8192 is causing connector creating error > ------------------------------------------------------------------------ > > Key: GERONIMO-4720 > URL: https://issues.apache.org/jira/browse/GERONIMO-4720 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: Jetty > Affects Versions: 2.2 > Environment: latest Jetty 7 trunk build +sun jdk 6 > Reporter: Shawn Jiang > Assignee: Shawn Jiang > Attachments: G4720.patch > > > Currently, the Default "headerBufferSizeBytes" size is 8192. > In org.apache.geronimo.jetty7.connector.JettyConnector > {code} > public void setHeaderBufferSizeBytes(int size) { > //TODO see https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843 > if (size == listener.getRequestBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the request buffer size: " + listener.getRequestBufferSize()); > if (size == listener.getResponseBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the response buffer size: " + listener.getResponseBufferSize()); > listener.setRequestHeaderSize(size); > listener.setResponseHeaderSize(size); > } > {code} > So that size == listener.getRequestBufferSize() will always be true. Which will cause IllegalArgumentException when creating Jetty connectors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/GERONIMO-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725428#action_12725428 ] Shawn Jiang commented on GERONIMO-4720: --------------------------------------- This defect also prevents console-testsuite/advanced from passing. > Default "headerBufferSizeBytes" 8192 is causing connector creating error > ------------------------------------------------------------------------ > > Key: GERONIMO-4720 > URL: https://issues.apache.org/jira/browse/GERONIMO-4720 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: Jetty > Affects Versions: 2.2 > Environment: latest Jetty 7 trunk build +sun jdk 6 > Reporter: Shawn Jiang > Assignee: Shawn Jiang > Attachments: G4720.patch > > > Currently, the Default "headerBufferSizeBytes" size is 8192. > In org.apache.geronimo.jetty7.connector.JettyConnector > {code} > public void setHeaderBufferSizeBytes(int size) { > //TODO see https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843 > if (size == listener.getRequestBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the request buffer size: " + listener.getRequestBufferSize()); > if (size == listener.getResponseBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the response buffer size: " + listener.getResponseBufferSize()); > listener.setRequestHeaderSize(size); > listener.setResponseHeaderSize(size); > } > {code} > So that size == listener.getRequestBufferSize() will always be true. Which will cause IllegalArgumentException when creating Jetty connectors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/GERONIMO-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725429#action_12725429 ] Shawn Jiang commented on GERONIMO-4720: --------------------------------------- Besides the patch above, We might want to to notify user it's not permitted when the user input 8192 for "headerBufferSizeBytes". But per https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843, this is a known Jetty bug so that it could be fixed in future jetty release directly. I think, Currently, the patch to change the default value is just enough. > Default "headerBufferSizeBytes" 8192 is causing connector creating error > ------------------------------------------------------------------------ > > Key: GERONIMO-4720 > URL: https://issues.apache.org/jira/browse/GERONIMO-4720 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: Jetty > Affects Versions: 2.2 > Environment: latest Jetty 7 trunk build +sun jdk 6 > Reporter: Shawn Jiang > Assignee: Shawn Jiang > Attachments: G4720.patch > > > Currently, the Default "headerBufferSizeBytes" size is 8192. > In org.apache.geronimo.jetty7.connector.JettyConnector > {code} > public void setHeaderBufferSizeBytes(int size) { > //TODO see https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843 > if (size == listener.getRequestBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the request buffer size: " + listener.getRequestBufferSize()); > if (size == listener.getResponseBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the response buffer size: " + listener.getResponseBufferSize()); > listener.setRequestHeaderSize(size); > listener.setResponseHeaderSize(size); > } > {code} > So that size == listener.getRequestBufferSize() will always be true. Which will cause IllegalArgumentException when creating Jetty connectors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Assigned: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/GERONIMO-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan reassigned GERONIMO-4720: ------------------------------ Assignee: Ivan (was: Shawn Jiang) > Default "headerBufferSizeBytes" 8192 is causing connector creating error > ------------------------------------------------------------------------ > > Key: GERONIMO-4720 > URL: https://issues.apache.org/jira/browse/GERONIMO-4720 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: Jetty > Affects Versions: 2.2 > Environment: latest Jetty 7 trunk build +sun jdk 6 > Reporter: Shawn Jiang > Assignee: Ivan > Attachments: G4720.patch > > > Currently, the Default "headerBufferSizeBytes" size is 8192. > In org.apache.geronimo.jetty7.connector.JettyConnector > {code} > public void setHeaderBufferSizeBytes(int size) { > //TODO see https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843 > if (size == listener.getRequestBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the request buffer size: " + listener.getRequestBufferSize()); > if (size == listener.getResponseBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the response buffer size: " + listener.getResponseBufferSize()); > listener.setRequestHeaderSize(size); > listener.setResponseHeaderSize(size); > } > {code} > So that size == listener.getRequestBufferSize() will always be true. Which will cause IllegalArgumentException when creating Jetty connectors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Resolved: (GERONIMO-4720) Default "headerBufferSizeBytes" 8192 is causing connector creating error by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/GERONIMO-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan resolved GERONIMO-4720. ---------------------------- Resolution: Fixed Fix Version/s: 2.2 Commit the changes to trunk 2.2 At revision: 790474. Thanks Shawn Jiang for the patch ! > Default "headerBufferSizeBytes" 8192 is causing connector creating error > ------------------------------------------------------------------------ > > Key: GERONIMO-4720 > URL: https://issues.apache.org/jira/browse/GERONIMO-4720 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: Jetty > Affects Versions: 2.2 > Environment: latest Jetty 7 trunk build +sun jdk 6 > Reporter: Shawn Jiang > Assignee: Ivan > Fix For: 2.2 > > Attachments: G4720.patch > > > Currently, the Default "headerBufferSizeBytes" size is 8192. > In org.apache.geronimo.jetty7.connector.JettyConnector > {code} > public void setHeaderBufferSizeBytes(int size) { > //TODO see https://bugs.eclipse.org/bugs/show_bug.cgi?id=280843 > if (size == listener.getRequestBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the request buffer size: " + listener.getRequestBufferSize()); > if (size == listener.getResponseBufferSize()) throw new IllegalArgumentException("Do not set the header buffer size to the same as the response buffer size: " + listener.getResponseBufferSize()); > listener.setRequestHeaderSize(size); > listener.setResponseHeaderSize(size); > } > {code} > So that size == listener.getRequestBufferSize() will always be true. Which will cause IllegalArgumentException when creating Jetty connectors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.