[jira] Created: (GERONIMO-4724) Empty string for contextPath should not be allowed

Empty string for contextPath should not be allowed
--------------------------------------------------

                 Key: GERONIMO-4724
                 URL: https://issues.apache.org/jira/browse/GERONIMO-4724
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: specs
    Affects Versions: 2.2
            Reporter: Ivan
            Assignee: Ivan
             Fix For: 2.2


While passing the empty string as the contextPath to the newInstance method, no exception is thrown, which expects a JAXBException.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan updated GERONIMO-4724:
---------------------------

    Attachment: Geronimo-4724.patch

Attach a patch, please help to review it.
BTW, do we have any special rule for committing the patch to the spec svn?
Thanks !

> Empty string for contextPath should not be allowed
> --------------------------------------------------
>
>                 Key: GERONIMO-4724
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4724
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: specs
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>         Attachments: Geronimo-4724.patch
>
>
> While passing the empty string as the contextPath to the newInstance method, no exception is thrown, which expects a JAXBException.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726271#action_12726271 ]

David Jencks commented on GERONIMO-4724:
----------------------------------------

Patch looks ok to me.  How do you know this is the expected behavior?

For specs, you basically need to use your judgement.  Usually checking that the appropriate tck still works ok is a good idea.  Explaining the context of the problem and why it is not spec compliant or other reason it needs to be fixed in the jira is a good idea too.

> Empty string for contextPath should not be allowed
> --------------------------------------------------
>
>                 Key: GERONIMO-4724
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4724
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: specs
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>         Attachments: Geronimo-4724.patch
>
>
> While passing the empty string as the contextPath to the newInstance method, no exception is thrown, which expects a JAXBException.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726296#action_12726296 ]

Ivan commented on GERONIMO-4724:
--------------------------------

This issue caused some of WebService TCK cases failed, that is why I found it.
For in Geronimo 2.1.*, we do not use our own JAXB API impl, and it works well. Also, I tried the Geronimo 2.2 with JDK 1.6, which ships the JAXB API, those cases pass. But while running Geronimo 2.2 in JDK 1.5, they failed.
From the codes, the author expects that the JAXBException is thrown, for there are some codes to check whether the String array's length is zero, but while the string is an empty string, an 1-length array is always returned.

> Empty string for contextPath should not be allowed
> --------------------------------------------------
>
>                 Key: GERONIMO-4724
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4724
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: specs
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>         Attachments: Geronimo-4724.patch
>
>
> While passing the empty string as the contextPath to the newInstance method, no exception is thrown, which expects a JAXBException.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan resolved GERONIMO-4724.
----------------------------

    Resolution: Fixed

Apply the patch for both JAXB 2.0 and 2.1 API impl  At revision: 790779.

> Empty string for contextPath should not be allowed
> --------------------------------------------------
>
>                 Key: GERONIMO-4724
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4724
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: specs
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>         Attachments: Geronimo-4724.patch
>
>
> While passing the empty string as the contextPath to the newInstance method, no exception is thrown, which expects a JAXBException.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.