[jira] Created: (GERONIMO-4729) Duplicate clusterName value sets in config-subsitious.properties

Duplicate clusterName value sets in config-subsitious.properties
----------------------------------------------------------------

                 Key: GERONIMO-4729
                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
             Project: Geronimo
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: Clustering
    Affects Versions: 2.1.4, 2.1.5, 2.2
         Environment: Any
            Reporter: Chi Runhua


Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
{code}
ClusterName=DEFAULT_CLUSTER
...
clusterName=CLUSTER_NAME
...
{code}
which will confuse users when they are going to set up a clustering/farming environment.

Can we improve this?

Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728478#action_12728478 ]

Rex Wang commented on GERONIMO-4729:
------------------------------------

agree, I'd like improve this

-Rex

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang reassigned GERONIMO-4729:
----------------------------------

    Assignee: Rex Wang

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated GERONIMO-4729:
-------------------------------

    Attachment: Geronimo-4729-trunk.patch

patch for trunk.

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>         Attachments: Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated GERONIMO-4729:
-------------------------------

    Attachment: Geronimo-4729-b21.patch

patch for branch 2.1

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>         Attachments: Geronimo-4729-b21.patch, Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated GERONIMO-4729:
-------------------------------

    Attachment:     (was: Geronimo-4729-b21.patch)

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>         Attachments: Geronimo-4729-b21.patch, Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated GERONIMO-4729:
-------------------------------

    Attachment: Geronimo-4729-trunk.patch
                Geronimo-4729-b21.patch

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>         Attachments: Geronimo-4729-b21.patch, Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rex Wang updated GERONIMO-4729:
-------------------------------

    Attachment:     (was: Geronimo-4729-trunk.patch)

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>         Attachments: Geronimo-4729-b21.patch, Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729021#action_12729021 ]

Rex Wang commented on GERONIMO-4729:
------------------------------------

the patches rename the
clusterName -> FarmName
ClusterName -> WADIClusterName
clusterNodeName -> ClusterNodeName

and the default value from
FarmName: CLUSTER_NAME -> DEFAULT_FARM
WADIClusterName: DEFAULT_CLUSTER -> DEFAULT_WADI_CLUSTER

-Rex

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Rex Wang
>         Attachments: Geronimo-4729-b21.patch, Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/GERONIMO-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-4729.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2
                   2.1.5
         Assignee: Jarek Gawor  (was: Rex Wang)

Committed the patch to trunk (revision 792581) and branches/2.1 (revision 792608). Thanks for the patch!

> Duplicate clusterName value sets in config-subsitious.properties
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-4729
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4729
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: Any
>            Reporter: Chi Runhua
>            Assignee: Jarek Gawor
>             Fix For: 2.1.5, 2.2
>
>         Attachments: Geronimo-4729-b21.patch, Geronimo-4729-trunk.patch
>
>
> Look into *config-subsitions.properties* file, there are 2 places to set clustername as following:
> {code}
> ClusterName=DEFAULT_CLUSTER
> ...
> clusterName=CLUSTER_NAME
> ...
> {code}
> which will confuse users when they are going to set up a clustering/farming environment.
> Can we improve this?
> Jeff

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.