[jira] Created: (HADOOP-2509) Some source files are missing license headers

Some source files are missing license headers
---------------------------------------------

                 Key: HADOOP-2509
                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
             Project: Hadoop
          Issue Type: Bug
          Components: build
    Affects Versions: 0.15.2
            Reporter: Nigel Daley
            Priority: Blocker
             Fix For: 0.16.0


The ARAT tool should be run before each release:
java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z

It's available from:
http://code.google.com/p/arat/

The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555365#action_12555365 ]

Sami Siren commented on HADOOP-2509:
------------------------------------

How about adding this check to the patch queue? That way users submitting patches would become responsible for adding proper headers and not (in the worst case) RM.

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2509:
-------------------------------

    Attachment: 2509.patch.1

Before applying this patch download [Latest ART JAR|http://arat.googlecode.com/files/rat-0.5.1.jar] and copy it to lib folder

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558348#action_12558348 ]

hrishikesh edited comment on HADOOP-2509 at 1/12/08 9:22 PM:
-------------------------------------------------------------

Attaching patch 2509.patch.1

Before applying this patch download [Latest ART JAR|http://arat.googlecode.com/files/rat-0.5.1.jar] and copy it to lib folder



      was (Author: hrishikesh):
    Before applying this patch download [Latest ART JAR|http://arat.googlecode.com/files/rat-0.5.1.jar] and copy it to lib folder


 

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558348#action_12558348 ]

hrishikesh edited comment on HADOOP-2509 at 1/12/08 9:31 PM:
-------------------------------------------------------------

Attaching patch 2509.patch.1

Before applying this patch download [Latest ART JAR|http://arat.googlecode.com/files/rat-0.5.1.jar] and copy it to lib folder. The jar needs to be "added" to SVN

Once the jar is present at the correct location execute the new auditing target
{quote}
ant releaseaudit
{quote}

The output of RAT can get a bit too much to read on the console so a better idea is to put it in a log file
{quote}
ant releaseaudit -l build.log
{quote}

Currently its listing a lot of files but once we fix it, we can add it to the "daily build" and if needed make the build fail if license is missing


      was (Author: hrishikesh):
    Attaching patch 2509.patch.1

Before applying this patch download [Latest ART JAR|http://arat.googlecode.com/files/rat-0.5.1.jar] and copy it to lib folder


 

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2509:
-------------------------------

    Attachment:     (was: 2509.patch.1)

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2509:
-------------------------------

    Attachment: 2509.patch.1

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558936#action_12558936 ]

Nigel Daley commented on HADOOP-2509:
-------------------------------------

Looks like a good start.  A couple suggestions:

 # just have 1 target called 'rat' (it does more than just headers)
 # require the user to download the library (so they get the latest one)
 # add a check for the rat*.jar library before executing the target and fail gracefully
 # perhaps set failonerror (or errorproperty?) so the build will (or can) fail if the rat report indicates an error (provided rat exits with non-zero on error)

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2509:
-------------------------------

    Attachment: 2509.patch.2

Attached file 2509.patch.2

Incorporated the following items
{quote}
1. just have 1 target called 'rat' (it does more than just headers)
2. require the user to download the library (so they get the latest one)
3. add a check for the rat*.jar library before executing the target and fail gracefully
{quote}

Is this absolutely critical ...
{quote}
4. perhaps set failonerror (or errorproperty?) so the build will (or can) fail if the rat report indicates an error (provided rat exits with non-zero on erro)
{quote}

I feel point #4 is something that is "nice to have"  add on may be we can submit the path to fix 1,2,3 and then change the category to "Improvement" and have the priority as "Major".

Please comment.

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2509:
-------------------------------

    Attachment: 2509.patch.2

Submitting  again with "Grant license to ASF"

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559362#action_12559362 ]

Hrishikesh commented on HADOOP-2509:
------------------------------------

   If rat.Report exists and gets executed (assuming all the required libraries are in place) but finds missing license headers the JVM which executes rat.Report will still exit with error code 0. So checking the JVM exist code is of no help.

We can either look for text in the rat.Report output and then fail if say a word XXX exists or we write out own ant task which extends rat.Report and then write code to exist with System.exit (1) when any issues are found. This needs further investigation.

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559362#action_12559362 ]

hrishikesh edited comment on HADOOP-2509 at 1/15/08 10:34 PM:
--------------------------------------------------------------

   If rat.Report exists and gets executed (assuming all the required libraries are in place) but finds missing license headers the JVM which executes rat.Report will still exit with error code 0. So checking the JVM exist code is of no help.

We can either look for text in the rat.Report output and then fail if say a word XXX exists or we write our own ant task which extends rat.Report and then write code to exist with System.exit (1) when any issues are found. This needs further investigation.




      was (Author: hrishikesh):
       If rat.Report exists and gets executed (assuming all the required libraries are in place) but finds missing license headers the JVM which executes rat.Report will still exit with error code 0. So checking the JVM exist code is of no help.

We can either look for text in the rat.Report output and then fail if say a word XXX exists or we write out own ant task which extends rat.Report and then write code to exist with System.exit (1) when any issues are found. This needs further investigation.



 

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559362#action_12559362 ]

hrishikesh edited comment on HADOOP-2509 at 1/15/08 10:34 PM:
--------------------------------------------------------------

   If rat.Report exists and gets executed (assuming all the required libraries are in place) but finds missing license headers the JVM which executes rat.Report will still exit with error code 0. So checking the JVM exist code is of no help.

We can either look for text in the rat.Report output and then fail if say a word XXX exists or we write our own ant task which extends the functionality of rat.Report and then  exist with System.exit (1) when any issues are found. This needs further investigation.




      was (Author: hrishikesh):
       If rat.Report exists and gets executed (assuming all the required libraries are in place) but finds missing license headers the JVM which executes rat.Report will still exit with error code 0. So checking the JVM exist code is of no help.

We can either look for text in the rat.Report output and then fail if say a word XXX exists or we write our own ant task which extends rat.Report and then write code to exist with System.exit (1) when any issues are found. This needs further investigation.



 

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559787#action_12559787 ]

Nigel Daley commented on HADOOP-2509:
-------------------------------------

Ok, let's drop item 4 for now.  RAT is actually moving to the Apache incubator project so more development will occur in the near future (I hope).  Once it's moved there, we can file RFE's for RAT to allow more command line control.  So +1 for this patch.

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2509:
--------------------------------

    Assignee: Hrishikesh
      Status: Patch Available  (was: Open)

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Assignee: Hrishikesh
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559814#action_12559814 ]

Hrishikesh commented on HADOOP-2509:
------------------------------------

ok great !

> Some source files are missing license headers
> ---------------------------------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Assignee: Hrishikesh
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2509:
--------------------------------

    Priority: Major  (was: Blocker)
     Summary: Add rat target to build  (was: Some source files are missing license headers)

This issue was originally about fixing source headers, but turned into adding a rat target to the build.  I have updated the summary and will file a new issue for the header fixes.

> Add rat target to build
> -----------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Assignee: Hrishikesh
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2509:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I updated the patch so it applied and committed it.  Thanks Hrishikesh!

> Add rat target to build
> -----------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Assignee: Hrishikesh
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh updated HADOOP-2509:
-------------------------------

    Attachment: 2509.patch.3

After giving it a thought its not fair to ask the user to put the rat jar in <hadoopbasedir>/lib directory. Since we don't ship the file user should have control over where to keep the extra jar files

The user should either add the ratjar to the system class path or use -lib as a ant command line argument

E.g.
User download rat.jar to directory named $HOME/myjars then the correct way to execute releaseaudit target is
{quote}
ant -lib $HOME/myjars releaseaudit
{quote}

Attached patch 2509.patch.3

Awating comments... should we reopen the issue and apply patch 2509.patch.3 ?

> Add rat target to build
> -----------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Assignee: Hrishikesh
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2, 2509.patch.3
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hrishikesh reopened HADOOP-2509:
--------------------------------


Reopening as a better solution is available.

> Add rat target to build
> -----------------------
>
>                 Key: HADOOP-2509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2509
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.2
>            Reporter: Nigel Daley
>            Assignee: Hrishikesh
>             Fix For: 0.16.0
>
>         Attachments: 2509.patch.1, 2509.patch.2, 2509.patch.2, 2509.patch.3
>
>
> The ARAT tool should be run before each release:
> java -cp rat-0.5.1.jar rat.Report hadoop-x.y.z
> It's available from:
> http://code.google.com/p/arat/
> The output for 0.15.2 shows some missing license headers which must be fixed for 0.16.0:
> http://people.apache.org/~siren/hadoop-0.15.2-rc0/rat-hadoop-0.15.2.txt

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.