|

»

»

»

Hadoop lucene-dev

[jira] Created: (HADOOP-2518) [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage

View: New views

5 Messages — Rating Filter: Alert me

	[jira] Created: (HADOOP-2518) [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage -------------------------------------------------------------------------------------- Key: HADOOP-2518 URL: https://issues.apache.org/jira/browse/HADOOP-2518 Project: Hadoop Issue Type: Improvement Components: contrib/hbase Reporter: Bryan Duxbury Assignee: Bryan Duxbury Priority: Minor HStore, the class responsible for managing data storage for column families within a region, is a very large class with more than a few internal classes. I propose moving HStore and HStoreFile into the hbase.store subpackage, and then moving internal classes out of HStore and into their own package-internal classes within the subpackage. This will make the code much more readable and manageable. In addition, it will help to logically delineate which classes are involved in managing a store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Updated: (HADOOP-2518) [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/HADOOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated HADOOP-2518: ---------------------------------- Attachment: 2518.patch Here's my go at the refactor described above. Files modified: D src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestHStoreFile.java D src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestHMemcache.java A src/contrib/hbase/src/test/org/apache/hadoop/hbase/store A src/contrib/hbase/src/test/org/apache/hadoop/hbase/store/TestHStoreFile.java A src/contrib/hbase/src/test/org/apache/hadoop/hbase/store/TestHMemcache.java M src/contrib/hbase/src/test/org/apache/hadoop/hbase/TestCompaction.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLogKey.java D src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreFile.java D src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/BloomFilterDescriptor.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HLog.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HMaster.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/CompactionReader.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStoreSize.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/Memcache.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStore.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStoreFile.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/StoreFileScanner.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/MapFileCompactionReader.java A src/contrib/hbase/src/java/org/apache/hadoop/hbase/store/HStoreScanner.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HAbstractScanner.java M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java > [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage > -------------------------------------------------------------------------------------- > > Key: HADOOP-2518 > URL: https://issues.apache.org/jira/browse/HADOOP-2518 > Project: Hadoop > Issue Type: Improvement > Components: contrib/hbase > Reporter: Bryan Duxbury > Assignee: Bryan Duxbury > Priority: Minor > Attachments: 2518.patch > > > HStore, the class responsible for managing data storage for column families within a region, is a very large class with more than a few internal classes. I propose moving HStore and HStoreFile into the hbase.store subpackage, and then moving internal classes out of HStore and into their own package-internal classes within the subpackage. This will make the code much more readable and manageable. In addition, it will help to logically delineate which classes are involved in managing a store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (HADOOP-2518) [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/HADOOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555668#action_12555668 ] Jim Kellerman commented on HADOOP-2518: --------------------------------------- ACK! no please! I am in the middle of rewriting all this stuff to change the file layout. > [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage > -------------------------------------------------------------------------------------- > > Key: HADOOP-2518 > URL: https://issues.apache.org/jira/browse/HADOOP-2518 > Project: Hadoop > Issue Type: Improvement > Components: contrib/hbase > Reporter: Bryan Duxbury > Assignee: Bryan Duxbury > Priority: Minor > Attachments: 2518.patch > > > HStore, the class responsible for managing data storage for column families within a region, is a very large class with more than a few internal classes. I propose moving HStore and HStoreFile into the hbase.store subpackage, and then moving internal classes out of HStore and into their own package-internal classes within the subpackage. This will make the code much more readable and manageable. In addition, it will help to logically delineate which classes are involved in managing a store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Commented: (HADOOP-2518) [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/HADOOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556020#action_12556020 ] Bryan Duxbury commented on HADOOP-2518: --------------------------------------- After some discussion with Jim, it looks like this patch is going to be put on hold. After he's checked in his patch to change file organization, we can re-address this desire. > [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage > -------------------------------------------------------------------------------------- > > Key: HADOOP-2518 > URL: https://issues.apache.org/jira/browse/HADOOP-2518 > Project: Hadoop > Issue Type: Improvement > Components: contrib/hbase > Reporter: Bryan Duxbury > Assignee: Bryan Duxbury > Priority: Minor > Attachments: 2518.patch > > > HStore, the class responsible for managing data storage for column families within a region, is a very large class with more than a few internal classes. I propose moving HStore and HStoreFile into the hbase.store subpackage, and then moving internal classes out of HStore and into their own package-internal classes within the subpackage. This will make the code much more readable and manageable. In addition, it will help to logically delineate which classes are involved in managing a store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
	[jira] Resolved: (HADOOP-2518) [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage by JIRA jira@apache.org :: Rate this Message: Reply to Author \| View Threaded \| Show Only this Message [ https://issues.apache.org/jira/browse/HADOOP-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Kellerman resolved HADOOP-2518. ----------------------------------- Resolution: Duplicate > [hbase] Refactor HStore and internal (and related) classes into hbase.store subpackage > -------------------------------------------------------------------------------------- > > Key: HADOOP-2518 > URL: https://issues.apache.org/jira/browse/HADOOP-2518 > Project: Hadoop Core > Issue Type: Improvement > Components: contrib/hbase > Reporter: Bryan Duxbury > Assignee: Bryan Duxbury > Priority: Minor > Attachments: 2518.patch > > > HStore, the class responsible for managing data storage for column families within a region, is a very large class with more than a few internal classes. I propose moving HStore and HStoreFile into the hbase.store subpackage, and then moving internal classes out of HStore and into their own package-internal classes within the subpackage. This will make the code much more readable and manageable. In addition, it will help to logically delineate which classes are involved in managing a store. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.