[jira] Created: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

View: New views
20 Messages — Rating Filter:   Alert me  
< Prev | 1 - 2 | Next >

[jira] Created: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Revert change to fsck made as part of permissions implementation
----------------------------------------------------------------

                 Key: HADOOP-2633
                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
             Project: Hadoop
          Issue Type: Bug
          Components: dfs
    Affects Versions: 0.16.0
            Reporter: Robert Chansler
            Assignee: Tsz Wo (Nicholas), SZE
            Priority: Blocker
             Fix For: 0.16.0


Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Attachment: 2633_20080116.patch

2633_20080116.patch: access NameNode by (local) method calls instead of RPC.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560163#action_12560163 ]

Konstantin Shvachko commented on HADOOP-2633:
---------------------------------------------

- nn.namesystem.now() should be FSNamesystem.now()
- Methods should be separate by a blank line.
- there is to many methods called getBlockLocationsInternal(). It took me at least 20 minutes to understand who is calling whom. Traditionally the general idea of methods and their *Internal counterparts is to distinguish between the api methods and their synchronized parts. Synchronized part of the implementation is usually called *Internal. It is also supposed to be private.

I propose the following modifications here:
- getBlockLocationsInternal(String src,long,long) should be renamed to getBlockLocations(String src,long,long) because you need to call ii in NamenodeFsck.
- getBlockLocationsInternal(String clientMachine,String src,long,long)  should be removed and the sorting part of it should be placed directly into getBlockLocations(String clientMachine,String src,long,long).
- the private getBlockLocationInternal(INodeFile, ...) should be renamed to getBlockLocationsInternal(INodeFile, ...) with an 's' in the middle. This was probably my fault.

As a result you will have only one private synchronized getBlockLocationsInternal() and two getBlockLocations().

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Attachment: 2633_20080117.patch

2633_20080117.patch: incorporated all suggestions.  Thanks, Konstantin.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Attachment: 2633_20080117b.patch

2633_20080117.patch: updated with trunk

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560172#action_12560172 ]

szetszwo edited comment on HADOOP-2633 at 1/17/08 4:25 PM:
-------------------------------------------------------------------------

2633_20080117b.patch: updated with trunk

      was (Author: szetszwo):
    2633_20080117.patch: updated with trunk
 

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Attachment: 2633_20080117c.patch

2633_20080117c.patch: re-arranged some codes.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560202#action_12560202 ]

Konstantin Shvachko commented on HADOOP-2633:
---------------------------------------------

+1

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560239#action_12560239 ]

Nigel Daley commented on HADOOP-2633:
-------------------------------------

Does a test need to be written for this?  It's not clear how easy that would be.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560486#action_12560486 ]

Robert Chansler commented on HADOOP-2633:
-----------------------------------------

This change should be very low risk--fsck either works or it doesn't. There
was a lot more risk in the new code!

In this context, make sure you've taken a peek at

https://issues.apache.org/jira/browse/HADOOP-2632






> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560491#action_12560491 ]

Hadoop QA commented on HADOOP-2633:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373464/2633_20080117c.patch
against trunk revision r613115.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1639/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1639/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1639/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1639/console

This message is automatically generated.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Status: Open  (was: Patch Available)

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Attachment: 2633_20080118.patch

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560730#action_12560730 ]

Hadoop QA commented on HADOOP-2633:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373551/2633_20080118.patch
against trunk revision r613359.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1654/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1654/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1654/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1654/console

This message is automatically generated.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Status: Open  (was: Patch Available)

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch, 2633_20080122.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Attachment: 2633_20080122.patch

2633_20080122.patch: rewrite TestFsck so that MiniDFSCluster is shutdown properly between each test.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch, 2633_20080122.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2633:
-------------------------------------------

    Status: Patch Available  (was: Open)

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch, 2633_20080122.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2633) Revert change to fsck made as part of permissions implementation

by JIRA jira@apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/HADOOP-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561623#action_12561623 ]

Hadoop QA commented on HADOOP-2633:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373782/2633_20080122.patch
against trunk revision r614413.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1681/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1681/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1681/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1681/console

This message is automatically generated.

> Revert change to fsck made as part of permissions implementation
> ----------------------------------------------------------------
>
>                 Key: HADOOP-2633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2633
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.0
>            Reporter: Robert Chansler
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.16.0
>
>         Attachments: 2633_20080116.patch, 2633_20080117.patch, 2633_20080117b.patch, 2633_20080117c.patch, 2633_20080118.patch, 2633_20080122.patch
>
>
> Earlier change has unacceptable performance behavior.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

< Prev | 1 - 2 | Next >