[jira] Created: (HADOOP-2653) [HQL] HQLClient Object creation in a shell loop.

[HQL] HQLClient Object creation in a shell loop.
------------------------------------------------

                 Key: HADOOP-2653
                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
             Project: Hadoop
          Issue Type: Improvement
          Components: contrib/hbase
    Affects Versions: 0.16.0
            Reporter: Edward Yoon
            Assignee: Edward Yoon
            Priority: Minor
             Fix For: 0.17.0


{code}
Shell.java

while(....) {
  HQLClient hql = new HQLClient(...);
}
{code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Status: Patch Available  (was: Open)

Submitting.

> [HQL] HQLClient Object creation in a shell loop.
> ------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Attachment: 2653.patch

Uploaded patch is resolve this problem.

> [HQL] HQLClient Object creation in a shell loop.
> ------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Summary: [HQL] Unnecessary HQLClient Object creation in a shell loop.  (was: [HQL] HQLClient Object creation in a shell loop.)

It's a unnecessary object creation.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560252#action_12560252 ]

stack commented on HADOOP-2653:
-------------------------------

Edward: What is the problem here?  Can you help me out?  I've looked at the patch and at the description above and am having trouble figuring the problem you are trying to solve.  Thanks.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560269#action_12560269 ]

Edward Yoon commented on HADOOP-2653:
-------------------------------------

{code}
BEFORE:

while(....) {
  HQLClient hql = new HQLClient(...);
  hql.executeQuery(queryString);
}

AFTER:

HQLClient hql = new HQLClient(...);
while(....) {
  hql.executeQuery(queryString);
}

BEFORE involves the creation of hqlclient object per iteration.
AFTER avoids hqlclient object creation in the loop.

It's too trivial change, but i prefer short-term patch because i need a confirm.
If it is not good work model, please let me know.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560269#action_12560269 ]

udanax edited comment on HADOOP-2653 at 1/17/08 11:37 PM:
---------------------------------------------------------------

{code}
BEFORE:

while(....) {
  HQLClient hql = new HQLClient(...);
  hql.executeQuery(queryString);
}

AFTER:

HQLClient hql = new HQLClient(...);
while(....) {
  hql.executeQuery(queryString);
}
{code}
BEFORE involves the creation of hqlclient object per iteration.
AFTER avoids hqlclient object creation in the loop.

It's too trivial change, but i prefer short-term patch because i need a confirm.
If it is not good work model, please let me know.

      was (Author: udanax):
    {code}
BEFORE:

while(....) {
  HQLClient hql = new HQLClient(...);
  hql.executeQuery(queryString);
}

AFTER:

HQLClient hql = new HQLClient(...);
while(....) {
  hql.executeQuery(queryString);
}

BEFORE involves the creation of hqlclient object per iteration.
AFTER avoids hqlclient object creation in the loop.

It's too trivial change, but i prefer short-term patch because i need a confirm.
If it is not good work model, please let me know.
 

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560556#action_12560556 ]

Hadoop QA commented on HADOOP-2653:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373469/2653.patch
against trunk revision r613115.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests -1.  The patch failed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1641/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1641/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1641/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1641/console

This message is automatically generated.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560769#action_12560769 ]

Edward Yoon commented on HADOOP-2653:
-------------------------------------

unrelatated error. Please commit it, boss.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Minor
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2653:
--------------------------

    Priority: Trivial  (was: Minor)

Thanks for adding a description (Considered description make the life of a reviewer easier).  IIUC,  this patch is 'optimizing' shell.

If so, this issue is trivial -- I set it so -- and we all should be working on more important issues.

What does the below test?

{code}
+  public void test() {
+    HQLClient hql = new HQLClient(new HBaseConfiguration());
+    ReturnMsg rm = hql.executeQuery("non-command;");
+    assertTrue(rm.getType() == -9);
+  }
{code}

Should be a javadoc. or comment because I cannot from reading the code figure what it does or what the -9 expected result means (These -9s are in a few places.  They should be defines if all the -9s mean the same thing).

Why the HQLClient constructor change using setters instead of passing params to the Constructor?  It seemed better the way it was previous.

Is the offset of 9 safe in the below?

{code}
+    conf.set("hbase.master", masterAddress.substring(9, masterAddress.length()));
{code}

If so, should be accompanied by a coment saying why (Why can't passed masterAddress by null or not match the expected pattern)?

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Status: Open  (was: Patch Available)

* substring(9, masterAddress.length()) will be improved.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Attachment: 2653_v01.patch

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Status: Patch Available  (was: Open)

submitting.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Status: Open  (was: Patch Available)

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward Yoon updated HADOOP-2653:
--------------------------------

    Status: Patch Available  (was: Open)

re-scheduling

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561776#action_12561776 ]

Hadoop QA commented on HADOOP-2653:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373664/2653_v01.patch
against trunk revision r614413.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs -1.  The patch appears to cause Findbugs to fail.

    core tests -1.  The patch failed core unit tests.

    contrib tests -1.  The patch failed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1686/testReport/
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1686/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1686/console

This message is automatically generated.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561839#action_12561839 ]

Hadoop QA commented on HADOOP-2653:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373664/2653_v01.patch
against trunk revision 614699.

    @author +1.  The patch does not contain any @author tags.

    patch -1.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1652/console

This message is automatically generated.

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561848#action_12561848 ]

Nigel Daley commented on HADOOP-2653:
-------------------------------------

sorry, I belive the -1 from HadoopQA was wrong.  Resubmitting it...

> [HQL] Unnecessary HQLClient Object creation in a shell loop.
> ------------------------------------------------------------
>
>                 Key: HADOOP-2653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2653
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.16.0
>            Reporter: Edward Yoon
>            Assignee: Edward Yoon
>            Priority: Trivial
>             Fix For: 0.17.0
>
>         Attachments: 2653.patch, 2653_v01.patch
>
>
> {code}
> Shell.java
> while(....) {
>   HQLClient hql = new HQLClient(...);
> }
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.