[jira] Created: (HADOOP-2659) The commands in DFSAdmin should require admin privilege

The commands in DFSAdmin should require admin privilege
-------------------------------------------------------

                 Key: HADOOP-2659
                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
             Project: Hadoop
          Issue Type: Bug
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE


The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Attachment: 2659_20080118.patch

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Component/s: dfs
    Description:
The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.

DFSAdmin commands:
-report
-safemode
-refreshNodes
-finalizeUpgrade
-upgradeProgress
-metasave

ClientProtocol:
{code}
public void renewLease(String clientName) throws IOException;
public long[] getStats() throws IOException;
public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
public void refreshNodes() throws IOException;
public void finalizeUpgrade() throws IOException;
public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
public void metaSave(String filename) throws IOException;
{code}


  was:The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560604#action_12560604 ]

Konstantin Shvachko commented on HADOOP-2659:
---------------------------------------------

- renewLease() does not seem to be ab admin command.
- distributedUpgradeProgress() is called by DFSAdmin and by JspHelper.
In the DFSAdmin case it should be protected, but web UI does not need to have have super-user privileges.
For consistency I would propose just to treat this operation available to all users in all cases.
I do not see how knowing the upgrade stage can threaten the system security. Or does it?
- I'd prefer a full name checkSuperuserPermissions() instead of checkIsSuper().
- import of FSConstants.SafeModeAction is redundant because FSNamesystem inherits FSConstants.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Attachment: 2659_20080118b.patch

2659_20080118b.patch: updated patch with Konstantin's comments

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560616#action_12560616 ]

Konstantin Shvachko commented on HADOOP-2659:
---------------------------------------------

+1

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Status: Patch Available  (was: Open)

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560791#action_12560791 ]

Hadoop QA commented on HADOOP-2659:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373580/2659_20080118b.patch
against trunk revision r613499.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1659/console

This message is automatically generated.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561412#action_12561412 ]

Konstantin Shvachko commented on HADOOP-2659:
---------------------------------------------

As Rob pointed out for backward compatibility when permission checking is not enabled users should be able to perform the admin commands even if they are not superusers.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Attachment: 2659_20080122.patch

2659_20080122.patch: It checks superuser privilege only if permission is enabled.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Status: Patch Available  (was: Open)

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-2659:
-------------------------------------------

    Status: Open  (was: Patch Available)

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561532#action_12561532 ]

Hadoop QA commented on HADOOP-2659:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373773/2659_20080122.patch
against trunk revision r614301.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1678/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1678/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1678/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1678/console

This message is automatically generated.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2659:
--------------------------------

    Fix Version/s: 0.16.0

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.0
>
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HADOOP-2659:
----------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this. Thank you Nicholas.

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.0
>
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561652#action_12561652 ]

Hudson commented on HADOOP-2659:
--------------------------------

Integrated in Hadoop-trunk #374 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/374/])

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.0
>
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/HADOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561712#action_12561712 ]

Hudson commented on HADOOP-2659:
--------------------------------

Integrated in Hadoop-Nightly #374 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/374/])

> The commands in DFSAdmin should require admin privilege
> -------------------------------------------------------
>
>                 Key: HADOOP-2659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2659
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.0
>
>         Attachments: 2659_20080118.patch, 2659_20080118b.patch, 2659_20080122.patch
>
>
> The commands in DFSAdmin and the corresponding RPC calls should require admin privilege.
> DFSAdmin commands:
> -report
> -safemode
> -refreshNodes
> -finalizeUpgrade
> -upgradeProgress
> -metasave
> ClientProtocol:
> {code}
> public void renewLease(String clientName) throws IOException;
> public long[] getStats() throws IOException;
> public DatanodeInfo[] getDatanodeReport(FSConstants.DatanodeReportType type) throws IOException;
> public boolean setSafeMode(FSConstants.SafeModeAction action) throws IOException;
> public void refreshNodes() throws IOException;
> public void finalizeUpgrade() throws IOException;
> public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action) throws IOException;
> public void metaSave(String filename) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.