[jira] Created: (HTTPCLIENT-866) HttpClient depends on jcip-annotations.jar

HttpClient depends on jcip-annotations.jar
------------------------------------------

                 Key: HTTPCLIENT-866
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
             Project: HttpComponents HttpClient
          Issue Type: Bug
    Affects Versions: 4.0 Final
         Environment: javac 1.5.0_19
            Reporter: David Nault


When compiling with Java 5, jcip-annotations.jar must be in the classpath or else you get a compiler error:

    [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
    [javac] file net/jcip/annotations/GuardedBy.class not found
    [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
    [javac]                                        ^


With Java 6, you get a bunch of warnings instead.
    [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found


This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Nault updated HTTPCLIENT-866:
-----------------------------------

    Description:
When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:

    [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
    [javac] file net/jcip/annotations/GuardedBy.class not found
    [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
    [javac]                                        ^


With Java 6, you get a bunch of warnings instead.
    [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found


This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.


  was:
When compiling with Java 5, jcip-annotations.jar must be in the classpath or else you get a compiler error:

    [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
    [javac] file net/jcip/annotations/GuardedBy.class not found
    [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
    [javac]                                        ^


With Java 6, you get a bunch of warnings instead.
    [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found


This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742671#action_12742671 ]

David Nault commented on HTTPCLIENT-866:
----------------------------------------

This discussion thread looks relevant:

http://cs.oswego.edu/pipermail/concurrency-interest/2007-December/004711.html

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742772#action_12742772 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

HttpClient dependencies are documented in the project descriptor (pom.xml). When using Maven to build HttpClient all requisite dependencies are obtained automatically from a central repository.

jcip-annotations are not required at the run time and therefore the jar is not shipped with the "httpcomponents-client-4.0-bin-with-dependencies" package.

What exactly do you want us to do to resolve the issue?

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743509#action_12743509 ]

David Nault commented on HTTPCLIENT-866:
----------------------------------------

The issue is not about building HttpClient; it's about using Java 5 to compile code that *uses* httpclient-4.0.jar. If you use Java 5 and HttpClient, you need the JCIP annotation jar in your classpath at compile time. Try it :-) Presumably this is because those annotations have runtime retention.

I think it would be ideal if consumers of HttpClient didn't need this jar. Second best would be to include it in the "with-dependencies" distribution.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743509#action_12743509 ]

David Nault edited comment on HTTPCLIENT-866 at 8/14/09 6:15 PM:
-----------------------------------------------------------------

The issue is not about building HttpClient; it's about using Java 5 to compile code that *uses* httpclient-4.0.jar. If you use Java 5 and HttpClient, you need the JCIP annotation jar in your classpath at compile time. Try it :-) Presumably this is because those annotations have runtime retention.

I think it would be ideal if consumers of HttpClient didn't need this jar. Second best would be to include it in the HttpClient distribution.



      was (Author: dnault_laszlo):
    The issue is not about building HttpClient; it's about using Java 5 to compile code that *uses* httpclient-4.0.jar. If you use Java 5 and HttpClient, you need the JCIP annotation jar in your classpath at compile time. Try it :-) Presumably this is because those annotations have runtime retention.

I think it would be ideal if consumers of HttpClient didn't need this jar. Second best would be to include it in the "with-dependencies" distribution.


 

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-866:
-----------------------------------------

    Priority: Critical  (was: Major)

Sorry that it took me so long to understand the extent of the problem.

I think the retention policy of jcip-annotations.jar is set to RUNTIME in order to enable automated detection of concurrency related bugs using some kind runtime analysis tools.

Sebastian

Unless we can find a way to override the retention policy of jcip-annotations.jar to SOURCE at least for official builds of HttpClient and HttpCore, we should seriously consider removing dependency on jcip-annotations.jar. Alternatively, we should consider the possibility of forking  jcip-annotations provided its licence is compatible with ASFv2

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743687#action_12743687 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

It looks like we cannot just fork the damn thing and re-licence it under ASLv2. We either have to remove it entirely or provide our own set of equivalent annotations with SOURCE retention policy
---
 * Copyright (c) 2005 Brian Goetz and Tim Peierls
 * Released under the Creative Commons Attribution License
 *   (http://creativecommons.org/licenses/by/2.5)
 * Official home: http://www.jcip.net
 *
 * Any republication or derived work distributed in source code form
 * must include this copyright and license notice.
---

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743702#action_12743702 ]

Sebb commented on HTTPCLIENT-866:
---------------------------------

I've just tried using Eclipse to build the examples using just the jars from the "with dependencies" download, and no problems are reported.

Using Java 1.5.0_18 generates errors for the missing annotations.

Whereas using Java 1.6.0_14 generates warnings for the missing annotations.

Looks like this is at least partly a compiler issue.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743705#action_12743705 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

I think the real issue is the RUNTIME retention policy of jcip-annotations.jar, which is obviously something we have to address one way or another.

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743707#action_12743707 ]

Sebb commented on HTTPCLIENT-866:
---------------------------------

Or we include the binary jcip jar in the archive. We need to check if that is OK with ASF policy first; I'll look into that.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743708#action_12743708 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

> Or we include the binary jcip jar in the archive.

Sebastian, but when jcip-annotations.jar was brought in, the whole idea was it was not going to impact the runtime behaviour of HttpClient. This is clearly not the case now. At the very least HttpCore should not have it as a dependency.

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743726#action_12743726 ]

Sebb commented on HTTPCLIENT-866:
---------------------------------

Yes. It's unfortunate that this issue was not noticed earlier.

However, it's likely to be a lot of work to fix the runtime dependency, so it may be useful to explore other options at least in the short-term.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743781#action_12743781 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

Sebastian

(1) I am going to remove jcip-annotations.jar as a dependency for HttpCore as it is currently not being used anywhere.
(2) As far as HttpClient is concerned I see three options
 a) remove jcip annotations altogether
 b) replace jcip annotations with similar ones with SOURCE retention and provide a script to convert annotations back to jcip
 c) make jcip annotations runtime dependency

Which options would you prefer?

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743784#action_12743784 ]

Sebb commented on HTTPCLIENT-866:
---------------------------------

1) OK, though if 2(b) is successful it may be worth porting to HttpCore

2) I prefer (b) then (c) then (a)
If we do go for (a), then I suggest commenting the annotations rather than removing them, as the comments would still be useful.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-866:
-----------------------------------------

    Attachment: HTTPCLIENT-866.patch

Sebastian, please review the patch and let me know if you see any issues with it including legal / license related

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>         Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744034#action_12744034 ]

Sebb commented on HTTPCLIENT-866:
---------------------------------

AIUI, the Creative Commons Attribution Licence allows for the work to be adapted, so long as the author's attribution requirements are adhered to.

I think this means that we would need to put something in the NOTICE file to honour the attribution.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>         Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744042#action_12744042 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

That should not be a problem, should it? Do you know how that attribution clause should be worded?

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>         Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745964#action_12745964 ]

Sebb commented on HTTPCLIENT-866:
---------------------------------

I've been thinking more about this - seems to me that if we use the annotations, then they should be used consistently, i.e. we should use them in HttpCore as well.

If we add annotations as part of HttpClient, then it may be hard to add them to HttpCore later without causing problems.
I think the annotations would need to go in a separate module, this might make it possible to move them to HttpCore later.

I'm beginning to think it might be easier to comment out the annotations for now.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>         Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745968#action_12745968 ]

Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------

I thought about that too. However, the beauty of it is that can simply move those annotation classes to core whenever we see fit without breaking binary compatibility with previous versions of HttpClient.

Oleg

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>         Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...