[jira] Created: (IBATIS-623) Generated migration script are not valid for MySQL

View: New views
9 Messages — Rating Filter:   Alert me  

[jira] Created: (IBATIS-623) Generated migration script are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Generated migration script are not valid for MySQL
--------------------------------------------------

                 Key: IBATIS-623
                 URL: https://issues.apache.org/jira/browse/IBATIS-623
             Project: iBatis for Java
          Issue Type: Bug
          Components: Tools
    Affects Versions: 3.0 Beta 1
            Reporter: Ken Chau


When generating migration files, it generates comments with this syntax:

--//@UNDO

This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Commented: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742650#action_12742650 ]

Ken Chau commented on IBATIS-623:
---------------------------------

It took forever to attach a patch, so I'm creating a new comment for the small patch that will fix the template...

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>             Fix For: 3.0 GA
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Commented: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742651#action_12742651 ]

Ken Chau commented on IBATIS-623:
---------------------------------

{code}
Index: template_changelog.sql
===================================================================
--- template_changelog.sql (revision 803739)
+++ template_changelog.sql (working copy)
@@ -1,4 +1,4 @@
---// Create Changelog
+-- // Create Changelog
 
 -- Default DDL for changelog table that will keep
 -- a record of the migrations that have been run.
@@ -19,6 +19,6 @@
   ADD CONSTRAINT PK_${changelog}
   PRIMARY KEY (id);
 
---//@UNDO
+-- //@UNDO
 
 DROP TABLE ${changelog};
\ No newline at end of file
Index: template_migration.sql
===================================================================
--- template_migration.sql (revision 803739)
+++ template_migration.sql (working copy)
@@ -1,9 +1,9 @@
---// ${description}
+-- // ${description}
 -- Migration SQL that makes the change goes here.
 
 
 
---//@UNDO
+-- //@UNDO
 -- SQL to undo the change goes here.
 
 
Index: template_bootstrap.sql
===================================================================
--- template_bootstrap.sql (revision 803739)
+++ template_bootstrap.sql (working copy)
@@ -1,17 +1,17 @@
---// Bootstrap.sql
+-- // Bootstrap.sql
 
 -- This is the only SQL script file that is NOT
 -- a valid migration and will not be run or tracked
 -- in the changelog.  There is no @UNDO section.
 
---// Do I need this file?
+-- // Do I need this file?
 
 -- New projects likely won't need this file.
 -- Existing projects will likely need this file.
 -- It's unlikely that this bootstrap should be run
 -- in the production environment.
 
---// Purpose
+-- // Purpose
 
 -- The purpose of this file is to provide a facility
 -- to initialize the database to a state before iBATIS
@@ -22,7 +22,7 @@
 -- be put in this bootstrap file (but does not have
 -- to be if you are comfortable with your current process.
 
---// Running
+-- // Running
 
 -- The bootstrap SQL is run with the "migrate bootstrap"
 -- command.  It must be run manually, it's never run as
{code}

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>             Fix For: 3.0 GA
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Issue Comment Edited: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742651#action_12742651 ]

Ken Chau edited comment on IBATIS-623 at 8/12/09 4:26 PM:
----------------------------------------------------------


Index: template_changelog.sql
===================================================================
--- template_changelog.sql (revision 803739)
+++ template_changelog.sql (working copy)
@@ -1,4 +1,4 @@
---// Create Changelog
+-- // Create Changelog
 
 -- Default DDL for changelog table that will keep
 -- a record of the migrations that have been run.
@@ -19,6 +19,6 @@
   ADD CONSTRAINT PK_${changelog}
   PRIMARY KEY (id);
 
---//@UNDO
+-- //@UNDO
 
 DROP TABLE ${changelog};
\ No newline at end of file
Index: template_migration.sql
===================================================================
--- template_migration.sql (revision 803739)
+++ template_migration.sql (working copy)
@@ -1,9 +1,9 @@
---// ${description}
+-- // ${description}
 -- Migration SQL that makes the change goes here.
 
 
 
---//@UNDO
+-- //@UNDO
 -- SQL to undo the change goes here.
 
 
Index: template_bootstrap.sql
===================================================================
--- template_bootstrap.sql (revision 803739)
+++ template_bootstrap.sql (working copy)
@@ -1,17 +1,17 @@
---// Bootstrap.sql
+-- // Bootstrap.sql
 
 -- This is the only SQL script file that is NOT
 -- a valid migration and will not be run or tracked
 -- in the changelog.  There is no @UNDO section.
 
---// Do I need this file?
+-- // Do I need this file?
 
 -- New projects likely won't need this file.
 -- Existing projects will likely need this file.
 -- It's unlikely that this bootstrap should be run
 -- in the production environment.
 
---// Purpose
+-- // Purpose
 
 -- The purpose of this file is to provide a facility
 -- to initialize the database to a state before iBATIS
@@ -22,7 +22,7 @@
 -- be put in this bootstrap file (but does not have
 -- to be if you are comfortable with your current process.
 
---// Running
+-- // Running
 
 -- The bootstrap SQL is run with the "migrate bootstrap"
 -- command.  It must be run manually, it's never run as


      was (Author: lqqkout4elfy):
    {code}
Index: template_changelog.sql
===================================================================
--- template_changelog.sql (revision 803739)
+++ template_changelog.sql (working copy)
@@ -1,4 +1,4 @@
---// Create Changelog
+-- // Create Changelog
 
 -- Default DDL for changelog table that will keep
 -- a record of the migrations that have been run.
@@ -19,6 +19,6 @@
   ADD CONSTRAINT PK_${changelog}
   PRIMARY KEY (id);
 
---//@UNDO
+-- //@UNDO
 
 DROP TABLE ${changelog};
\ No newline at end of file
Index: template_migration.sql
===================================================================
--- template_migration.sql (revision 803739)
+++ template_migration.sql (working copy)
@@ -1,9 +1,9 @@
---// ${description}
+-- // ${description}
 -- Migration SQL that makes the change goes here.
 
 
 
---//@UNDO
+-- //@UNDO
 -- SQL to undo the change goes here.
 
 
Index: template_bootstrap.sql
===================================================================
--- template_bootstrap.sql (revision 803739)
+++ template_bootstrap.sql (working copy)
@@ -1,17 +1,17 @@
---// Bootstrap.sql
+-- // Bootstrap.sql
 
 -- This is the only SQL script file that is NOT
 -- a valid migration and will not be run or tracked
 -- in the changelog.  There is no @UNDO section.
 
---// Do I need this file?
+-- // Do I need this file?
 
 -- New projects likely won't need this file.
 -- Existing projects will likely need this file.
 -- It's unlikely that this bootstrap should be run
 -- in the production environment.
 
---// Purpose
+-- // Purpose
 
 -- The purpose of this file is to provide a facility
 -- to initialize the database to a state before iBATIS
@@ -22,7 +22,7 @@
 -- be put in this bootstrap file (but does not have
 -- to be if you are comfortable with your current process.
 
---// Running
+-- // Running
 
 -- The bootstrap SQL is run with the "migrate bootstrap"
 -- command.  It must be run manually, it's never run as
{code}
 

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>             Fix For: 3.0 GA
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Commented: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742687#action_12742687 ]

Clinton Begin commented on IBATIS-623:
--------------------------------------

I'll make it so that this line is not executed by the script runner... that's a better solution.  That way I can use that as a demarcation to ensure that the script is not accidentally executed as is in another tool!  

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>             Fix For: 3.0 GA
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Commented: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742689#action_12742689 ]

Clinton Begin commented on IBATIS-623:
--------------------------------------

PS:  I'm running against MySql fine...

I'm on MySQL 5.0.27 on an InnoDB back end, on Mac OSX (fink package)

What configuration and version are you running?

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>             Fix For: 3.0 GA
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Commented: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742690#action_12742690 ]

Clinton Begin commented on IBATIS-623:
--------------------------------------

Oh, nm... I get it.  You mean with the 'migrate script' command.  Yes, I see now.  The internal ScriptRunner never runs comment lines.  I'll get the Script generator to exclude those --// lines.

Clinton

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>             Fix For: 3.0 GA
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Closed: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


     [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clinton Begin closed IBATIS-623.
--------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 3.0 GA)
                   3.0 Beta 2
         Assignee: Clinton Begin

Fixed.  All --// lines will be converted to --

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>            Assignee: Clinton Begin
>             Fix For: 3.0 Beta 2
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


[jira] Commented: (IBATIS-623) Generated migration scripts are not valid for MySQL

by JIRA ibatis-dev@incubator.apache.org :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


    [ https://issues.apache.org/jira/browse/IBATIS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742703#action_12742703 ]

Clinton Begin commented on IBATIS-623:
--------------------------------------

BTW:  Do NOT change the --// lines manually in the script files.  the --// is the escape sequence that identifies demarcation points in the scripts.  Changing them will cause the entire script to run (including the undo seciton).

> Generated migration scripts are not valid for MySQL
> ---------------------------------------------------
>
>                 Key: IBATIS-623
>                 URL: https://issues.apache.org/jira/browse/IBATIS-623
>             Project: iBatis for Java
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 3.0 Beta 1
>            Reporter: Ken Chau
>            Assignee: Clinton Begin
>             Fix For: 3.0 Beta 2
>
>
> When generating migration files, it generates comments with this syntax:
> --//@UNDO
> This is not valid under MySQL. There needs to be a space after the two dashes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...