[jira] Created: (JDO-641) javax.jdo.Enhancer fails to pass full path name for the file arguments

javax.jdo.Enhancer fails to pass full path name for the file arguments
----------------------------------------------------------------------

                 Key: JDO-641
                 URL: https://issues.apache.org/jira/browse/JDO-641
             Project: JDO
          Issue Type: Bug
          Components: api2
    Affects Versions: JDO 2 maintenance release 3
            Reporter: Michelle Caisse
            Assignee: Craig Russell


When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.

EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bouschen updated JDO-641:
---------------------------------

    Fix Version/s: JDO 2 maintenance release 3

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell updated JDO-641:
------------------------------

    Attachment: jdo-621.patch

Please review this patch. I've made directories work as advertised and added test cases.

I haven't tried the tck with the patch to see if that works.

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765894#action_12765894 ]

Michelle Caisse commented on JDO-641:
-------------------------------------

I get an enhancer test failure after applying the patch. No message is output. Presumably it's the new test that is failing, since all 19 tests run successfully before applying the patch.

test:compile:
    [javac] Compiling 29 source files to /home/michelle/jdo/jdo/trunk/api2/target/test-classes

    [junit] Running javax.jdo.EnhancerTest
    [junit] Tests run: 20, Failures: 1, Errors: 0, Time elapsed: 2.389 sec
-------------------------------------------------------------------------------
>> Unable to obtain goal [build]
>> Test javax.jdo.EnhancerTest failed
-------------------------------------------------------------------------------
BUILD FAILED

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766079#action_12766079 ]

Craig Russell commented on JDO-641:
-----------------------------------

Can you post the output of the failed test? The failure detail output is in the report file. If you run mvn
% cat api2/target/surefire-reports/javax.jdo.EnhancerTest.txt

if you run maven
% cat target/test-reports/TEST-javax.jdo.EnhancerTest.txt

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766192#action_12766192 ]

Michael Bouschen commented on JDO-641:
--------------------------------------

I see the same result after applying the patch and run 'maven buid' on Windows. There is no difference whether running jdk5 or jdk6.

Here is the test output, taken from EnhancerTest.txt:

Testsuite: javax.jdo.EnhancerTest
Tests run: 20, Failures: 1, Errors: 0, Time elapsed: 8,016 sec

Testcase: testDir(javax.jdo.EnhancerTest): FAILED
Expected directory enhancer-test-dir in message from out:
Enhancer Processing -v.
Enhancer found JDOEnhancer of class javax.jdo.MockEnhancer.
Enhancer property key:VendorName value:Mock Enhancer.
Enhancer property key:VersionNumber value:2.3.0.
Enhancer property key:MockKey value:MockValue.
Enhancer enhanced 0 classes.
 with err:

junit.framework.AssertionFailedError: Expected directory enhancer-test-dir in message from out:
Enhancer Processing -v.
Enhancer found JDOEnhancer of class javax.jdo.MockEnhancer.
Enhancer property key:VendorName value:Mock Enhancer.
Enhancer property key:VersionNumber value:2.3.0.
Enhancer property key:MockKey value:MockValue.
Enhancer enhanced 0 classes.
 with err:

        at javax.jdo.EnhancerTest.testDir(EnhancerTest.java:250)
        at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:195)
        at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:250)
        at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
        at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186)
        at org.apache.commons.jelly.tags.core.IfTag.doTag(IfTag.java:42)
        at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:250)
        at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
        at org.apache.maven.jelly.tags.werkz.MavenGoalTag.runBodyTag(MavenGoalTag.java:83)
        at org.apache.maven.jelly.tags.werkz.MavenGoalTag$MavenGoalAction.performAction(MavenGoalTag.java:116)
        at org.apache.maven.werkz.Goal.fire(Goal.java:691)
        at org.apache.maven.werkz.Goal.attain(Goal.java:623)
        at org.apache.maven.werkz.Goal.attainPrecursors(Goal.java:526)
        at org.apache.maven.werkz.Goal.attain(Goal.java:621)
        at org.apache.maven.werkz.Goal.attainPrecursors(Goal.java:526)
        at org.apache.maven.werkz.Goal.attain(Goal.java:621)
        at org.apache.maven.werkz.WerkzProject.attainGoal(WerkzProject.java:209)
        at org.apache.maven.jelly.tags.werkz.MavenAttainGoalTag.doTag(MavenAttainGoalTag.java:115)
        at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:250)
        at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)
        at org.apache.maven.jelly.tags.werkz.MavenGoalTag.runBodyTag(MavenGoalTag.java:83)
        at org.apache.maven.jelly.tags.werkz.MavenGoalTag$MavenGoalAction.performAction(MavenGoalTag.java:116)
        at org.apache.maven.werkz.Goal.fire(Goal.java:691)
        at org.apache.maven.werkz.Goal.attain(Goal.java:623)
        at org.apache.maven.plugin.PluginManager.attainGoals(PluginManager.java:712)
        at org.apache.maven.MavenSession.attainGoals(MavenSession.java:265)
        at org.apache.maven.cli.App.doMain(App.java:307)
        at org.apache.maven.cli.App.main(App.java:217)
        at com.werken.forehead.Forehead.run(Forehead.java:551)
        at com.werken.forehead.Forehead.main(Forehead.java:581)

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766549#action_12766549 ]

Craig Russell commented on JDO-641:
-----------------------------------

Can you verify that the test files exist. These files are zero length but should exist.

test/resources/enhancer-test-dir/file1.jdo
test/resources/enhancer-test-dir/file2.class
test/resources/enhancer-test-dir/file3.jar
test/resources/enhancer-test-dir/enhancer-test-subdir/file6.jar
test/resources/enhancer-test-dir/enhancer-test-subdir/file5.class
test/resources/enhancer-test-dir/enhancer-test-subdir/file4.jdo

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766591#action_12766591 ]

Michael Bouschen commented on JDO-641:
--------------------------------------

Oh, it looks like the patch did not create these zero length files. The test succeeds after creating these files.

So I think the patch is good to be checked in.

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766831#action_12766831 ]

Michelle Caisse commented on JDO-641:
-------------------------------------

After creating the missing files, this patch works for me also. It also works with the change for JDO-639, i.e. supplying a small set of directories for the value of jdo.tck.jdometadata.files, using the -r option to recurse. I think it's good to go.

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JDO-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Russell resolved JDO-641.
-------------------------------

    Resolution: Fixed

 clr% svn commit -m "JDO-641 Fixed directory option for Enhancer"
Sending        api2/src/java/javax/jdo/Enhancer.java
Sending        api2/test/java/javax/jdo/EnhancerTest.java
Adding         api2/test/resources/enhancer-test-dir
Adding         api2/test/resources/enhancer-test-dir/enhancer-test-subdir
Adding         api2/test/resources/enhancer-test-dir/enhancer-test-subdir/file4.jdo
Adding         api2/test/resources/enhancer-test-dir/enhancer-test-subdir/file5.class
Adding         api2/test/resources/enhancer-test-dir/enhancer-test-subdir/file6.jar
Adding         api2/test/resources/enhancer-test-dir/file1.jdo
Adding         api2/test/resources/enhancer-test-dir/file2.class
Adding         api2/test/resources/enhancer-test-dir/file3.jar
Transmitting file data ........
Committed revision 828206.

> javax.jdo.Enhancer fails to pass full path name for the file arguments
> ----------------------------------------------------------------------
>
>                 Key: JDO-641
>                 URL: https://issues.apache.org/jira/browse/JDO-641
>             Project: JDO
>          Issue Type: Bug
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Michelle Caisse
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> When a directory is supplied as an argument to the enhancer, javax.jdo.Enhancer does not pass full path name to the implementation's enhancer, so the classes cannot be fouind.
> EnhancerTest needs to be updated to test this case.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.