[jira] Created: (JDO-644) Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"

Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
---------------------------------------------------------------------

                 Key: JDO-644
                 URL: https://issues.apache.org/jira/browse/JDO-644
             Project: JDO
          Issue Type: Improvement
          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
    Affects Versions: JDO 2 maintenance release 3
            Reporter: Matthew T. Adams


It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom

For Maven1, the Maven 1 artifact id is "transaction-api":
http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom

Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.

An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JDO-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew T. Adams updated JDO-644:
---------------------------------

    Attachment: jta-01.patch

The attached patch contains this change for all version 2 components.

> Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
> ---------------------------------------------------------------------
>
>                 Key: JDO-644
>                 URL: https://issues.apache.org/jira/browse/JDO-644
>             Project: JDO
>          Issue Type: Improvement
>          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Matthew T. Adams
>         Attachments: jta-01.patch
>
>
> It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
> http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom
> For Maven1, the Maven 1 artifact id is "transaction-api":
> http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom
> Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.
> An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769028#action_12769028 ]

Michelle Caisse commented on JDO-644:
-------------------------------------

I don't think we're maintaining the -legacy projects anymore, so patch should not include files in those projects. I wasn't able to test fully on Maven 1 due to jdo-648.

> Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
> ---------------------------------------------------------------------
>
>                 Key: JDO-644
>                 URL: https://issues.apache.org/jira/browse/JDO-644
>             Project: JDO
>          Issue Type: Improvement
>          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Matthew T. Adams
>         Attachments: jta-01.patch
>
>
> It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
> http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom
> For Maven1, the Maven 1 artifact id is "transaction-api":
> http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom
> Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.
> An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769276#action_12769276 ]

Craig Russell commented on JDO-644:
-----------------------------------

This change seems innocuous enough. I agree with Michelle that we should leave legacy project alone since we have no plans to ship them.

> Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
> ---------------------------------------------------------------------
>
>                 Key: JDO-644
>                 URL: https://issues.apache.org/jira/browse/JDO-644
>             Project: JDO
>          Issue Type: Improvement
>          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Matthew T. Adams
>         Attachments: jta-01.patch
>
>
> It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
> http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom
> For Maven1, the Maven 1 artifact id is "transaction-api":
> http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom
> Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.
> An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    [ https://issues.apache.org/jira/browse/JDO-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769738#action_12769738 ]

Michelle Caisse commented on JDO-644:
-------------------------------------

Since the TCK can only be run with Maven 1, can we leave tck2/project.xml as is?

With the patch installed I get enhancer errors on running the TCK, whereas the api2 project builds without error.

16:36:40,468 (main) ERROR [DataNucleus.MetaData] - Class "org.apache.jdo.tck.pc.companyListWithoutJoin.CompanyModelReader" was not found in the CLASSPATH. Please check your specification and your CLASSPATH.
org.datanucleus.exceptions.ClassNotResolvedException: Class "org.apache.jdo.tck.pc.companyListWithoutJoin.CompanyModelReader" was not found in the CLASSPATH. Please check your specification and your CLASSPATH.
        at org.datanucleus.JDOClassLoaderResolver.classForName(JDOClassLoaderResolver.java:250)
        at org.datanucleus.JDOClassLoaderResolver.classForName(JDOClassLoaderResolver.java:415)
        at org.datanucleus.metadata.MetaDataManager.loadClasses(MetaDataManager.java:436)
        at org.datanucleus.enhancer.DataNucleusEnhancer.getFileMetadataForInput(DataNucleusEnhancer.java:703)
        at org.datanucleus.enhancer.DataNucleusEnhancer.enhance(DataNucleusEnhancer.java:551)
        at org.datanucleus.jdo.JDODataNucleusEnhancer.enhance(JDODataNucleusEnhancer.java:126)
        at javax.jdo.Enhancer.run(Enhancer.java:196)
        at javax.jdo.Enhancer.main(Enhancer.java:130)

for:
org.apache.jdo.tck.pc.mylib.MylibReader
org.apache.jdo.tck.pc.companyListWithoutJoin.CompanyModelReader
org.apache.jdo.tck.pc.companyMapWithoutJoin.CompanyModelReader
org.apache.jdo.tck.pc.company.CompanyModelReader
org.apache.jdo.tck.pc.order.OrderModelReader

There are also test errors, including the runonce test.

I haven't tried to upload jta 1.1, but why would it be found for api2 and not tck2? The only possibly relevant difference I can see is that api2 has a pom.xml and tck2 does not.

> Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
> ---------------------------------------------------------------------
>
>                 Key: JDO-644
>                 URL: https://issues.apache.org/jira/browse/JDO-644
>             Project: JDO
>          Issue Type: Improvement
>          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Matthew T. Adams
>         Attachments: jta-01.patch
>
>
> It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
> http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom
> For Maven1, the Maven 1 artifact id is "transaction-api":
> http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom
> Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.
> An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JDO-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michelle Caisse updated JDO-644:
--------------------------------

    Attachment: jta-01-new.patch

Per discussion at the last teleconference, propose using this new patch that modifies only api2/pom.xml, which is the only build file used by Maven 2. This should solve the problem with Maven 2 and avoid any issues for Maven 1 users.

> Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
> ---------------------------------------------------------------------
>
>                 Key: JDO-644
>                 URL: https://issues.apache.org/jira/browse/JDO-644
>             Project: JDO
>          Issue Type: Improvement
>          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Matthew T. Adams
>         Attachments: jta-01-new.patch, jta-01.patch
>
>
> It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
> http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom
> For Maven1, the Maven 1 artifact id is "transaction-api":
> http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom
> Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.
> An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

     [ https://issues.apache.org/jira/browse/JDO-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michelle Caisse resolved JDO-644.
---------------------------------

    Resolution: Fixed

Completed with revision 882404

> Change JTA 1.1 dependency artifact id from "transaction-api" to "jta"
> ---------------------------------------------------------------------
>
>                 Key: JDO-644
>                 URL: https://issues.apache.org/jira/browse/JDO-644
>             Project: JDO
>          Issue Type: Improvement
>          Components: api2, api2-legacy, core2, enhancer2, fostore2, model2, query2, runtime2, tck2, tck2-legacy, util2
>    Affects Versions: JDO 2 maintenance release 3
>            Reporter: Matthew T. Adams
>         Attachments: jta-01-new.patch, jta-01.patch
>
>
> It appears that the Maven 2 artifact id for JTA 1.1 is "jta", not "transaction-api".  The Maven 2 POM is here:
> http://mirrors.ibiblio.org/pub/mirrors/maven2/javax/transaction/jta/1.1/jta-1.1.pom
> For Maven1, the Maven 1 artifact id is "transaction-api":
> http://download.java.net/maven/1/javax.transaction/poms/transaction-api-1.1.pom
> Since most users use Maven2, this should be updated to "jta" and we, the team producing JDO, should just manually install JTA 1.1 into our own local Maven 1 repository with the artifact id "jta", using the Maven 2.  Without this, it is extremely annoying for users to have to work around this.
> An alternative solution would be to upload to the Maven 1 central repo a copy of JTA 1.1 with artifact id "jta", but I don't how to do that.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.